Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126218
Date: Thu, 23 Jan 2025 17:03:59 +0000
To: Kamil Tekiela <tekiela246@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Subject: Re: [PHP-DEV] Use usual semantics for PDO::FETCH_CLASS constructor arguments
Message-ID: <VWT5hk3lF7i8PJNfD2AARNslVLRN-0gsdPW356SwkrHetthpvprHyC23q2r5M3VVq0jRLP0gsgBbdbfpCKeCeMS2zGTcJjQsU0P7IvjePvQ=@gpb.moe>
In-Reply-To: <CAGBsUrfC9Q6DB4LLERESMRBQtKape=iB2_3uq62H+rUHOAe4_A@mail.gmail.com>
References: <rAlEx_hYFBFbQdkaMGhgr0pyjY6nU4tGMlrmm7hD68vJnkHPYaNRq0PBP-mpkVNUFd08UCX8FX_s55TqiEMr3WTjJNp8xGFTglS-JWETM-M=@gpb.moe> <CAGBsUrfC9Q6DB4LLERESMRBQtKape=iB2_3uq62H+rUHOAe4_A@mail.gmail.com>
Feedback-ID: 96993444:user:proton
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: internals@gpb.moe ("Gina P. Banyard")

On Tuesday, 21 January 2025 at 12:36, Kamil Tekiela <tekiela246@gmail.com> =
wrote:

> Hi Gina,
>=20
> Your proposal makes sense to me. I agree that the behaviour should be
> consistent.
> If I understand correctly, an associative array currently binds only
> to positional arguments. If you make this change, how will it interact
> with PDO::FETCH_PROPS_LATE? Am I correct in assuming that this will
> also be a BC break? Will the values coming from the DB take over if no
> matching param is found in the constructor array?
>=20
> Regards,
> Kamil

I'm not exactly sure to understand the concern.
PDO assigns values directly to properties using the column name as the prop=
erty name, and if the property does not exist, create a dynamic one.
By default, PDO will assign the properties prior to calling the constructor=
 with the provided constructor arguments.
Using PDO::FETCH_PROPS_LATE the order is flipped, the constructor is called=
 first with the provided arguments, and then PDO populates the properties.

What the constructor does with the constructor arguments is up to the const=
ructor.
If it overwrites a property / set a default value then yes this can overwri=
te values from the DB.
But this issue already exists with positional arguments.
And the constructor could do something completely different with the provid=
ed arguments that do not interfere at all with values coming from the DB.

Hope this clarifies the behaviour.

Best regards,

Gina P. Banyard