Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:126176 X-Original-To: internals@lists.php.net Delivered-To: internals@lists.php.net Received: from php-smtp4.php.net (php-smtp4.php.net [45.112.84.5]) by qa.php.net (Postfix) with ESMTPS id 846C71A00BD for ; Tue, 24 Dec 2024 19:38:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=php.net; s=mail; t=1735068917; bh=RHpnPg2L2XtcdXQBGfSVjxXa8IKuUC51MSextgO1+fE=; h=Date:From:To:In-Reply-To:References:Subject:From; b=V4RE/nTHPsGxpArlXVQKQDlwxceITlOzZBDFzZNJPxQNW3bvatR8dqbuufSSgT1Ay /BzPqU/oDs9M413ibHRdpMC1k7eTlh83/zrLFD5Hzo08lF45eiUlMdbBYKB1y5kI5k RKzgsQrRhACQQOM8vFYio8NU2qZnri/EprvtzCQ75OUzhtXYa/xTH4u10ascWOOpuT Maak0pEGOxXsopirunWL61kLNID6P4wmAoIFbi6kdU2aD8UtfXmN0F2ZRPQ5MlCADI j0lmYb/ZO9RpTLV1OyugwABlcoY2/3mjBTpdHTHhP7fgDCiCP2BjmxDpmr/5sujJCw RY/uuqG+RMukQ== Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 63B4618007C for ; Tue, 24 Dec 2024 19:35:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=BAYES_50,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,DMARC_MISSING,RCVD_IN_DNSWL_LOW, SPF_HELO_PASS,SPF_NONE autolearn=no autolearn_force=no version=4.0.0 X-Spam-Virus: No X-Envelope-From: Received: from fout-a2-smtp.messagingengine.com (fout-a2-smtp.messagingengine.com [103.168.172.145]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Tue, 24 Dec 2024 19:35:15 +0000 (UTC) Received: from phl-compute-01.internal (phl-compute-01.phl.internal [10.202.2.41]) by mailfout.phl.internal (Postfix) with ESMTP id ED0EB138016A for ; Tue, 24 Dec 2024 14:38:13 -0500 (EST) Received: from phl-imap-06 ([10.202.2.83]) by phl-compute-01.internal (MEProxy); Tue, 24 Dec 2024 14:38:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= garfieldtech.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to; s=fm2; t=1735069093; x=1735155493; bh=+qurvXEz5LSdQMAKLTUNd TqDYfQDNT1p+KVEFtw4RXI=; b=coORohcA9h/c12g7zFWzaLQC0hun4HDdexqaA loioaqupx90BkjT23Jf4i33EtCCvEifOsV3VDrzJSYsBQSIc/Hik/gPIfsHiw+WT Vyku1EZvxmtilp6LI6t+92p7CEWhIbZh/q96XbWNahsNmCZBmtu1WIUjlBKg+6pk sS79UThUxM2D30wQhR163OQw69d/3+s/HuFVwGyew4WCqpQtfKclWWwFFV2ax/AV ykIQh+BFozAE44aDzqJfKQsYL3cHn6VrPR3uvmKN0TLdvTVLnNvUROk/VIsf3SCz UUEzFBqw55W3y9wMT0Nys+tU2T9FKIOtJ0LPFDYXV20ytDT9w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; t=1735069093; x=1735155493; bh=+ qurvXEz5LSdQMAKLTUNdTqDYfQDNT1p+KVEFtw4RXI=; b=dKLSVrOWiARZybMdv y7XZBlwvXhI0n/sSGqeEMo9aco5VFEwYCimkbQPxDLXrnNTi9eQvp8+vtm4Be+hr sLCaGBB4Clpzy9oy0SVqUltgc4qC9JZn8RdClf/qF8qlOTgxi7UGQ/0TGFo/kRLX hclfIQ/P7evsZTFf8Vf8wGzQELufpcIPHDr7kIvdEudgvO05BN4xtQYVOkSNiILH GlmFwo1o/gTcA7INUWNw00t8ZHVq5nk71XlxdBqpwHfDObEc0YB6IdH7QPxBTGHX jTRZ59Ugnkoj95eZctOHvlKUj0vbWWfCWMxY+gCe74Gjr9bdjPWvHQDDtTlqlo5j yU+2g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddruddugedguddvfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefoggffhffvkfgjfhfutgfgsehtqhertdertdej necuhfhrohhmpedfnfgrrhhrhicuifgrrhhfihgvlhgufdcuoehlrghrrhihsehgrghrfh hivghlughtvggthhdrtghomheqnecuggftrfgrthhtvghrnhepuefgteeijeeuveffudel hffhtefhkeevtdeuvefgffdvfeeivdetgfehveetleffnecuffhomhgrihhnpehphhhprd hnvghtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhep lhgrrhhrhiesghgrrhhfihgvlhguthgvtghhrdgtohhmpdhnsggprhgtphhtthhopedupd hmohguvgepshhmthhpohhuthdprhgtphhtthhopehinhhtvghrnhgrlhhssehlihhsthhs rdhphhhprdhnvght X-ME-Proxy: Feedback-ID: i8414410d:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 89F3829C006F; Tue, 24 Dec 2024 14:38:13 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk list-help: list-post: List-Id: internals.lists.php.net x-ms-reactions: disallow MIME-Version: 1.0 Date: Tue, 24 Dec 2024 13:37:53 -0600 To: "php internals" Message-ID: <2556faa6-c233-4809-8999-afe1af40f4f1@app.fastmail.com> In-Reply-To: References: <7228b901-a6a9-4aa9-8425-5ad51f66a853@gmx.de> Subject: Re: [PHP-DEV] C Unit testing and mocking Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: larry@garfieldtech.com ("Larry Garfield") On Sun, Dec 22, 2024, at 9:23 AM, Jakub Zelenka wrote: > On Mon, Dec 16, 2024 at 9:05=E2=80=AFPM Christoph M. Becker wrote: >> On 16.12.2024 at 14:18, Jakub Zelenka wrote: >> > There was a suggestion of RFC but that might be a bit too much as i= t's just >> > an internal change / addition. But certainly some overview on inter= nals >> > should be done so writing this instead. >>=20 >> I'm fine with not going through the RFC process, although the policy[= 1] >> police might come after us. :) >>=20 > > I think it fits to all inclusion criteria and doesn't go against any=20 > exclusion. Maybe except that "de facto standard" but for our use there=20 > was really no other option as I mentioned in my comparison so it was=20 > the only library left for our needs if there is only one, then it's "d= e=20 > facto standard" we could say. > > Btw. It was probably mistake to set that policy for C code because we=20 > don't really need to care if PHP recommends any tool there - I=20 > completely missed it when voting for it. This should be just for PHP=20 > application that we care about. We should modify that policy=20 > accordingly - I need to make a list of changes that to the policies as=20 > there are quite a few points. > > Regards, > > Jakub Point of order: The recently adopted 3rd party code policy does not appl= y to C tooling. It mentions "PHP Tooling", which is defined as "PHP cod= e run by PHP.net". The website, docs tooling, etc. It has no bearing o= n what C libraries or toolchains can or should be used in php-src itself= . (Whether that's unit testing, url parsers, HTML parsers, threading li= braries, etc.) I have no opinion or experience on C testing frameworks, other than "yes= , tests please!" :-) --Larry Garfield