Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126168
Precedence: bulk
MIME-Version: 1.0
References: <CAEKnhAEFJKPWWL0EKu_JBPgwBEe+Pk3GDzR7HQm3J-g7=Wk0BA@mail.gmail.com>
 <7228b901-a6a9-4aa9-8425-5ad51f66a853@gmx.de> <a77ccf73-f451-435b-bbbc-ee6ffcf0e52c@gmx.de>
In-Reply-To: <a77ccf73-f451-435b-bbbc-ee6ffcf0e52c@gmx.de>
Date: Sun, 22 Dec 2024 16:30:42 +0100
Message-ID: <CAEKnhAF4_CUB27jT1NxEALi9HjF7pOj4AHS6zT6eqB1Mt9u8Bw@mail.gmail.com>
Subject: Re: [PHP-DEV] C Unit testing and mocking
To: "Christoph M. Becker" <cmbecker69@gmx.de>
Cc: PHP internals list <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000c2a46a0629dd907f"
From: bukka@php.net (Jakub Zelenka)

--000000000000c2a46a0629dd907f
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Dec 19, 2024 at 1:10=E2=80=AFPM Christoph M. Becker <cmbecker69@gmx=
.de>
wrote:

> On 16.12.2024 at 21:05, Christoph M. Becker wrote:
>
> > Especially on Windows, where we have different code paths, and sometime=
s
> > even completely different code, it would be great to also have these
> > unit tests.  Given that link.exe supports /alternatename, a bit of
> > additional macro magic might do the trick[2].  I'll try to have a stab
> > at this soon.
>
> I had a closer look, and it's getting pretty tricky.  First, we would
> need a static php.lib (doable, but so far not supported by the build
> system).  Then, apparently, we would need to get rid of the
> __declspec(dllimport) at least for the functions we want to mock when
> building php.lib; to do that it might be necessary to use modified
> copies of the WindowSDK headers.  Ugly.
>
> And then we might need an own unit test suite for Windows; at least as
> is, test_network.c makes quite some assumptions regarding code paths
> (e.g. that poll(2) is called), which are not portable.  I'm not sure
> it's worth pursuing this for other platforms than Linux.
>
>
Agreed that running the tests on Windows might not be worth the effort.
However, many of the tests likely aren't strictly Linux-specific, so even
if they only run on Linux, they can still help improve the quality of code
across all platforms. So it's good for Windows as well :)

Regards,

Jakub

--000000000000c2a46a0629dd907f
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g=
mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Thu, Dec 19,=
 2024 at 1:10=E2=80=AFPM Christoph M. Becker &lt;<a href=3D"mailto:cmbecker=
69@gmx.de">cmbecker69@gmx.de</a>&gt; wrote:<br></div><blockquote class=3D"g=
mail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204=
,204,204);padding-left:1ex">On 16.12.2024 at 21:05, Christoph M. Becker wro=
te:<br>
<br>
&gt; Especially on Windows, where we have different code paths, and sometim=
es<br>
&gt; even completely different code, it would be great to also have these<b=
r>
&gt; unit tests.=C2=A0 Given that link.exe supports /alternatename, a bit o=
f<br>
&gt; additional macro magic might do the trick[2].=C2=A0 I&#39;ll try to ha=
ve a stab<br>
&gt; at this soon.<br>
<br>
I had a closer look, and it&#39;s getting pretty tricky.=C2=A0 First, we wo=
uld<br>
need a static php.lib (doable, but so far not supported by the build<br>
system).=C2=A0 Then, apparently, we would need to get rid of the<br>
__declspec(dllimport) at least for the functions we want to mock when<br>
building php.lib; to do that it might be necessary to use modified<br>
copies of the WindowSDK headers.=C2=A0 Ugly.<br>
<br>
And then we might need an own unit test suite for Windows; at least as<br>
is, test_network.c makes quite some assumptions regarding code paths<br>
(e.g. that poll(2) is called), which are not portable.=C2=A0 I&#39;m not su=
re<br>
it&#39;s worth pursuing this for other platforms than Linux.<br><br></block=
quote><div><br></div><div>Agreed that running the tests on Windows might no=
t be worth the effort. However, many of the tests likely aren&#39;t strictl=
y Linux-specific, so even if they only run on Linux, they can still help im=
prove the quality of code across all platforms. So it&#39;s good for Window=
s as well :)<br></div><div><br></div><div>Regards,</div><div><br></div><div=
>Jakub</div></div></div>

--000000000000c2a46a0629dd907f--