Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:126167 X-Original-To: internals@lists.php.net Delivered-To: internals@lists.php.net Received: from php-smtp4.php.net (php-smtp4.php.net [45.112.84.5]) by qa.php.net (Postfix) with ESMTPS id D40C51A00BD for ; Sun, 22 Dec 2024 15:23:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=php.net; s=mail; t=1734880828; bh=SoB0utlnDp98Lr6qHfn0Krw3/w+gUiCu7M3X+8YcpZw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=OTKlOgQJo3s/qnFP1FkCF5X6PWyZ7U7LL7n6dQ+xaW4zPfV1HqBlU9au3aTvF6vy2 gdBvMq54rz4I4LIDbRuR7Ia2Qj+GLkTUAvEp7qWpNnjxPhtD4RLdukus/88YBKL22H 8t/plo04AwTVI7fEbyezqa2jlKb7E/6Va6yl1ExvqXuFRDKhrRcTu8fsw6rkaao3j7 rW7iZkGqQNUV3PeaKXZX4yWTiL/MD/VdQ/0u/Z2ORbnbEvomtkoCAvoHAbWwGtHAZh lpXdMsRk1t/Ob8WUCStyEXokTy2xPPQ68xxoh4hQPrTW5CZUpJ8dar6si3hA7DSdv/ FXaLQEsta0tNw== Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 2AAFE18006A for ; Sun, 22 Dec 2024 15:20:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on php-smtp4.php.net X-Spam-Level: * X-Spam-Status: No, score=2.0 required=5.0 tests=BAYES_50,DMARC_NONE, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=4.0.0 X-Spam-Virus: No X-Envelope-From: Received: from mail-oa1-f50.google.com (mail-oa1-f50.google.com [209.85.160.50]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Sun, 22 Dec 2024 15:20:27 +0000 (UTC) Received: by mail-oa1-f50.google.com with SMTP id 586e51a60fabf-29fae583cc8so1846381fac.1 for ; Sun, 22 Dec 2024 07:23:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734881001; x=1735485801; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SoB0utlnDp98Lr6qHfn0Krw3/w+gUiCu7M3X+8YcpZw=; b=JkGHAHwcHvlxjfMXb1tRZhR1azPT2nIwWbl5amtyfHkytD26uoReOkSCsD+Y+tZvYv gIEkIGzCUqyW8EZ34EPGTUZ3wP3RErGh6K2GO/OgtgiEBw+d3iG1L4i2xPlgnTyejoGZ oQC7SpJL36e4nFw0UiYytrYLmBCa38tk5YQ19ZhNs7UEqbqNM4azZJjx15FY65IQW0T4 /t+6IGqg1jikBgbFo6+nWwsFkFZY05USMg0p+naA7GMXygeVnIhZ4DwJVMUNAI4nSXCH OF1P19Io0jZjOaT7DPb8I1SNlYdFUN/JKo7gwubyfane0ZjYOEH9HD4RA7gUQ7EgiI5I K/9Q== X-Gm-Message-State: AOJu0Yxuw4kvxmfJjYVd67ESZFObpQuc1jl4TABCpzaEKQnrY70VuiVV jGZ33yeI91Y1uL48nbxgdEbrdKMXk+CIp6dmQZ0UCUDkk9bHP5gQ9ycOfXZ96ntgbA/CY69zx82 RxdipJB9TXf9tZN3RL6CJ5dbWwX3q6gvD X-Gm-Gg: ASbGncvsWpS9HCYCot5L6q30x5r0X+t40xb0vJSNvaHhnHL3mhB+ciAzgrMlOUOtJjS 5wNKcnvoQF9QimGerpLV6y0XYlPAlierk/MvV X-Google-Smtp-Source: AGHT+IHI+j7wckXkoOsJY2BvKi4k4DukEi04se1iLV0ADE2dyQy5f8j0xt56riNZpzwBixxQSH/RX0rQt54FRtuw7Bo= X-Received: by 2002:a05:6870:a548:b0:29e:5957:2946 with SMTP id 586e51a60fabf-2a7fcd43b6fmr5550173fac.19.1734881001096; Sun, 22 Dec 2024 07:23:21 -0800 (PST) Precedence: bulk list-help: list-post: List-Id: internals.lists.php.net x-ms-reactions: disallow MIME-Version: 1.0 References: <7228b901-a6a9-4aa9-8425-5ad51f66a853@gmx.de> In-Reply-To: <7228b901-a6a9-4aa9-8425-5ad51f66a853@gmx.de> Date: Sun, 22 Dec 2024 16:23:09 +0100 Message-ID: Subject: Re: [PHP-DEV] C Unit testing and mocking To: "Christoph M. Becker" Cc: PHP internals list Content-Type: multipart/alternative; boundary="000000000000cc4c560629dd7587" From: bukka@php.net (Jakub Zelenka) --000000000000cc4c560629dd7587 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Dec 16, 2024 at 9:05=E2=80=AFPM Christoph M. Becker wrote: > On 16.12.2024 at 14:18, Jakub Zelenka wrote: > > There was a suggestion of RFC but that might be a bit too much as it's > just > > an internal change / addition. But certainly some overview on internals > > should be done so writing this instead. > > I'm fine with not going through the RFC process, although the policy[1] > police might come after us. :) > > I think it fits to all inclusion criteria and doesn't go against any exclusion. Maybe except that "de facto standard" but for our use there was really no other option as I mentioned in my comparison so it was the only library left for our needs if there is only one, then it's "de facto standard" we could say. Btw. It was probably mistake to set that policy for C code because we don't really need to care if PHP recommends any tool there - I completely missed it when voting for it. This should be just for PHP application that we care about. We should modify that policy accordingly - I need to make a list of changes that to the policies as there are quite a few points. Regards, Jakub --000000000000cc4c560629dd7587 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Mon, Dec 16, 2024 at 9:05=E2=80=AFPM C= hristoph M. Becker <cmbecker69@gmx.= de> wrote:
On 16.12.2024 at 14:18, Jaku= b Zelenka wrote:
> There was a suggestion of RFC but that might be a = bit too much as it's just
> an internal change / addition. But certainly some overview on internal= s
> should be done so writing this instead.

I'm fine with not going through the RFC process, although the policy[1]=
police might come after us. :)


I think it fits to all inclusion crite= ria and doesn't go against any exclusion. Maybe except that "de fa= cto standard" but for our use there was really no other option as I me= ntioned in my comparison so it was the only library left for our needs if t= here is only one, then it's "de facto standard" we could say.=

Btw. It was probably mistake to set that policy f= or C code because we don't really need to care if PHP recommends any to= ol there - I completely missed it when voting for it. This should be just f= or PHP application that we care about. We should modify that policy accordi= ngly - I need to make a list of changes that to the policies as there are q= uite a few points.

Regards,

Jakub
--000000000000cc4c560629dd7587--