Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126160
Message-ID: <614d3f45-0f54-4a2e-a21e-2eec5f496fa0@gmail.com>
Date: Sat, 21 Dec 2024 21:50:52 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] Discussion: Remove file statcache?
To: internals@lists.php.net
References: <27531d9d-9bfe-4acc-b9ab-80b1017e3038@app.fastmail.com>
 <CAEKnhAFU32EXh483QzR0LLUt+Jou4ejKjOXqBQ_G43wR7LW5cA@mail.gmail.com>
 <ACB1A7C2-FAF5-4A43-BBB9-A3E8469E2385@rwec.co.uk>
 <21dd9ac7-e81b-4509-bfa4-a36d05237270@gmail.com>
 <F31E457C-B04D-41D3-A544-0A1E7F139261@rwec.co.uk>
Content-Language: en-US
In-Reply-To: <F31E457C-B04D-41D3-A544-0A1E7F139261@rwec.co.uk>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
From: dossche.niels@gmail.com (Niels Dossche)

On 21/12/2024 21:38, Rowan Tommins [IMSoP] wrote:
> 
> 
> On 21 December 2024 18:49:46 GMT, Niels Dossche <dossche.niels@gmail.com> wrote:
>>> $perms = fileperms($name, statcache: true);
>>> $size = filesize($name, statcache: true);
>>
>> In my opinion, this will become very messy.
> 
> Could you elaborate?

Adding a parameter for a cache, which should've been transparent in the first place, to every file operation is messy.
A cache should normally be transparent, and the reason we're having this discussion in the first place is because the cache isn't transparent and causes problems. Adding an extra parameter is going further away from transparency. It's also inconvenient for programmers to add this to different places in their codebase.

> 
> 
>> Changing a default would be another BC break.
> 
> "Another" after what? Adding either an INI setting or an optional parameter is not a BC break, unless and until the default is changed, at which point there is exactly one BC break. 

Adding an INI: no BC break indeed.
But if you want to add extra parameters to functions that can potentially touch the stat cache, then you need to take into account spl as well. Adding extra parameters to the functions in those classes are a BC break because the signature of potential userland function overrides would no longer be compatible at compile time.

> 
> Regards,
> Rowan Tommins
> [IMSoP]

Kind regards
Niels