Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126136
Message-ID: <a77ccf73-f451-435b-bbbc-ee6ffcf0e52c@gmx.de>
Date: Thu, 19 Dec 2024 13:09:56 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] C Unit testing and mocking
Content-Language: de-DE
To: Jakub Zelenka <bukka@php.net>,
 PHP internals list <internals@lists.php.net>
References: <CAEKnhAEFJKPWWL0EKu_JBPgwBEe+Pk3GDzR7HQm3J-g7=Wk0BA@mail.gmail.com>
 <7228b901-a6a9-4aa9-8425-5ad51f66a853@gmx.de>
In-Reply-To: <7228b901-a6a9-4aa9-8425-5ad51f66a853@gmx.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
UI-OutboundReport: notjunk:1;M01:P0:YsWp6ncujeE=;Ap1Z1gWR7eQF3JdC94SE9zLdARx
 iPya6/T+Gv0lfiYPs2OsOY4Lrpfdh8tTZ27JEpTuDGlmds1NJyF6FFoEAnaD9PGsmKi1xLYf6
 1Z7puL4vyWcqN556fy9YtUXZ30O9DEkWq2S5Cb3WY3JxnMqHLYkvVca7oS30jlsCTg/A/Q9dg
 3PoHbgyNqtM0gYDi0fIvR4WF2Qm4dgF5OepXrRsfylSdXo0fEsMvEyi+sJPH6IgH99oDPUjKc
 +gXOod5wFvfumikRhSh+T3/bum9sTaS/zBECBToAlB4rCx3bmOtZBcJa1TAqe3PU3nn6/XB/e
 BQYkUhIL4msRQXVju0Qa6IdmrQv8QntK4YsgfMz0Y1rdQ8AIcEn1eN/gSeCOedtZHJOcy+Lax
 QW+ypVW1uiK5X55Cu14Hs4tTIsCbFUSGjatZt3qq6Al0LjGv8W9u/0efuL5gE2ry1PEjouf8q
 034nRQT03LeIb4dMA1jYw2AMPgYnb81RAkczzX6r6Gq8c6+uUGgqnREOgjlEubTclgrFv54fv
 iVnbcRYyy8N45PD7wK6L9qyHjmzGiK3BFlp4+oKwibn228YHwdNHOnVsRe4c3utlCDzgo4273
 651VNzQ5Hw6ILKT4dYTlqTOXF3FQ8n5qyfnrenaE3t1SE9LH0ueIis7GTgn37UPrmDxonrfRv
 aO7tRZZG7SkVapSLKAL7Q0mLSkMWUFfZ3Oos+OD+zEPLFoSe9qw7b/kL09lsOIhnHdXxIRDri
 Z8Z9lLsbxPuZSnhV//EWqUcSuVPbbZbPwinL1yRzGWrQKQMA0XRY/VKziKLtDc6vOYAr38TS0
 orSX0mg10+kgVGwVrgmJTiTlWovZJCHRVN12Fq0R/FpXaJq2wGDlk6qJvQi1Ypu9TEpTCAob8
 SG1gkegW1vE18/1lSDkNfdoIp8JkMwZeJ+HGJNKGLkVMXYoVNI0xQZWlCbvn2bhXhXKknQN5f
 VArKYyJCtNYLAjkTU6GBodstZUrxWdtCj436+LjXjv3nvn0EjSQVaB4y+o1E9JBma//oLp1/W
 6m1tGJhJ9vLC+KKo4+wJwf49oo6HN8rbuLVZ+Tic8QT53AJ7RISmgavIGb9RnFb0cZAdYBtdn
 8vCYTfUIMCuTpHTwB1uwHEjoEgQjGL
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 16.12.2024 at 21:05, Christoph M. Becker wrote:

> Especially on Windows, where we have different code paths, and sometimes
> even completely different code, it would be great to also have these
> unit tests.  Given that link.exe supports /alternatename, a bit of
> additional macro magic might do the trick[2].  I'll try to have a stab
> at this soon.

I had a closer look, and it's getting pretty tricky.  First, we would
need a static php.lib (doable, but so far not supported by the build
system).  Then, apparently, we would need to get rid of the
__declspec(dllimport) at least for the functions we want to mock when
building php.lib; to do that it might be necessary to use modified
copies of the WindowSDK headers.  Ugly.

And then we might need an own unit test suite for Windows; at least as
is, test_network.c makes quite some assumptions regarding code paths
(e.g. that poll(2) is called), which are not portable.  I'm not sure
it's worth pursuing this for other platforms than Linux.

Christoph