Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126116
Feedback-ID: i8414410d:Fastmail
Precedence: bulk
MIME-Version: 1.0
Date: Thu, 05 Dec 2024 17:43:29 -0600
To: "php internals" <internals@lists.php.net>
Message-ID: <2786d545-2047-40f9-a428-1437238b247d@app.fastmail.com>
In-Reply-To: <6c1b378a-4c93-4747-bb5a-84d133c95d8b@gmx.de>
References: 
 <CAH5C8xUb1O20ZDrOQNC=ckFxHUUWSK7sw_njQQzFBd0qgQqoww@mail.gmail.com>
 <dd61999c-1ebd-4765-9add-cd8065968965@gmail.com>
 <CAOV5rgYZ_s1of-igLFEK7oqqh6=3HeYv0=JvvKvvjkcp0F6Q9Q@mail.gmail.com>
 <CAH5C8xV67frqOBCvLt73RM7QO86_pu40sHP5h71_kDRbKPtA8Q@mail.gmail.com>
 <57d09ef6591a4c70e60569b9de7ce330@bastelstu.be>
 <CAH5C8xXhHk2QjM5+VzKPFkBoLpO+kR-Tqr_o1YoaW=fkURHQFA@mail.gmail.com>
 <6c1b378a-4c93-4747-bb5a-84d133c95d8b@gmx.de>
Subject: Re: [PHP-DEV] [RFC] [Discussion] Add WHATWG compliant URL parsing API
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: larry@garfieldtech.com ("Larry Garfield")

On Thu, Dec 5, 2024, at 5:16 PM, Christoph M. Becker wrote:
> On 05.12.2024 at 22:49, M=C3=A1t=C3=A9 Kocsis wrote:
>
>>> I'm not sure I like the `Interface` suffix on the `UriInterface`
>>> interface. Just `Uri\Uri` would be equally expressive.
>>
>> Yes, I was expecting this debate :) To be honest, I never liked inter=
faces
>> without an "Interface"
>> suffix, and my dislike didn't go away when I had to use such an inter=
face
>> somewhere, because it
>> was difficult for me to find out what the symbol I was typing actually
>> referred to.
>
> By the same argument, you could come up with code like
>
> <?php
> class User {
>     const defaultGroupNameConstant =3D "users";
>     private string $nameVariable;
>     public function getNameMethod() {=E2=80=A6}
>     =E2=80=A6
> }
> ?>
>
>> But apart from my personal
>> experiences, I prefer to stay with "UriInterface" because the 2 most =
well
>> known internal PHP interfaces
>> also have the same suffix (DateTimeInterface, SessionInterface), and =
this
>> name definitely conveys that
>> people should not try to instantiate it.
>
> DateTimeInterface has been introduced after there had already been
> DateTime.  Otherwise, we would likely have DateTime, DateTimeMutable a=
nd
> DateTimeImmutable.  (Or only DateTime as immutable class.)
>
> SessionHandler/SessionHandlerInterface have been bad naming choices, in
> my opinion.  The interface could have been SessionHandler, and the cla=
ss
> DefaultSessionHandler (and should have been final).  I dislike these
> Interface and Implementation (or abbreviations of these) suffixes.
>
> Christoph

I used to be in favor of *Interface, but over time realized how useless =
it was. :-)  I have stopped doing it in my own code and my code reads wa=
y better.  Also, the majority of PHP's built in interfaces (Traversable,=
 Countable, etc.) are not suffixed, AFAIK, so it's better to avoid it fo=
r consistency.  As noted, DateTimeInterface is a special case outlier.

--Larry Garfield