Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126109
Message-ID: <3504447f-009b-497b-a0f3-6fb1670ab410@bastelstu.be>
Date: Thu, 5 Dec 2024 21:57:00 +0100
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PHP-DEV] [RFC] [Discussion] Attributes on compile-time constants
To: Daniel Scherzer <daniel.e.scherzer@gmail.com>
Cc: internals@lists.php.net
References: <CALaXqqRUkcdAnNmVM2=rtrVbOFDgDYqdycDJS48ptxZ65HDfQw@mail.gmail.com>
 <175e84d9-5568-413b-ab1c-57d8959adf06@bastelstu.be>
 <CALaXqqRqFZZCVuqbT-LmApaYaXn6WFHDSZHDsAQe1cwO8daXpg@mail.gmail.com>
Content-Language: en-US
In-Reply-To: <CALaXqqRqFZZCVuqbT-LmApaYaXn6WFHDSZHDsAQe1cwO8daXpg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

On 12/3/24 15:40, Daniel Scherzer wrote:
>> This is not just extensions, but also userland code that did not
>> anticipate any new attribute targets.
>>
> 
> Given that
> 1. there isn't (as far as I know) a way to search for everything that has
> an attribute
> 2. there isn't a current way to identify if a constant has an attribute
> 
> I didn't think there was anything to actually break for userland
> attributes, but I've reworded the note to include userland attributes just
> in case.

Here's an example of a userland library that collects attributes as a 
“build time” step:

https://github.com/olvlvl/composer-attribute-collector

If that library is updated to understand attributes on constants and a 
user applies a TARGET_ALL attribute on a constant, then this case would 
apply.

Even if it ultimately is “just in case”, it’s nevertheless helpful to 
spell out all possible caveats for the reader to make an informed 
decision about the RFC. So thank you for the update :-)

------------

With the updated version, I don't have any further comments about your 
RFC text.

Best regards
Tim Düsterhus