Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126098
Precedence: bulk
MIME-Version: 1.0
References: <CALaXqqRUkcdAnNmVM2=rtrVbOFDgDYqdycDJS48ptxZ65HDfQw@mail.gmail.com>
 <175e84d9-5568-413b-ab1c-57d8959adf06@bastelstu.be>
In-Reply-To: <175e84d9-5568-413b-ab1c-57d8959adf06@bastelstu.be>
Date: Tue, 3 Dec 2024 06:40:42 -0800
Message-ID: <CALaXqqRqFZZCVuqbT-LmApaYaXn6WFHDSZHDsAQe1cwO8daXpg@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] [Discussion] Attributes on compile-time constants
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary="000000000000800c8c06285ea887"
From: daniel.e.scherzer@gmail.com (Daniel Scherzer)

--000000000000800c8c06285ea887
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Dec 2, 2024 at 2:48=E2=80=AFPM Tim D=C3=BCsterhus <tim@bastelstu.be=
> wrote:


> Thank you for your RFC. As you might have guessed from my comments on
> the PR, I quite like the proposal to round off attributes. Nevertheless
> any new syntax has quite a bit of an impact on tooling around PHP (see
> also (3) below), so I'm curious if you already have any use cases
> besides the `#[\Deprecated]` attribute that could be mentioned in the
> RFC text?
>

I don't have any other use cases at the moment - my primary motivation in
writing this feature was to allow deprecating constants. A few weeks ago I
gave a talk[1] where, among other things, I talked about how I was looking
forward to using the #[Deprecated] attribute, but that there was still room
for improvement since it could not be used on non-class constants. I then
figured: why not try to implement that support myself? And I eventually
figured it out.


> This is a non-issue, because the Attribute class is final.
>

Fixed, thanks


> This is not just extensions, but also userland code that did not
> anticipate any new attribute targets.
>

Given that
1. there isn't (as far as I know) a way to search for everything that has
an attribute
2. there isn't a current way to identify if a constant has an attribute

I didn't think there was anything to actually break for userland
attributes, but I've reworded the note to include userland attributes just
in case.

The =E2=80=9CBackward Incompatible Changes=E2=80=9D section should probably=
 shortly
> mention that this is new syntax and will need changes to IDEs, static
> analysis tools and formatters. The second paragraph in
>
> https://wiki.php.net/rfc/closures_in_const_expr#backward_incompatible_cha=
nges
> might be a good example.
>

Done

-Daniel

[1] https://youtu.be/hGYbXkfbkuU

--000000000000800c8c06285ea887
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>On Mon, Dec 2, 2024 at 2:48=E2=80=AFPM Tim D=C3=BCste=
rhus &lt;<a href=3D"mailto:tim@bastelstu.be">tim@bastelstu.be</a>&gt; wrote=
:</div><div class=3D"gmail_quote gmail_quote_container"><div>=C2=A0</div><b=
lockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-le=
ft:1px solid rgb(204,204,204);padding-left:1ex">
Thank you for your RFC. As you might have guessed from my comments on <br>
the PR, I quite like the proposal to round off attributes. Nevertheless <br=
>
any new syntax has quite a bit of an impact on tooling around PHP (see <br>
also (3) below), so I&#39;m curious if you already have any use cases <br>
besides the `#[\Deprecated]` attribute that could be mentioned in the <br>
RFC text?<br></blockquote><div><br></div><div>I don&#39;t have any other us=
e cases at the moment - my primary motivation in writing this feature was t=
o allow deprecating constants. A few weeks ago I gave a talk[1] where, amon=
g other things, I talked about how I was looking forward to using the #[Dep=
recated] attribute, but that there was still room for improvement since it =
could not be used on non-class constants. I then figured: why not try to im=
plement that support myself? And I eventually figured it out.</div><div>=C2=
=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8e=
x;border-left:1px solid rgb(204,204,204);padding-left:1ex">This is a non-is=
sue, because the Attribute class is final.<br></blockquote><div><br></div><=
div>Fixed, thanks=C2=A0</div><div>=C2=A0</div><blockquote class=3D"gmail_qu=
ote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,20=
4);padding-left:1ex">This is not just extensions, but also userland code th=
at did not <br>
anticipate any new attribute targets.<br></blockquote><div><br></div><div>G=
iven that</div><div>1. there isn&#39;t (as far as I know) a way to search f=
or everything that has an attribute</div><div>2. there isn&#39;t a current =
way to identify if a constant has an attribute</div><div><br></div><div>I d=
idn&#39;t think there was anything to actually break for userland attribute=
s, but I&#39;ve reworded the note to include userland attributes just in ca=
se.=C2=A0</div><div><br></div><blockquote class=3D"gmail_quote" style=3D"ma=
rgin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:=
1ex">
The =E2=80=9CBackward Incompatible Changes=E2=80=9D section should probably=
 shortly <br>
mention that this is new syntax and will need changes to IDEs, static <br>
analysis tools and formatters. The second paragraph in <br>
<a href=3D"https://wiki.php.net/rfc/closures_in_const_expr#backward_incompa=
tible_changes" rel=3D"noreferrer" target=3D"_blank">https://wiki.php.net/rf=
c/closures_in_const_expr#backward_incompatible_changes</a> <br>
might be a good example.<br></blockquote><div><br></div><div>Done</div><div=
><br></div><div>-Daniel</div><div><br></div><div>[1]=C2=A0<a href=3D"https:=
//youtu.be/hGYbXkfbkuU">https://youtu.be/hGYbXkfbkuU</a>=C2=A0</div></div><=
/div>

--000000000000800c8c06285ea887--