Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126091
Message-ID: <c21deef2-d743-4989-9e75-d2b6e5139fc7@gmx.de>
Date: Sun, 1 Dec 2024 23:25:37 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] Re: Inaccurate documentation on return values from
 native functions
Content-Language: de-DE
To: Hans Henrik Bergan <divinity76@gmail.com>,
 "Christoph M. Becker" <cmbecker69@gmx.de>
Cc: mickmackusa <mickmackusa@gmail.com>, "Gina P. Banyard"
 <internals@gpb.moe>, internals <internals@lists.php.net>
References: <CAKVXxD-9=cv5M7DHs0FLZdLMy9Xe5+AcXYtd6iSEmY=9u1g4AQ@mail.gmail.com>
 <CAKVXxD9QX1DODPboY9=36Cb23t36hLAF-Fa_NAeN3xoWDXycPg@mail.gmail.com>
 <Re44EoZ2A4IxjpFiUp0ZFd0ybwLNe923wDGbJo2TfZ4UPQcAQHxX2XE-RB-IWtZFkK_rrPT6JQvss265WxXuf3RvMqjzd8pH1G_7DhiM1NQ=@gpb.moe>
 <CAKVXxD_yd6sUgM=mjYEPJ1jK6O760nr8pGwyEfFG8tYttsBN6A@mail.gmail.com>
 <f702b9b5-c414-43ba-9c23-7a5a04b7b0e3@gmx.de>
 <CAJmy8YEeFafHKRRZUWhd_rS-cDZ6dPnT=2PmO_PZfA5tM=z8UQ@mail.gmail.com>
In-Reply-To: <CAJmy8YEeFafHKRRZUWhd_rS-cDZ6dPnT=2PmO_PZfA5tM=z8UQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:TkWJ4zPggGk=;VfbqGEGA1rpUdM0DEcLeoxDSV2N
 6yioKHIr//mM7sEeiYYm9K3xN2yy/JQ1BQl4/GpEFx7OcECTqX/WInA7iBNyFAS+C7PhYoMnb
 j88ZrRxwFz0b2o+j0wU0UZmtDZmHRD2Nma870ZO/YWeuKN9qu8jGRYiw+Zba8NlhKGhZ76Ncr
 VNB/qck9nqsuiZaNIQg0gpAihp+NvH4yJIEA0rKluNPVypvjDP+txIo7YKP5s6R6xSs6WvkuY
 MolIkxemXZ2rIu0CP/h1DaN4Ri0ky5HPKQ26gmNl+chxccgY+wMskhkI4VNVhXeLk6jKo5Yze
 YlTL93mLrOBOTGIieWIzj0GZ2Wyir+U4pCVOBV/c6Eg+CTqGL2owBAWlBu6YJv+xZriLpveLJ
 s4S316cFNHbbrUuh5M5efytGvi7hOD0jMtwEtLTGxQcozNuYxexsLGC6FJdfEVaIYG38yjrDp
 HZLep4s9voPh557zSkLCGOxN9Ar8csiiwBirjqaNwOtySaLJ6r0sSWZr8oAFH4DOpTXQngqua
 BxIYjRd7gwkJznOlg0By/eofeBC6FIojs8/6Y3yq+PE0Hm/ZmVqmfLEgdldPpCmljPL2hR8DF
 4NqQLvYB8t+NKACH58I8OLijOoTq+j4ib0IL+zVJOdhX7m/7idGelCOErg17sDn5DvfSA3H5g
 RA6c/2V0inM43+lyjjpe4GQKWFCm0r6/Rge3ihqcyRdj99lxO6DArJ9iEZXBqYHuNCHkfS6dv
 Mb8ZZF0JVdAvu4A0rMumfDwGkrZP5/R0QY4c9QsE1zoSI5U5P6AGwDz3PSc4a4UrN9ve1R9m0
 A+kYJNn8My86P3NMk8CrSMfYQ4vUAEE2he0lYOPfRZ6JU0aoAhV9scSwEu+2bGRQwpezYvRzi
 D3mrsRRR4hoNYBtYJiC9J8h5GHLyybTrErIs31KEW7QY4h4Hsv/8fSfalS+0Ky311c3LN4GIQ
 GhPSqK9wqsliqmugAXvUr7jb0ix+KjV8lZsfk9dz27Vm7JsRLGoS5hK9MM7Gmo9sNqZxC/JI0
 13xGceu/mMSy6IV2PErE3dtcX+wuhbcfWuKPO36PJWUU87MN6Gh4Peu9XZzkSLqA6FW2LhmIv
 k6vbzSpwRuYGMCU/poicEpLrkQVSm5
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 01.12.2024 at 21:32, Hans Henrik Bergan wrote:

> On Sun, Dec 1, 2024, 20:12 Christoph M. Becker <cmbecker69@gmx.de> wrote=
:
>
>> On 01.12.2024 at 19:26, mickmackusa wrote:
>>
>>> On Sun, Dec 1, 2024 at 10:01=E2=80=AFPM Gina P. Banyard <internals@gpb=
.moe>
>> wrote:
>>>
>>> Will it not be that these functions will be altered in the core to do
>> what
>>> the documentation says?
>>
>> If the docs are not correct, we cannot simply change the source to
>> conform for BC reasons.
>
> The same way we can't simply stop curl_close from writing to
> CURLOPT_COOKIEFILE for BC reasons?  (
> https://github.com/php/doc-en/issues/2239 )

My main point was (and is) that the docs are *unfortunately* not
authoritative; they still contain lots of out-dated and probably also
some wrong information.

The secondary point was (and is), that we *should* cater to BC.  That
is, unfortunately, not always possible; in this case it's about the
resource to object conversion, which when completely done, will get rid
of some nasty problems, which currently can barely worked-around.  And
when we change a resource type to a class, we know that some code does
is_resource() checks which are no longer valid, and that the close()
functions are no-ops.  There was some discussion about is_resource()
returning true for objects previously have been resources, but if I
remember correctly, that has been rejected.  And wrt the close()
functions there is barely anything we can do; well, we could put the
objects in some kind of unusable state, and actually close the
underlying "resource", but that seems even more hackish than having
is_resource() returning true for some objects.

So, in the end it's about weighing the pros and cons.  And there are
always different opinions regarding the decision.

Christoph