Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126074
Subject: Re: [PHP-DEV] [VOTE] Support Closures in constant expressions
To: internals@lists.php.net
References: <ac811e734b7a5c6acc88f89ee14d0574@bastelstu.be>
 <6a1940027c8c534e62bfb13d222947bf@bastelstu.be>
Cc: =?UTF-8?Q?Tim_D=c3=bcsterhus?= <tim@bastelstu.be>,
 volker@tideways-gmbh.com
Message-ID: <67479414.8070302@adviesenzo.nl>
Date: Wed, 27 Nov 2024 22:50:12 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.0
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <6a1940027c8c534e62bfb13d222947bf@bastelstu.be>
Content-Type: multipart/alternative;
 boundary="------------070803000907020501090904"
From: php-internals_nospam@adviesenzo.nl (Juliette Reinders Folmer)

This is a multi-part message in MIME format.
--------------070803000907020501090904
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit

On 27-11-2024 15:03, Tim Düsterhus wrote:
> Hi
>
> Am 2024-11-13 14:40, schrieb Tim Düsterhus:
>> we just started the vote the the "Support Closures in constant 
>> expressions" RFC. Please find the following resources for your 
>> reference:
>>
>> RFC: https://wiki.php.net/rfc/closures_in_const_expr
>> Implementation: https://github.com/php/php-src/pull/16458
>> Discussion: https://externals.io/message/125872
>>
>> The vote will end in two weeks, on November, 27th 2024 at 14:00 UTC.
>
> Voting just closed. The RFC was accepted unanimously with 19 (Yes) to 
> 0 (No) votes. Thank you for your participation.
>
> Best regards
> Tim Düsterhus
>

Congrats on the passed RFC! Sounds like a useful feature.

One thing I'm wondering about - and of which I saw no mention in the RFC 
nor in the preceding discussion - knowing that function names are 
case-insensitive, how is ambiguity handled when _calling_ a callback 
stored in a (class) constant ?

Consider the following code sample:

const STRTOUPPER = static function (string $text): string {
      return $text !== '' ? \strtoupper($text) : '';
};

STRTOUPPER('test'); // What will this do ? Call the PHP native function 
or the closure ?


And what about this one ?

class Foo {
     public const STRTOUPPER = static function (string $text): string {
          return $text !== '' ? \strtoupper($text) : '';
     };

     public function strtoupper(string $text) {
         return \ucfirst($text);
     }

     public function test() {
         self::STRTOUPPER('test'); // What will this do ?
     }
}

Foo::STRTOUPPER('test'); // What will this do ?


Curious for your reply.

Smile,
Juliette

--------------070803000907020501090904
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: 8bit

<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <div class="moz-cite-prefix">On 27-11-2024 15:03, Tim Düsterhus
      wrote:<br>
    </div>
    <blockquote cite="mid:6a1940027c8c534e62bfb13d222947bf@bastelstu.be"
      type="cite">Hi
      <br>
      <br>
      Am 2024-11-13 14:40, schrieb Tim Düsterhus:
      <br>
      <blockquote type="cite">we just started the vote the the "Support
        Closures in constant expressions" RFC. Please find the following
        resources for your reference:
        <br>
        <br>
        RFC: <a class="moz-txt-link-freetext" href="https://wiki.php.net/rfc/closures_in_const_expr">https://wiki.php.net/rfc/closures_in_const_expr</a>
        <br>
        Implementation: <a class="moz-txt-link-freetext" href="https://github.com/php/php-src/pull/16458">https://github.com/php/php-src/pull/16458</a>
        <br>
        Discussion: <a class="moz-txt-link-freetext" href="https://externals.io/message/125872">https://externals.io/message/125872</a>
        <br>
        <br>
        The vote will end in two weeks, on November, 27th 2024 at 14:00
        UTC.
        <br>
      </blockquote>
      <br>
      Voting just closed. The RFC was accepted unanimously with 19 (Yes)
      to 0 (No) votes. Thank you for your participation.
      <br>
      <br>
      Best regards
      <br>
      Tim Düsterhus
      <br>
      <br>
    </blockquote>
    <br>
    Congrats on the passed RFC! Sounds like a useful feature.<br>
    <br>
    One thing I'm wondering about - and of which I saw no mention in the
    RFC nor in the preceding discussion - knowing that function names
    are case-insensitive, how is ambiguity handled when _calling_ a
    callback stored in a (class) constant ?<br>
    <br>
    Consider the following code sample:<br>
    <br>
    <tt>const STRTOUPPER = static function (string $text): string {</tt><tt><br>
    </tt><tt>     return $text !== '' ? \strtoupper($text) : '';</tt><tt><br>
    </tt><tt>};</tt><tt><br>
    </tt><tt><br>
    </tt><tt>STRTOUPPER('test'); // What will this do ? Call the PHP
      native function or the closure ?</tt><br>
    <br>
    <br>
    And what about this one ?<br>
    <br>
    <tt>class Foo {</tt><tt><br>
    </tt><tt>    public const STRTOUPPER = static function (string
      $text): string {</tt><tt><br>
    </tt><tt>         return $text !== '' ? \strtoupper($text) : '';</tt><tt><br>
    </tt><tt>    };</tt><tt><br>
    </tt><tt><br>
    </tt><tt>    public function strtoupper(string $text) {</tt><tt><br>
    </tt><tt>        return \ucfirst($text);</tt><tt><br>
    </tt><tt>    }</tt><tt><br>
    </tt><tt>    </tt><tt><br>
    </tt><tt>    public function test() {</tt><tt><br>
    </tt><tt>        self::STRTOUPPER('test'); // What will this do ?</tt><tt><br>
    </tt><tt>    }</tt><tt><br>
    </tt><tt>}</tt><tt><br>
    </tt><tt><br>
    </tt><tt>Foo::STRTOUPPER('test'); // What will this do ?</tt><br>
    <br>
    <br>
    Curious for your reply.<br>
    <br>
    Smile,<br>
    Juliette<br>
  </body>
</html>

--------------070803000907020501090904--