Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126070
Precedence: bulk
MIME-Version: 1.0
Reply-To: erictnorris@gmail.com
Date: Wed, 27 Nov 2024 12:13:42 -0500
Message-ID: <CA+NMNO3wZMyySCm0D3iWnDcHyz=fgTBETRgoHBR78wNN2DYecw@mail.gmail.com>
Subject: [PHP-DEV] [RFC] [Discussion] Persistent curl share handle improvement
To: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
From: eric.t.norris@gmail.com (Eric Norris)

Hello again internals,

Similar to the Random Extension improvement RFC
(https://wiki.php.net/rfc/random_extension_improvement), I am creating
an RFC to address possible improvements to the recently accepted curl
share persistence RFC
(https://wiki.php.net/rfc/curl_share_persistence).

https://wiki.php.net/rfc/curl_share_persistence_improvement

After making changes based on feedback in the original implementation
pull request (https://github.com/php/php-src/pull/15603), I had some
free time to explore an alternative implementation that addressed
concerns brought up after voting.

https://github.com/php/php-src/pull/16937

The result, I think, is actually an improvement over the original.
Using a separate class provides a nice benefit of preventing
accidental mutation, not having to pick a persistent ID is one less
thing for the user to think about, etc.

The RFC has two voting choices, the first is to accept the new
signature over the old one. I have noted that this will require a 2/3
majority, but please correct me if this only requires a plurality. The
second is to disallow CURL_LOCK_DATA_COOKIE as a $share_option. I
believe this is the right choice to start with - we can always relax
the restriction later - but I am presenting it as a second vote in
case people feel strongly otherwise. I do not think that a
disagreement over CURL_LOCK_DATA_COOKIE should potentially block the
acceptance of a new function signature.

I plan on opening the vote in two weeks barring any major discussion.
I will likely leave the vote open for longer than two weeks,
considering the holiday period.

Thanks for your time and the feedback so far!