Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:126067 X-Original-To: internals@lists.php.net Delivered-To: internals@lists.php.net Received: from php-smtp4.php.net (php-smtp4.php.net [45.112.84.5]) by qa.php.net (Postfix) with ESMTPS id 32D991A00BD for ; Tue, 26 Nov 2024 20:39:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=php.net; s=mail; t=1732653394; bh=EHgL1VzVZ6k14WGc9A/FRvk2r+5UcTv+tqQjaMW0jX8=; h=Date:From:To:In-Reply-To:References:Subject:From; b=TqAUfH0CciqhPsCmr/vGll6OgRDQMwa6nNgFKMMBXIyRW3l3iU077X3rYZETWGCHX NabOyZM8dmhe2Q8Pq4/c7vn0I62WtIeriTNnKpBwrRTN9bPGhs4kGHrJnnpBq0Tmi9 9jnWzauha2/tbF2vFoeMuiwnCL7p/KmzPTf2Mex0i46qnNaja2P9WiaXV0fGDP2TWZ 6+r9lp8CUJJnEwOsbtVciBPJ77rSNOHCowaRML+2lof36f9AqiHv8pQ3fcF3mBE4GQ 6cEfOrj//6PReepiNmnIPc6yhJ+zNlmmzeq1IMFp8K/jbMLVKgqyTzEdKk/hSKvatZ +nQ3zVW2by0lQ== Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id A6885180382 for ; Tue, 26 Nov 2024 20:36:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=BAYES_50,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,DMARC_MISSING,RCVD_IN_DNSWL_LOW, SPF_HELO_PASS,SPF_NONE autolearn=no autolearn_force=no version=4.0.0 X-Spam-Virus: No X-Envelope-From: Received: from fhigh-b2-smtp.messagingengine.com (fhigh-b2-smtp.messagingengine.com [202.12.124.153]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Tue, 26 Nov 2024 20:36:31 +0000 (UTC) Received: from phl-compute-01.internal (phl-compute-01.phl.internal [10.202.2.41]) by mailfhigh.stl.internal (Postfix) with ESMTP id 5FD7225401B0 for ; Tue, 26 Nov 2024 15:39:41 -0500 (EST) Received: from phl-imap-06 ([10.202.2.83]) by phl-compute-01.internal (MEProxy); Tue, 26 Nov 2024 15:39:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= garfieldtech.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to; s=fm1; t=1732653581; x=1732739981; bh=j2BZrqaXPNMBcphhkwQpG 8wLX3sji1TNypehUhCWAwk=; b=hc2btvc1ZlJ+hYiIZIr31lKKewxxGAEgcBpuU tCb4xoJ1y7eJpTd2hAxmMUggw2qApuxYaFpYYPxGKvlHGFT8ODMLWIPc/CrudzUY H7rcZTxIE3WyIHGKkVfen134ebEvnu2TRE9d2cUDwjgiHLBnb1SlNYc4aMk52FD/ cVXOuTCbYaojsOIhdIVY+j0NgAdJnNh1wA/0aMjfKA4/euu5ijsuAd+6R7TUkhrC Q3wGA/evw2iFRvpX2DFFnDNpLDykidaMtdzuwRnfwIFb8TFItcrwiP1tAyJN+/hp NEI6c1AaBzfnTU04HfWuR3XdLemy9RJ6zGjoEUWKndK6j0psA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; t=1732653581; x=1732739981; bh=j 2BZrqaXPNMBcphhkwQpG8wLX3sji1TNypehUhCWAwk=; b=FyS0zflRpXNUpxFnG 0gph615F/AMhKSkuocQgWag+qHPemgbVk+iDi78YerXRLYOBa3a6ZPCxTaZbY7vj 39em5pdofiNv/M0bIeezNpoxeEOQYxFYxhsI9ZHe9PDa5AOoWtkPBH5a5i15bDy0 8sgbZgejZgHm8EkV683h9butaOjEVWfKsGzDtPY4F7Q5xXuaczZDxsuiIhRw/r3+ O+3xK7g1EEHaVjj+wjvPsIKhlz2ZLhEGT45tZtOFDmJWHAjpINYUiHvZjt3soxoh DJxl2PLgJuGnLjKoTzqT8+fncEofImAP/HX/9ywEjRrZghOC2DNTCjR8PBr9WEWn avlGQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrgeejgddufeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepofggfffhvffkjghfufgtgfesthejredtredttden ucfhrhhomhepfdfnrghrrhihucfirghrfhhivghlugdfuceolhgrrhhrhiesghgrrhhfih gvlhguthgvtghhrdgtohhmqeenucggtffrrghtthgvrhhnpeeuheejudelteelieehleel leekvddtgfettdeghffggeehvdejgeejfeffuefhvdenucffohhmrghinhepghhithhhuh gsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhho mheplhgrrhhrhiesghgrrhhfihgvlhguthgvtghhrdgtohhmpdhnsggprhgtphhtthhope dupdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehinhhtvghrnhgrlhhssehlihhs thhsrdhphhhprdhnvght X-ME-Proxy: Feedback-ID: i8414410d:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id E38C029C006F; Tue, 26 Nov 2024 15:39:40 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk list-help: list-post: List-Id: internals.lists.php.net x-ms-reactions: disallow MIME-Version: 1.0 Date: Tue, 26 Nov 2024 14:39:20 -0600 To: "php internals" Message-ID: <44ab8aa4-31c0-48b3-af5d-536a2b56fc40@app.fastmail.com> In-Reply-To: References: Subject: Re: [PHP-DEV] Adding attributes to compile-time constants Content-Type: text/plain Content-Transfer-Encoding: 7bit From: larry@garfieldtech.com ("Larry Garfield") On Tue, Nov 26, 2024, at 2:15 PM, Daniel Scherzer wrote: > Hi internals, > > For the last few weeks, I've been working on a patch[1] that I just > uploaded that adds support for attributes on compile-time non-class > constants (those declared with `const` rather than via `define()`). The > patch has a memory leak that I have been unable to resolve, but > otherwise the functionality is there and seems to work. Is anyone > willing to help with the memory issue? > > Separately, once the memory issue is fixed, would this need to go > through an RFC process? > > Thanks, > --Daniel Scherzer > > [1] https://github.com/php/php-src/pull/16952 I believe it would require an RFC, though I expect it would pass easily. I'm no help on the memory question though, I'm afraid. --Larry Garfield