Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126063
Precedence: bulk
MIME-Version: 1.0
References: <CAApwWmfN+u4p6WLcy4X=J4vOu5GYiwpqU8sGbg2PF3Bn8oOpHw@mail.gmail.com>
 <99f8520a-e8ba-471c-bcdb-6f305089c66b@gmx.de>
In-Reply-To: <99f8520a-e8ba-471c-bcdb-6f305089c66b@gmx.de>
Date: Tue, 26 Nov 2024 14:50:25 -0300
Message-ID: <CADK1yXJ7vqEGMqJ5J+LCBa7FYgoe4C-wy-FXiwM7yi+Cv28Geg@mail.gmail.com>
Subject: Re: [PHP-DEV] Return When
To: "Christoph M. Becker" <cmbecker69@gmx.de>
Cc: Volodymyr Volynets <volodymyr.volynets@gmail.com>, internals@lists.php.net
Content-Type: multipart/alternative; boundary="0000000000000846820627d47e7d"
From: deleugyn@gmail.com (Deleu)

--0000000000000846820627d47e7d
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 26, 2024 at 2:18=E2=80=AFPM Christoph M. Becker <cmbecker69@gmx=
.de>
wrote:

> What's wrong with
>
> if (!$result['success']) return $result;
>
> Christoph
>

I don't think I'm in favour of the proposal as I think it's high effort for
little gain, but to me this "alternative" requires you to mentally parse a
conditional statement and then pay attention to its consequence, which is
an afterthought and can be a return, but can also be anything else. The
proposed syntax seems superior because the first thing the developer is
presented with is the fact that this is a return statement / end of the
block, but under a specific condition, which is a secondary artifact.

Working with early returns and fail-early approaches, I have to agree that
the proposed syntax is superior than this alternative and not just because
of current coding standards, but more on the semantics of how to go about
the statement itself.

But as I stated, it doesn't feel like the effort is worth the benefit
because even if this could be implemented in a 1-line-of-code on php-src,
it still means syntax change which will affect tooling and cause a ton of
open-source overhead with token_get_all() changes, etc.

--=20
Marco Deleu

--0000000000000846820627d47e7d
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Tue, Nov 26, 2024 at 2:18=E2=80=AF=
PM Christoph M. Becker &lt;<a href=3D"mailto:cmbecker69@gmx.de">cmbecker69@=
gmx.de</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"m=
argin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left=
:1ex">What&#39;s wrong with<br>
<br>
if (!$result[&#39;success&#39;]) return $result;<br>
<br>Christoph<br>
</blockquote></div><div><br clear=3D"all"></div><div>I don&#39;t think I=
9;m in favour of the proposal as I think it&#39;s high effort for little ga=
in, but to me this &quot;alternative&quot; requires you to mentally parse a=
 conditional statement and then pay attention to its consequence, which is =
an afterthought and can be a return, but can also be anything else. The pro=
posed syntax seems superior because the first thing the developer is presen=
ted with is the fact that this is a return statement / end of the block, bu=
t under a specific condition, which is a secondary artifact.</div><div><br>=
</div><div>Working with early returns and fail-early approaches, I have to =
agree that the proposed syntax is superior than this alternative and not ju=
st because of current coding standards, but more on the semantics of how to=
 go about the statement itself.</div><div><br></div><div>But as I stated, i=
t doesn&#39;t feel like the effort is worth the benefit because even if thi=
s could be implemented in a 1-line-of-code on php-src, it still means synta=
x change which will affect tooling and cause a ton of open-source overhead =
with token_get_all() changes, etc.</div><div><br></div><span class=3D"gmail=
_signature_prefix">-- </span><br><div dir=3D"ltr" class=3D"gmail_signature"=
><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr"><div d=
ir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr">Marco Deleu</div></div></div><=
/div></div></div></div></div></div>

--0000000000000846820627d47e7d--