Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126062
Precedence: bulk
MIME-Version: 1.0
References: <CAApwWmfN+u4p6WLcy4X=J4vOu5GYiwpqU8sGbg2PF3Bn8oOpHw@mail.gmail.com>
 <99f8520a-e8ba-471c-bcdb-6f305089c66b@gmx.de>
In-Reply-To: <99f8520a-e8ba-471c-bcdb-6f305089c66b@gmx.de>
Date: Tue, 26 Nov 2024 18:44:41 +0100
Message-ID: <CANS-=pcw7wem4O1fh0aW8JXPwc9Sv3VkQme7C-Exx6+-VqKBjQ@mail.gmail.com>
Subject: Re: [PHP-DEV] Return When
To: "Christoph M. Becker" <cmbecker69@gmx.de>
Cc: Volodymyr Volynets <volodymyr.volynets@gmail.com>, internals@lists.php.net
Content-Type: multipart/alternative; boundary="000000000000ef59870627d4685a"
From: kjarli@gmail.com (Lynn)

--000000000000ef59870627d4685a
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 26, 2024 at 6:18=E2=80=AFPM Christoph M. Becker <cmbecker69@gmx=
.de>
wrote:

> On 26.11.2024 at 17:10, Volodymyr Volynets wrote:
>
> > I have an idea which will save a lot of code. I am proposing to add":
> >
> > return when [condition], [return value];
> >
> > This construct will remove a lot of ifs statements after method calls.
> For
> > example:
> >
> > $result =3D Class->method();
> > if (!$result['success']) {
> >     return $result;
> > }
> >
> > This becomes:
> > return when !$result['success'], $result;
> >
> > Any thoughts?
>
> What's wrong with
>
> if (!$result['success']) return $result;
>
> That's not longer than what you are proposing, and in my opinion, quite
> readable.
>
> The fact that contemporary coding standards require you to write the
> if-body on a separate line and to always use braces, is perhaps a
> problem of these coding standards.
>
> Christoph
>

I don't know if PHP needs this feature, though for me this notation is
harder to quickly scan and see what it does. It's really relatively easy to
find out what a line of code does when it starts with if, for, foreach,
while, do, switch, return etc, The example you've provided reads to me as
an if and then the part below is the body of the if. To find out it's a
return I first have to look to the right of what was written. I used to
write `if something then return end` in Lua, but the more I had to read
back my code I started disliking the readability of this formatting.

--000000000000ef59870627d4685a
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Tue, Nov 26, 2024 at 6:18=E2=80=AF=
PM Christoph M. Becker &lt;<a href=3D"mailto:cmbecker69@gmx.de">cmbecker69@=
gmx.de</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"m=
argin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left=
:1ex">On 26.11.2024 at 17:10, Volodymyr Volynets wrote:<br>
<br>
&gt; I have an idea which will save a lot of code. I am proposing to add&qu=
ot;:<br>
&gt;<br>
&gt; return when [condition], [return value];<br>
&gt;<br>
&gt; This construct will remove a lot of ifs statements after method calls.=
 For<br>
&gt; example:<br>
&gt;<br>
&gt; $result =3D Class-&gt;method();<br>
&gt; if (!$result[&#39;success&#39;]) {<br>
&gt;=C2=A0 =C2=A0 =C2=A0return $result;<br>
&gt; }<br>
&gt;<br>
&gt; This becomes:<br>
&gt; return when !$result[&#39;success&#39;], $result;<br>
&gt;<br>
&gt; Any thoughts?<br>
<br>
What&#39;s wrong with<br>
<br>
if (!$result[&#39;success&#39;]) return $result;<br>
<br>
That&#39;s not longer than what you are proposing, and in my opinion, quite=
<br>
readable.<br>
<br>
The fact that contemporary coding standards require you to write the<br>
if-body on a separate line and to always use braces, is perhaps a<br>
problem of these coding standards.<br>
<br>
Christoph<br></blockquote><div><br></div><div>I don&#39;t know if PHP needs=
 this feature, though for me this notation is harder to quickly scan and se=
e what it does. It&#39;s really relatively easy to find out what a line of =
code does when it starts with if, for, foreach, while, do, switch, return e=
tc, The example you&#39;ve provided reads to me as an if and then the part =
below is the body of the if. To find out it&#39;s a return I first have to =
look to the right of what was written. I used to write `if something then r=
eturn end` in Lua, but the more I had to read back my code I started dislik=
ing the readability of this formatting.</div><div><br></div><div><br></div>=
</div></div>

--000000000000ef59870627d4685a--