Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126058
Message-ID: <06e23630-16d0-4bbf-b49e-a04b43ff1f7b@gmx.de>
Date: Tue, 26 Nov 2024 12:59:27 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] Needs Feedback - Yield without value in reference
 generator function does not create notice
To: Claude Pache <claude.pache@gmail.com>,
 aggelos bellos <aggelosbellos7@gmail.com>
Cc: internals <internals@lists.php.net>
References: <CADPQA_QcJNMhd=KCM8Z0aVGm++on7_QE3D2DtTd+L36007qoqA@mail.gmail.com>
 <172D8C55-DCB2-4C5A-A224-C8B29B503DDF@gmail.com>
Content-Language: de-DE
In-Reply-To: <172D8C55-DCB2-4C5A-A224-C8B29B503DDF@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:TQNmoEvbR9g=;tTwNAbqKOHkDhmN//YnpOsQ6Tyh
 qJ9N7GDvaiyuyW8wLOe+IvPqRf83Vlh94SqSLAoLd74iJJ7oNYmEP7AF+OcnFJKvQSQw8uyms
 sof11DVX4TV4sIAInHiz/BUvFbVlr3wGu8kWQfLa9d4TQMz2R5tEbavdkicIBizDwl9pyB0S/
 CkIS1i4/B1DIhUd7k6RY6nMrNOlI6Q4K0bcrI+dH5xbDIQpTQpWuzR+3H95mNy8ZhXuj2RYNM
 AR+dXp6lbiohcg4Y55X9WVfKQ6zPhTwjLyClC6YVim+h2Y+HSf3Y3zvIWkxSAAXdmGo4kbBZC
 dlArxce96qN4J+igpREEolATT81C0U7hjXy0iS/Fz6b0PqzuAb+KOlYXPeazB2zrLCGYrl7MX
 oAoqZVmRJbuwh3GZeQvk9UI4s8NjOb5PLlW4xNPb4UjguYYhtFuh7ew6jIqs9wUiTcMIjB5/Z
 5Wo2ibT5jDiYzZy1Nnl7eLuax5O+kmaXIp5sN9YDCG4l3wcbV/AdqywQfiY0Sy3Lk71KkbX17
 kGvF9/zVdZs5kfGfHgN5NFO8uGDEJHiE1db1C+c7cA2sDraJhjMWdDXHqnx+m3c1IyYfcqfYO
 NdxKIpWz9fGyqkx2VgPm7uvn8Rsc32pxCObbhUjKA4WqyCcFNMGCV9Ro/VQSmQBe2p+Isjs5t
 +p3tttlzH+Nt+xyn6PpYiZ0xoNd50dH8DA5YAH8HnMJW6lZUewrp+Rn5j52Rt96eiWc0Emb6T
 muUF/jsOf0QwqEK8WDFcjm6Blb9uoNV21lkSBmoSsVqmo+Q3LM3KS7QbwQvn2Q2Y+tdLlM/hf
 WGh1oJjjKQHBMA5dXJY11paJUoCh3h9BkfE85UYsQu/qGdNBU0YpMpbOrKkEqOlsjFQUfezpP
 cUutrdUyCweydw25YGxZwFUvzWF36Lfds0VUEBm0wz/3Xf6DJ4/zYuSiT
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 26.11.2024 at 12:31, Claude Pache wrote:

>> Le 26 nov. 2024 =C3=A0 01:49, aggelos bellos <aggelosbellos7@gmail.com>=
 a =C3=A9crit :
>>
>> In this issue #16761 <https://github.com/php/php-src/issues/16761> it w=
as verified that in the above code it should throw a notice for both yield=
s:
>> ```
>> <?php
>> error_reporting(E_ALL);
>> function &y()
>> {
>>   yield null; // warning
>>   yield; // no warning, agreed to be a bug
>> }
>> foreach (y() as &$y);
>> ```
>> I have created this PR <https://github.com/php/php-src/pull/16882> whic=
h adds the "missing" notice but we aren't sure on
>> how to continue on this.
>> There are 2 main questions:
>> Should we continue with adding the missing notice and merge it also in =
master?
>> Should we deprecate / remove the usage of yield without value in refere=
nce generator functions?
>
> A notice would be consistent with what happens with: `function &f() { re=
turn; }; f();`. But don=E2=80=99t add new notices in patch releases, other=
wise you may break without warning a non-trivial amount of code that confl=
ates notices with fatal errors. The bug is not serious enough to warrant s=
uch a risk.
>
> Whether it should be deprecated, is a separate question. You should also=
 consider what to do with:  `function &g() { yield null; }`, `function &g(=
) { if (false) yield; }`, `function &f() { return; }`, etc.

In my opinion, whether it should be deprecated is not a separate
question, but the one we should answer first.  If we're not going to
deprecate/remove the auto-conversion to a reference, we may as well drop
the notice altogether, instead of adding a further notice.

Christoph