Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126052
X-Original-To: internals@lists.php.net
Delivered-To: internals@lists.php.net
Received: from php-smtp4.php.net (php-smtp4.php.net [45.112.84.5])
	by qa.php.net (Postfix) with ESMTPS id EFD891A00BD
	for <internals@lists.php.net>; Tue, 26 Nov 2024 09:50:08 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=php.net; s=mail;
	t=1732614418; bh=r77tsUdMwMnZzx/wnTPLahw+FTp5y9g1Msago8vo5BM=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
	b=VvlILnmrFUiJiMlWuHZ3Gn3Kt4utBXeOnS4BT1aDw9tbde54Owq2RR9zJqbZDFXwD
	 qX4hFeLf5SAIb5VlOIJGIrA5x4REcN/utA7Ao6ycywcZTEHISOwSzXzr6TXy+5X5nL
	 Zt7L1V/NExW+1hOLRlSOKMPMnx3dFSk++Mzam5+lbdEuGlWar4X6S03I6l2XJtso3d
	 fbtQK0e/A3yA1nFehQAfqBMudR8/UReNzAXzSp/3tNK93mpc/GFsjlVzvmtYmi0Aap
	 ln4bZ/hosLlmnJLeFLaB5lGOs+CvZu5hoVO1JLOMwbCm5UgOcLCss+aSME8Frga8ye
	 M2BzkkYgg6MyA==
Received: from php-smtp4.php.net (localhost [127.0.0.1])
	by php-smtp4.php.net (Postfix) with ESMTP id 1579E180062
	for <internals@lists.php.net>; Tue, 26 Nov 2024 09:46:57 +0000 (UTC)
X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on php-smtp4.php.net
X-Spam-Level: 
X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_50,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,DMARC_PASS,SPF_HELO_NONE,
	SPF_PASS autolearn=no autolearn_force=no version=4.0.0
X-Spam-Virus: No
X-Envelope-From: <tim@bastelstu.be>
Received: from chrono.xqk7.com (chrono.xqk7.com [176.9.45.72])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
	(No client certificate requested)
	by php-smtp4.php.net (Postfix) with ESMTPS
	for <internals@lists.php.net>; Tue, 26 Nov 2024 09:46:56 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bastelstu.be;
	s=mail20171119; t=1732614605;
	bh=olZ5owYML8Xb/a/iioaxVqi1McyCgZ9tMwaXlpFPoaA=;
	h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References:
	 Message-ID:Content-Type:from:to:cc:subject:message-id;
	b=LCeDFRyP1yXLlh/D8g7LuNmgANigc+L8CYh1TVEgZBB2wKrQ9Uwu8rDq7Rpo6Zva7
	 uhE556t7hp45ryljFZ9C0Bg3vGmsmBkIa/x5Io2Mu0MvVZaa5+iy0bqNh8QsW9BYkS
	 2pnHw3j0HOZxCCu+SK6YXSTNs+C7ejnqXkc3nuKhNa1jkujYjMAW8pSq26c+RHW8Ys
	 6Nrv/PooRZWImqTKRKXr15bymUp9NQRhdOY31shTSWZJTdAebWewyXZlhO3q4yyh6d
	 oWh+rsxJg5J185BEx6waHgeDFaufrL9pvNoncwgsgee2cv8ZEIAlZA7p9UXvlpH6nS
	 8clfF6/FmmrVQ==
Precedence: bulk
list-help: <mailto:internals+help@lists.php.net
list-unsubscribe: <mailto:internals+unsubscribe@lists.php.net>
list-post: <mailto:internals@lists.php.net>
List-Id: internals.lists.php.net
x-ms-reactions: disallow
MIME-Version: 1.0
Date: Tue, 26 Nov 2024 10:50:04 +0100
To: Eugene Sidelnyk <zsidelnik@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Subject: Re: [PHP-DEV] iterator_count signature for iterables
In-Reply-To: <CAM0CcxiBSTQi3u=_eew17OYzr=G88iAiY+-Xbr2zmvF8QxYPkg@mail.gmail.com>
References: <CAM0CcxiBSTQi3u=_eew17OYzr=G88iAiY+-Xbr2zmvF8QxYPkg@mail.gmail.com>
Message-ID: <8899a91a13c1e25a186f98661348e9c5@bastelstu.be>
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

Am 2024-11-26 10:40, schrieb Eugene Sidelnyk:
> I think it would make sense to change the signature of iterator_count 
> to
> accept iterable rather than array|Traversable so that static analysis 
> tools
> would pick it up better

That sounds like a bug in Psalm's understanding of union types. PHPStan 
handles it just fine: 
https://phpstan.org/r/8604ef1d-3500-4695-8c23-bb5d30ce4268

Best regards
Tim Düsterhus