Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:126028 X-Original-To: internals@lists.php.net Delivered-To: internals@lists.php.net Received: from php-smtp4.php.net (php-smtp4.php.net [45.112.84.5]) by qa.php.net (Postfix) with ESMTPS id 7B5221A00BD for ; Thu, 21 Nov 2024 17:18:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=php.net; s=mail; t=1732209655; bh=ZDE8hIILfNvyTwMFM+HFRnMMYcCgM4QU4kf7Wbjjjl0=; h=From:Subject:Date:References:To:In-Reply-To:From; b=idgCeyeQeUiAIIuhbDzr5BdIoQUl/gQqRAKngfB2cDnvlWZ+TinPUiaT2vuezTWGW qv7QBK98cZn4sL5WKl8iCloW9X6vdZ2Q6Gg9RccmZh0e2hZFzIc/RkP5N/aA2uFr7K p2AkVQCWMk7SgZ8UM52PxnzBcu/zmlC1Gvc+8ygT7CV8CSnYiwLcrTZWJRE9NwlGi+ t7KhfRn+kYM14lJU1nIz8cci15nvJ5obfJtvm2BI5b9Z1DUBk6+HV7SVDXNaO+cGBu HjzWa3KWeTOa38T+nmnzbB/gd1+HvPpLFEBURChnyMwAj7lrLKEdyuipAoM78QQI0U dARdcH0sxrgKg== Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id A34E71801D6 for ; Thu, 21 Nov 2024 17:20:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_50,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,DMARC_PASS,FREEMAIL_FROM, HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=4.0.0 X-Spam-Virus: No X-Envelope-From: Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Thu, 21 Nov 2024 17:20:54 +0000 (UTC) Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-539f2b95775so1715542e87.1 for ; Thu, 21 Nov 2024 09:18:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732209492; x=1732814292; darn=lists.php.net; h=message-id:in-reply-to:to:references:date:subject:mime-version:from :from:to:cc:subject:date:message-id:reply-to; bh=GyahdjNPz9L31tcinzolPNlL2AF3y8QH2gzboJP5KQc=; b=Xr20yuIuHGQLkYld9s3gb0VwP3lT6E9wVKGHosZkWijCLe4kUZhD5TCTL1ZZe8IJw6 3BZgCNz5ZC+DJh/N28EpNZ6nciDwIQiEDzYhCk062/LnoZESvArZPVdc9dUOddhAs4Uk htsYMHd5cbqmTIqdtiSvVdrxt8PxAUT1xtI39mNEq8VM44fzoWPOi2c7wa08X0OPouyC 5aqw7UFRGShZp93TYR8sDuk8XOKUyImpE3uOhD02DsPmj+Waffm+6vW0JHY67IsgiFKz 28eE7YIJRtExfRDoZe31g5gJAU0QMjXnSY6ipb3EpeBQM3PiHPRp6L+GAnqFw930+cUF 8kVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732209492; x=1732814292; h=message-id:in-reply-to:to:references:date:subject:mime-version:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GyahdjNPz9L31tcinzolPNlL2AF3y8QH2gzboJP5KQc=; b=ji6eD4Csfd76V8lWZsaLQ13KuNULjtsltnBbkQyN/Htv8S9d8DGrzoEcpPY8UGbnjP Cr76Q+2TYr348Id1nOHSKQySd9u0S/8zxqdUbmpkKWZHgH85sy6YuYPkvl/erBSHhsmQ NTttDfGaxQm5VcsRZ6JvwGjhIl99ODcjJaVpHZubHitGFYSXj22B/acApICfJPesyh6S XRoyFJqNwIuRGQWavmTSo6xzrbHDe9elmpdV0p8y6T2A0xBrJxEYCvP3g3AJ/pRkPR+4 IObBOCz7sklxYA5sOeXOcvbfN3Xh2tuqdzNmK86JzYzRt9hyGJrOz8mveqbo8lzylUk2 x3wQ== X-Gm-Message-State: AOJu0Yy1gSITcphzrRuK080eUxU9KFIaj1UojRVZEQUQDYdgB/9Nopqn aDRUTpyFXQd81PM8dDERe8L7oIpIyi08su+mDSY5uXwwaEEg+TwQ28j6Xohqbm0= X-Gm-Gg: ASbGncvVdmQJNMLV41zYqsHcbSpZYTg2Ob/A293I6nDPL+j3aevuPUThQSeRE3eZcvR ttIVksT1ErfPxrV3Udk2bHTD30A9gQ4JPAbHxJsBTBUFkNBdeJPQ1UuxdmB8reY0zeqiP3dqiSb LBUDN2gOoo8agTcmeaY0JCoWn62T+5iF6tSHJXWgWgajdvtjdbIH82A7o0pVfCuPwGdekyK4Dfb KdbB3miKhdkRUgVAW3taqWU+IJL3vXlemBeu/kG4nfGD1/7qNkvYJPJBp1Kl60k5HjggknMIdhv fVgbb6dJch1uTtU9cLnOT5E1ClB5ZlGtRQdFcn1f/1k2 X-Google-Smtp-Source: AGHT+IH7P2oNjzAWFBPKAVCpS+gyWPT2iy4oboT+7lsnYU0XLW30E+a0E/C60NcMTyRkcei5fnoOsQ== X-Received: by 2002:a05:6512:3ba3:b0:53d:a3a7:fe84 with SMTP id 2adb3069b0e04-53dc1322e5cmr6700767e87.8.1732209491749; Thu, 21 Nov 2024 09:18:11 -0800 (PST) Received: from smtpclient.apple (host-95-229-168-3.business.telecomitalia.it. [95.229.168.3]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa4f4181818sm101683566b.82.2024.11.21.09.18.11 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Nov 2024 09:18:11 -0800 (PST) Content-Type: multipart/alternative; boundary="Apple-Mail=_F827277E-9AA4-49D5-9D18-6B4BFDB79074" Precedence: bulk list-help: list-post: List-Id: internals.lists.php.net x-ms-reactions: disallow Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.200.121\)) Subject: Re: [PHP-DEV] opcache_compile_file() declares top-level functions Date: Thu, 21 Nov 2024 18:18:00 +0100 References: <09E90996-133F-47FD-878F-5D1F7A99A3ED@rwec.co.uk> <71304D27-1884-4D7B-B3B5-5E5DB753F216@rwec.co.uk> <4becf27f-2de1-4c74-9cf0-7dbff7bebf6c@app.fastmail.com> To: internals@lists.php.net In-Reply-To: <4becf27f-2de1-4c74-9cf0-7dbff7bebf6c@app.fastmail.com> Message-ID: <55285C12-EFEC-4982-A1D5-2526119D50AE@gmail.com> X-Mailer: Apple Mail (2.3826.200.121) From: daniil.gentili@gmail.com (Daniil Gentili) --Apple-Mail=_F827277E-9AA4-49D5-9D18-6B4BFDB79074 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii >> On 21 November 2024 10:48:46 GMT, Daniil Gentili = > wrote: >> >I speak for myself (and some others, as can be seen by pull requests = on some FOSS projects, which made pull requests to account for this = behaviour), as a user of preloading who has encountered this behaviour, = understood the reason for it and made the required changes to keep using = it. >>=20 >> This is still painfully vague. What projects? What "reason for it" = did you understand? When you say projects accounted for it, do you mean = they got some benefit from it, or that they worked around the problems = it caused them? I confused the linked issue with another issue related to preloading = that I encountered and worked around with include guards = (https://github.com/amphp/amp/issues/321). >> Note that we are not talking about preloading, as a general concept; = we are talking about the specific function opcache_compile_file. That = function's explicit purpose is to prime the opcache *without* behaving = the same way as including the file.=20 Yep, this makes sense, completely missed that when reading the initial = issue :) >=20 > Seems like function autoloading would alleviate this use case and make = this behavior easier to deprecate. >=20 +++ --Apple-Mail=_F827277E-9AA4-49D5-9D18-6B4BFDB79074 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii

On 21 = November 2024 10:48:46 GMT, Daniil Gentili <daniil.gentili@gmail.com> = wrote:
>I speak for myself (and some others, as can be = seen by pull requests on some FOSS projects, which made pull requests to = account for this behaviour), as a user of preloading who has encountered = this behaviour, understood the reason for it and made the required = changes to keep using it.

This is still = painfully vague. What projects? What "reason for it" did you understand? = When you say projects accounted for it, do you mean they got some = benefit from it, or that they worked around the problems it caused = them?

I confused the = linked issue with another issue related to preloading that I encountered = and worked around with include guards = (https://github.com/amphp/amp/issues/321).

Note that = we are not talking about preloading, as a general concept; we are = talking about the specific function opcache_compile_file. That = function's explicit purpose is to prime the opcache *without* behaving = the same way as including the = file. 

Yep, = this makes sense, completely missed that when reading the initial issue = :)

Seems like function autoloading would alleviate = this use case and make this behavior easier to deprecate.

+++

= --Apple-Mail=_F827277E-9AA4-49D5-9D18-6B4BFDB79074--