Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126020
Feedback-ID: id5114917:Fastmail
Date: Thu, 21 Nov 2024 10:27:04 +0000
To: internals@lists.php.net
Subject: Re: [PHP-DEV] opcache_compile_file() declares top-level functions
User-Agent: K-9 Mail for Android
In-Reply-To: <A4F812D1-2C6F-4621-A663-3B98A5F6C8E1@gmail.com>
References: <CAPyj-LD+X-XZoc5kZmW2qTCuu1-q5NtqEZyZhEs0rhvXa2AyJg@mail.gmail.com> <A4F812D1-2C6F-4621-A663-3B98A5F6C8E1@gmail.com>
Message-ID: <09E90996-133F-47FD-878F-5D1F7A99A3ED@rwec.co.uk>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: imsop.php@rwec.co.uk ("Rowan Tommins [IMSoP]")



On 21 November 2024 08:15:12 GMT, Daniil Gentili <daniil=2Egentili@gmail=
=2Ecom> wrote:
>Hi Ilija,
>I believe the removal of function caching is a bit of an overreaction: it=
 was always known, to those who used it, that preloading will cache functio=
ns, and requires an include guard to avoid function redeclaration errors, a=
nd in fact it is a very useful feature=2E
>
>There is nothing wrong with this behaviour, and it does what you expect i=
t to do=2E


This reads rather awkwardly, because you're claiming to speak for some unk=
nown users ("those who used it") and even for the reader of the message ("i=
t does what you expect it to do")=2E

More helpful would be to say how *you* use it, or where you have seen it u=
sed=2E Evidently it wasn't obvious to Ilija, and wasn't what they expected=
=2E Since it's not mentioned in the manual, it's not what I would have expe=
cted either=2E

Ilija also went to some length to describe real practical problems, so jus=
t saying there's "nothing wrong with this behaviour" also seems unhelpful=
=2E Perhaps you could expand on why you think the problems illustrated aren=
't significant in practice?

I would also be interested to know if you think the difference in behaviou=
r between classes and functions is explicitly useful, or just neutral to yo=
ur use case=2E=20

Regards,
Rowan Tommins
[IMSoP]