Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125962
Precedence: bulk
MIME-Version: 1.0
References: <CALWFqqCWV6bzJ0wQud5uH9U82JtNGOqjTOad-w7PVoZ4yn3YVQ@mail.gmail.com>
 <CADyq6s+rctWKjQG2g-sy_tWibdyesLKkuxCwNCyor1_KhBnpaQ@mail.gmail.com>
 <C62F7404-7472-4A01-BD43-C3C5A667DFC5@cschneid.com> <3dcc5393-6ce7-465c-abe6-ecb687b0f369@app.fastmail.com>
 <XaOoWJgnX8SscFzrrr_NpUlek3W0Q9Gqx3YcJcnydI6SWs6ppdXEAYj6FJoy5XsnEdOk18-8eX4vka_Qb4Be9KWTE51y7JVorQrk5YROu4U=@gpb.moe>
In-Reply-To: <XaOoWJgnX8SscFzrrr_NpUlek3W0Q9Gqx3YcJcnydI6SWs6ppdXEAYj6FJoy5XsnEdOk18-8eX4vka_Qb4Be9KWTE51y7JVorQrk5YROu4U=@gpb.moe>
Date: Fri, 15 Nov 2024 12:42:00 +0500
Message-ID: <CALWFqqBzMqFH_8NK+bv4ZhZxGzvBWFciMaeDHs-F8ObW37Prtg@mail.gmail.com>
Subject: Re: [PHP-DEV] [Discussion] Make objects unpackable by default
To: "Gina P. Banyard" <internals@gpb.moe>
Cc: Larry Garfield <larry@garfieldtech.com>, php internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
From: ilyaorlov124@gmail.com (MrMeshok)

I do know about get_object_vars, but for me foreach ($object as $prop)
{} looks nicer and a little bit faster (probably because there are no
function calls). Also it's more flexible because in future you can
implement an Iterator on class and alter iteration behavior.
But after reading through https://externals.io/message/103718 and
https://github.com/phpstan/phpstan/issues/1060 I can see how this
behavior can lead to bugs if the developer didn't intend the object to
be iterated. So a better approach would be to add getIterator to all
my DTOs
```php
public function getIterator(): Traversable
{
    return new ArrayIterator($this);
}
```
But ArrayIterator is a lot slower than simple object iteration (2.4
times slower with only public properties in the object and 1.5 times
slower with some private/protected properties). It would be nice if
there was some lightweight ObjectIterarotor designed to work with
object properties.
Also some note in docs to discourage usage of object iteration would
be good https://www.php.net/manual/en/language.oop5.iterations.php

=D0=BF=D1=82, 15 =D0=BD=D0=BE=D1=8F=D0=B1. 2024=E2=80=AF=D0=B3. =D0=B2 02:3=
0, Gina P. Banyard <internals@gpb.moe>:
>
> On Thursday, 14 November 2024 at 17:24, Larry Garfield <larry@garfieldtec=
h.com> wrote:
>
> > On Thu, Nov 14, 2024, at 7:37 AM, Christian Schneider wrote:
> >
> > > Am 14.11.2024 um 10:59 schrieb Marco Pivetta ocramius@gmail.com:
> > >
> > > > On Thu, 14 Nov 2024, 11:29 MrMeshok, ilyaorlov124@gmail.com wrote:
> > > >
> > > > > Hello, Internals!
> > > > >
> > > > > As you know if you try to unpack a regular object (`...$object`) =
you will get an error: Only arrays and Traversables can be unpacked.
> > > > > I don't really see a reason for this restriction, because foreach=
 on objects works perfectly fine, so I made a feature request on GitHub to =
change this behavior (https://github.com/php/php-src/issues/16038) and was =
advised to see opinions on this here.
> > > > > So, what do you think? And does this change require RFC?
> > > >
> > > > TBH, foreach on objects is already quite an abomination in itself =
=F0=9F=98=AC
> > >
> > > It is a bit less weird if you use value objects or json data in objec=
t form.
> > > I would be careful to judge how other people use the language, just s=
aying ;-)
> > >
> > > - Chris
> >
> >
> > Judging how one should use a language is a core component of language d=
esign.
> >
> > I'm with Marco on this one, and I'd be more than happy to get rid of fo=
reach($object), too. It's way, way more complicated a topic than you think.
> >
> > How does visibility play into it?
> > Should hooks be invoked or no?
> > Do references play into anything?
> >
> > Those are some of the questions we had to deal with for hooks and forea=
ch(). It's non-trivial. You'd need to address all the same edgy issues here=
, too.
> >
> > And that's assuming it's even a good idea, which I don't think it is. I=
f you are using a value object to define unordered arguments, just pass the=
 value object itself. If the receiving function can't handle that, then it =
is simple enough that you don't need a value object. If that's not the case=
, then your code design is bad and the language should not try to paper ove=
r that for you. Either simplify the function or adapt it to use a value obj=
ect directly. (With union types you can even do so in a BC fashion much of =
the time.)
>
> Agreed, this bites us constantly when needing to reason about what an "ob=
ject" is in PHP.
> Similar to array it mixes the concept of a struct, with that of a referen=
ce value, and "overloading" various behaviours (e.g. iterators and ArrayAcc=
ess).
> It is *extremely* simple to go from foreach ($object as $prop) {} to fore=
arch(get_object_vars($object) as $prop) {}
> and mandating this would resolve a lot of complexity, be that from the pe=
rspective of what is "possible" or not to do, and from an engine PoV.
>
>
> Best regards,
>
> Gina P. Banyard