Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125944
Feedback-ID: ifab94697:Fastmail
Precedence: bulk
MIME-Version: 1.0
Date: Tue, 12 Nov 2024 15:17:17 +0100
To: internals@lists.php.net
Message-ID: <c81f2ed4-ca8e-45b0-97d0-d029e2d33092@app.fastmail.com>
In-Reply-To: 
 <eA2u_Q4Tx5JeWD3_afszKmrPzzJq19VZ9tNjUktkftqvm6MtNpYOjmoRx4UfEqge4hfqmPn3CepKezqEPpdRBi8xhFWucCNjl6ffqgGPtbc=@gpb.moe>
References: 
 <eA2u_Q4Tx5JeWD3_afszKmrPzzJq19VZ9tNjUktkftqvm6MtNpYOjmoRx4UfEqge4hfqmPn3CepKezqEPpdRBi8xhFWucCNjl6ffqgGPtbc=@gpb.moe>
Subject: Re: [PHP-DEV] Make Closure covariant to callable
Content-Type: multipart/alternative;
 boundary=dafc9a6ddd7445579710b9858be5e639
From: rob@bottled.codes ("Rob Landers")

--dafc9a6ddd7445579710b9858be5e639
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable



On Tue, Nov 12, 2024, at 14:53, Gina P. Banyard wrote:
> Hello internals,
>=20
> Ond=C5=99ej Mirtes (author of PHPStan) remarked to me in August that C=
losure is not a subtype of callable.
> The implementation of this is quite straight forward and can be seen o=
n GitHub. [1]
> The question is if there are any concern or not and if this requires a=
n RFC or can just be merged as is.
>=20
> Best regards,
>=20
> Gina P. Banyard
>=20
> [1] https://github.com/php/php-src/pull/15492
>=20
Hey Gina,

I think saying =E2=80=9CClosure should be a subtype of callable=E2=80=9D=
 would require an RFC. To say that =E2=80=9CClosure should satisfy the c=
allable type check=E2=80=9D is just an oversight/bug. They are functiona=
lly the same IMO, just different perspectives.=20

=E2=80=94 Rob
--dafc9a6ddd7445579710b9858be5e639
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html><html><head><title></title><style type=3D"text/css">p.Mso=
Normal,p.MsoNoSpacing{margin:0}</style></head><body><div><br></div><div>=
<br></div><div>On Tue, Nov 12, 2024, at 14:53, Gina P. Banyard wrote:<br=
></div><blockquote type=3D"cite" id=3D"qt" style=3D""><div>Hello interna=
ls,<br></div><div><br></div><div>Ond=C5=99ej Mirtes (author of PHPStan) =
remarked to me in August that Closure is not a subtype of callable.<br><=
/div><div>The implementation of this is quite straight forward and can b=
e seen on GitHub. [1]<br></div><div>The question is if there are any con=
cern or not and if this requires an RFC or can just be merged as is.<br>=
</div><div><br></div><div>Best regards,<br></div><div><br></div><div>Gin=
a P. Banyard<br></div><div><br></div><div>[1]&nbsp;<a href=3D"https://gi=
thub.com/php/php-src/pull/15492" class=3D"">https://github.com/php/php-s=
rc/pull/15492</a><br></div><div><br></div></blockquote><div>Hey Gina,<br=
></div><div><br></div><div>I think saying =E2=80=9CClosure should be a s=
ubtype of callable=E2=80=9D would require an RFC. To say that =E2=80=9CC=
losure should satisfy the callable type check=E2=80=9D is just an oversi=
ght/bug. They are functionally the same IMO, just different perspectives=
.&nbsp;<br></div><div><br></div><div id=3D"sig121229152">=E2=80=94 Rob<b=
r></div></body></html>
--dafc9a6ddd7445579710b9858be5e639--