Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125890
Date: Fri, 01 Nov 2024 18:59:52 +0000
To: erictnorris@gmail.com
Cc: PHP internals <internals@lists.php.net>
Subject: Re: [PHP-DEV] [RFC] [Discussion] Persistent CurlShareHandle objects
Message-ID: <fHnLD3yEum71TAgA9Lf0jamB5V3zPTu0W0pRBWlXMl04DAeHZ7vIvNQTBWhEkZAQ_cg8JJkkalFBTJWv_CMaO7qBVtRZ9e9e0F2KMUfbsbw=@gpb.moe>
In-Reply-To: <CA+NMNO2Zizv7mrzmxxiJ8t8yYVLGb-=KgwyvWUffo3ohdaOW-A@mail.gmail.com>
References: <CA+NMNO2Zizv7mrzmxxiJ8t8yYVLGb-=KgwyvWUffo3ohdaOW-A@mail.gmail.com>
Feedback-ID: 96993444:user:proton
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: internals@gpb.moe ("Gina P. Banyard")

On Wednesday, 9 October 2024 at 21:16, Eric Norris <eric.t.norris@gmail.com=
> wrote:

> Hello all,
>=20
> After receiving some feedback about
> https://github.com/php/php-src/pull/15603, I'm formally proposing an
> RFC to add persistent curl share handles here:
> https://wiki.php.net/rfc/curl_share_persistence
>=20
> Thanks to those who have provided feedback so far! Of note: the
> implementation introduces a global variable to the curl extension via
> ZEND_BEGIN_MODULE_GLOBALS; this appears preferred over
> EG(persistent_list). Should the implementation stick with the module
> global, or should it go back to EG(persistent_list) until we've
> created a formal non-resource API (in another RFC)?
>=20
> I'd like to keep the future of persistent resources out of scope for
> the decision on whether to add curl share handle persistence to PHP,
> but it is worth deciding what form the persistence takes for now.

I have voted against the RFC as it lacks details and there seems to have be=
en no analysis on what sort of issues this can cause.
This has been pointed out by Tim already, and this should have been caught =
earlier, but I don't know if it just me, but it seems your email kinda went=
 into some void and got unnoticed.

Persistent handlers don't really fit PHP's model, and are practically untes=
table from a PHPT test perspective as far as I know (at least I have never =
seen any proper tests for the existing ones, but I am happy to be corrected=
).

As such I am very reluctant to adding more of these things to the language,=
 especially when this seems to just have been hacked together quickly, we s=
till have at least 7 months before feature freeze and I would prefer to act=
ually be done properly.
Especially that it is always easier to add new features than to deprecate a=
nd remove bad ones (which is kinda backwards but not relevant to this discu=
ssion).

Best regards,

Gina P. Banyard