Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125866
Message-ID: <4fc9dc81-3dfe-4ae0-b51f-b57aef95c539@gmail.com>
Date: Fri, 25 Oct 2024 21:32:39 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] Deprecate mhash constants?
To: internals@lists.php.net
References: <59b90e89-ec59-4161-b870-e104605e0810@gmx.de>
Content-Language: en-US
In-Reply-To: <59b90e89-ec59-4161-b870-e104605e0810@gmx.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
From: dossche.niels@gmail.com (Niels Dossche)

On 25/10/2024 19:24, Christoph M. Becker wrote:
> Hi all,
> 
> recently, it was discovered that although the mhash functions are
> deprecated as of PHP 8.1.0[1], the mhash constants are not yet
> deprecated.  I believe that was just an oversight, since the are well
> hidden in the sources, and we don't even have them in the stub files[2].
> 
> I made a PR to actually deprecate the constants[3].  Does anybody feel
> this needs the RFC process?
> 
> [1] <https://wiki.php.net/rfc/deprecations_php_8_1#mhash_function_family>
> [2] <https://github.com/php/doc-en/issues/3902>
> [3] <https://github.com/php/php-src/pull/16569>
> 
> Christoph

Since their intended use is deprecated, just deprecate them already too :)

Kind regards
Niels