Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125850
Feedback-ID: ifab94697:Fastmail
Precedence: bulk
MIME-Version: 1.0
Date: Thu, 24 Oct 2024 13:02:11 +0200
To: "Christoph M. Becker" <cmbecker69@gmx.de>, internals@lists.php.net
Message-ID: <1ecb6c26-427a-49d2-bb05-06f167199632@app.fastmail.com>
In-Reply-To: <5366cc2e-d839-41b1-9423-c53bd6ca2d99@gmx.de>
References: 
 <CA+NMNO2Zizv7mrzmxxiJ8t8yYVLGb-=KgwyvWUffo3ohdaOW-A@mail.gmail.com>
 <CA+NMNO2-P=9WNAGe4+rKiH=9X0CjhN0_t0RkKQxP4QVaZ4ECbg@mail.gmail.com>
 <CA+NMNO3w0yNYAwPKef5dzOgABvvOk82LZvsQWmNm1okhX5ChjA@mail.gmail.com>
 <5753e226-e512-4051-ab87-0184f21797d4@app.fastmail.com>
 <5366cc2e-d839-41b1-9423-c53bd6ca2d99@gmx.de>
Subject: Re: [PHP-DEV] Re: [RFC] [Discussion] Persistent CurlShareHandle objects
Content-Type: multipart/alternative;
 boundary=f6dcd116813245caa931cab1d08c482d
From: rob@bottled.codes ("Rob Landers")

--f6dcd116813245caa931cab1d08c482d
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable



On Thu, Oct 24, 2024, at 13:01, Christoph M. Becker wrote:
> On 23.10.2024 at 21:42, Rob Landers wrote:
>=20
> > On Wed, Oct 23, 2024, at 21:20, Eric Norris wrote:
> >
> >> Were you also suggesting that I shouldn't ask a question about the
> >> implementation regarding using EG(persistent_list) vs. a module
> >> global? I'm torn; I agree that it is an implementation detail but I
> >> was hoping to actually get wider input since it generated discussion
> >> in my pull request. Since no one responded here I felt like it'd be=
 a
> >> lightweight way to get feedback on what people felt, but the lack of
> >> response probably means that people don't feel strongly enough about
> >> it.
> >>
> >> That said, after reflecting I think I would agree that it is
> >> unnecessary to add this as a question, and I'll continue with the
> >> implementation as-is in the PR. If people would like to send feedba=
ck
> >> on using EG(persistent_list) instead, feel free to do so here or in
> >> the PR.
> >
> > For what it is worth, I think you should go for the EG(persistent_li=
st) method. Over on FrankenPHP, we are looking into some improvements to=
 TSRM (so that Go and PHP can share some of the same locks, among other =
things) and EG uses TSRM while I think a module global would not.
>=20
> For practical purposes, `EG(persistent_list)` is a module global (can
> bikeshed whether the engine is a module).  In particular, both use TLS
> for ZTS builds, and neither can access entries of other processes and
> threads, respectively.
>=20
> I still think we should not add new stuff to `EG(persistent_list)`;
> after all, resources are scheduled for removal, and likely
> `EG(persistent_list)` will finally be removed, too, and then we would
> need to convert to a curl module global anyway.
>=20
> Christoph
>=20
>=20

Sounds like a perfectly good reason to not use EG(persistent_list) to me=
.=20

=E2=80=94 Rob
--f6dcd116813245caa931cab1d08c482d
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html><html><head><title></title><style type=3D"text/css">p.Mso=
Normal,p.MsoNoSpacing{margin:0}</style></head><body><div><br></div><div>=
<br></div><div>On Thu, Oct 24, 2024, at 13:01, Christoph M. Becker wrote=
:<br></div><blockquote type=3D"cite" id=3D"qt" style=3D""><div>On 23.10.=
2024 at 21:42, Rob Landers wrote:<br></div><div><br></div><div>&gt; On W=
ed, Oct 23, 2024, at 21:20, Eric Norris wrote:<br></div><div>&gt;<br></d=
iv><div>&gt;&gt; Were you also suggesting that I shouldn't ask a questio=
n about the<br></div><div>&gt;&gt; implementation regarding using EG(per=
sistent_list) vs. a module<br></div><div>&gt;&gt; global? I'm torn; I ag=
ree that it is an implementation detail but I<br></div><div>&gt;&gt; was=
 hoping to actually get wider input since it generated discussion<br></d=
iv><div>&gt;&gt; in my pull request. Since no one responded here I felt =
like it'd be a<br></div><div>&gt;&gt; lightweight way to get feedback on=
 what people felt, but the lack of<br></div><div>&gt;&gt; response proba=
bly means that people don't feel strongly enough about<br></div><div>&gt=
;&gt; it.<br></div><div>&gt;&gt;<br></div><div>&gt;&gt; That said, after=
 reflecting I think I would agree that it is<br></div><div>&gt;&gt; unne=
cessary to add this as a question, and I'll continue with the<br></div><=
div>&gt;&gt; implementation as-is in the PR. If people would like to sen=
d feedback<br></div><div>&gt;&gt; on using EG(persistent_list) instead, =
feel free to do so here or in<br></div><div>&gt;&gt; the PR.<br></div><d=
iv>&gt;<br></div><div>&gt; For what it is worth, I think you should go f=
or the EG(persistent_list) method. Over on FrankenPHP, we are looking in=
to some improvements to TSRM (so that Go and PHP can share some of the s=
ame locks, among other things) and EG uses TSRM while I think a module g=
lobal would not.<br></div><div><br></div><div>For practical purposes, `E=
G(persistent_list)` is a module global (can<br></div><div>bikeshed wheth=
er the engine is a module).&nbsp; In particular, both use TLS<br></div><=
div>for ZTS builds, and neither can access entries of other processes an=
d<br></div><div>threads, respectively.<br></div><div><br></div><div>I st=
ill think we should not add new stuff to `EG(persistent_list)`;<br></div=
><div>after all, resources are scheduled for removal, and likely<br></di=
v><div>`EG(persistent_list)` will finally be removed, too, and then we w=
ould<br></div><div>need to convert to a curl module global anyway.<br></=
div><div><br></div><div>Christoph<br></div><div><br></div><div><br></div=
></blockquote><div><br></div><div>Sounds like a perfectly good reason to=
 not use EG(persistent_list) to me.&nbsp;</div><div><br></div><div id=3D=
"sig121229152">=E2=80=94 Rob<br></div></body></html>
--f6dcd116813245caa931cab1d08c482d--