Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125848
Message-ID: <5366cc2e-d839-41b1-9423-c53bd6ca2d99@gmx.de>
Date: Thu, 24 Oct 2024 13:01:04 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] Re: [RFC] [Discussion] Persistent CurlShareHandle
 objects
To: Rob Landers <rob@bottled.codes>, internals@lists.php.net
References: <CA+NMNO2Zizv7mrzmxxiJ8t8yYVLGb-=KgwyvWUffo3ohdaOW-A@mail.gmail.com>
 <CA+NMNO2-P=9WNAGe4+rKiH=9X0CjhN0_t0RkKQxP4QVaZ4ECbg@mail.gmail.com>
 <CA+NMNO3w0yNYAwPKef5dzOgABvvOk82LZvsQWmNm1okhX5ChjA@mail.gmail.com>
 <5753e226-e512-4051-ab87-0184f21797d4@app.fastmail.com>
Content-Language: de-DE
In-Reply-To: <5753e226-e512-4051-ab87-0184f21797d4@app.fastmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:zyxjltDKq0I=;bitKZP7NOzxze8wuPxVrYbLLCTL
 ANxp4ZYMQYmLwOjTRZxITwcP/OYimSUzyD6TlZfxhruSAkQ1F4G+ytwry6RVoC9s82zveVR+k
 jw5SyPXHKOuY8xpGr9YuN56N6a1b8r6mQ7TDu6SuU8PvtpnqjS4M+voIBl7Zf6AFkKibgeU6y
 r8KD8X7elBVqVD9yjAmDwqyB7nM/nmeJWh3V2dwMlOuGpyWpiLF4NLKpYARQTV8/s7AcDvn8b
 18Go1xQAaZzggPZOLG8uwE7uVq8BdIAagP6lycATpw/UHtZxLYl6HSzPWdnaPma3+NYDNfcbs
 nrw+pU3G8fJ4K8GvX72B8lqobd2cH0exvdxPwGEYQGwT+XKd+UDekU2JZxM3m2JHYjbhZNOT6
 mPJoeq/tn0Cz+xgunwSNND0bzOfHbeC9llx8Fn2iIVnSqz6b+Okx/Gx/TFeoBDEeC8k33PqRv
 ocXSQw97eAU5YsrGjKQQpsbM/PFU++KD1iTe98y2kFyC2ID93+8RMkv7rW3dJPkifhWGR1c03
 KFl8gW6jZukSkIn4xxkdT8GiXbgMdmWKBSKqReqqHaglZCIisiOyOr83E85XewV/9TYXJQx/9
 O2tnWrS3NTwxltNabY5249T9TW63eVDrKhD30CaEAgvayRfqQBVjZebm+xGVhSlvAFzC6rEbN
 B4y2oO1eMu14/kHBCPz7wHPCxWRVGlVg4Oqn5wwStOjn3OjysVPyrWFT4B6uRnlKJ9mpud+y7
 dVQoMi7Q57E7XnH19oJIaX+RlCPdTumUKQStLxXXYdpqwa0ScZo1n7mSDq7tgvjfN/XAQmYZX
 nPyc+5ylb7DTrMZ7ACC/mMW6XnzZ58aMBuh+pb0YAVsk4=
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 23.10.2024 at 21:42, Rob Landers wrote:

> On Wed, Oct 23, 2024, at 21:20, Eric Norris wrote:
>
>> Were you also suggesting that I shouldn't ask a question about the
>> implementation regarding using EG(persistent_list) vs. a module
>> global? I'm torn; I agree that it is an implementation detail but I
>> was hoping to actually get wider input since it generated discussion
>> in my pull request. Since no one responded here I felt like it'd be a
>> lightweight way to get feedback on what people felt, but the lack of
>> response probably means that people don't feel strongly enough about
>> it.
>>
>> That said, after reflecting I think I would agree that it is
>> unnecessary to add this as a question, and I'll continue with the
>> implementation as-is in the PR. If people would like to send feedback
>> on using EG(persistent_list) instead, feel free to do so here or in
>> the PR.
>
> For what it is worth, I think you should go for the EG(persistent_list) =
method. Over on FrankenPHP, we are looking into some improvements to TSRM =
(so that Go and PHP can share some of the same locks, among other things) =
and EG uses TSRM while I think a module global would not.

For practical purposes, `EG(persistent_list)` is a module global (can
bikeshed whether the engine is a module).  In particular, both use TLS
for ZTS builds, and neither can access entries of other processes and
threads, respectively.

I still think we should not add new stuff to `EG(persistent_list)`;
after all, resources are scheduled for removal, and likely
`EG(persistent_list)` will finally be removed, too, and then we would
need to convert to a curl module global anyway.

Christoph