Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125838
Feedback-ID: ifab94697:Fastmail
Precedence: bulk
MIME-Version: 1.0
Date: Wed, 23 Oct 2024 21:42:51 +0200
To: internals@lists.php.net
Message-ID: <5753e226-e512-4051-ab87-0184f21797d4@app.fastmail.com>
In-Reply-To: 
 <CA+NMNO3w0yNYAwPKef5dzOgABvvOk82LZvsQWmNm1okhX5ChjA@mail.gmail.com>
References: 
 <CA+NMNO2Zizv7mrzmxxiJ8t8yYVLGb-=KgwyvWUffo3ohdaOW-A@mail.gmail.com>
 <CA+NMNO2-P=9WNAGe4+rKiH=9X0CjhN0_t0RkKQxP4QVaZ4ECbg@mail.gmail.com>
 <CA+NMNO3w0yNYAwPKef5dzOgABvvOk82LZvsQWmNm1okhX5ChjA@mail.gmail.com>
Subject: Re: [PHP-DEV] Re: [RFC] [Discussion] Persistent CurlShareHandle objects
Content-Type: multipart/alternative;
 boundary=14bf054463a3436f974fe32e0d6fe130
From: rob@bottled.codes ("Rob Landers")

--14bf054463a3436f974fe32e0d6fe130
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable



On Wed, Oct 23, 2024, at 21:20, Eric Norris wrote:
> Apologies Rob, I don't seem to be receiving individual emails from the
> mailing list, so I'll have to respond to my own email here. I've
> changed my subscription to receive all emails so hopefully I'll be
> able to respond directly to future emails.
>=20
> > It might be a good idea to get a =E2=80=9Cstrong opinion=E2=80=9D on=
 the signature of curl_share_init.
>=20
> I think you are right. I've chatted with Rasmus and we both agree that
> changing the signature of curl_share_init is preferable to adding a
> new function - it's more in line with how we do persistence elsewhere.
> I'll update the RFC to remove the signature question.
>=20
> Were you also suggesting that I shouldn't ask a question about the
> implementation regarding using EG(persistent_list) vs. a module
> global? I'm torn; I agree that it is an implementation detail but I
> was hoping to actually get wider input since it generated discussion
> in my pull request. Since no one responded here I felt like it'd be a
> lightweight way to get feedback on what people felt, but the lack of
> response probably means that people don't feel strongly enough about
> it.
>=20
> That said, after reflecting I think I would agree that it is
> unnecessary to add this as a question, and I'll continue with the
> implementation as-is in the PR. If people would like to send feedback
> on using EG(persistent_list) instead, feel free to do so here or in
> the PR.
>=20
> > Also, it might be worth saying the =E2=80=9Cnext minor version of PH=
P=E2=80=9D just in case there isn=E2=80=99t an 8.5 and goes to 9.0.
>=20
> Makes sense to me, I'll make this change.
>=20

For what it is worth, I think you should go for the EG(persistent_list) =
method. Over on FrankenPHP, we are looking into some improvements to TSR=
M (so that Go and PHP can share some of the same locks, among other thin=
gs) and EG uses TSRM while I think a module global would not.

=E2=80=94 Rob
--14bf054463a3436f974fe32e0d6fe130
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html><html><head><title></title><style type=3D"text/css">p.Mso=
Normal,p.MsoNoSpacing{margin:0}</style></head><body><div><br></div><div>=
<br></div><div>On Wed, Oct 23, 2024, at 21:20, Eric Norris wrote:<br></d=
iv><blockquote type=3D"cite" id=3D"qt" style=3D""><div>Apologies Rob, I =
don't seem to be receiving individual emails from the<br></div><div>mail=
ing list, so I'll have to respond to my own email here. I've<br></div><d=
iv>changed my subscription to receive all emails so hopefully I'll be<br=
></div><div>able to respond directly to future emails.<br></div><div><br=
></div><div>&gt; It might be a good idea to get a =E2=80=9Cstrong opinio=
n=E2=80=9D on the signature of curl_share_init.<br></div><div><br></div>=
<div>I think you are right. I've chatted with Rasmus and we both agree t=
hat<br></div><div>changing the signature of curl_share_init is preferabl=
e to adding a<br></div><div>new function - it's more in line with how we=
 do persistence elsewhere.<br></div><div>I'll update the RFC to remove t=
he signature question.<br></div><div><br></div><div>Were you also sugges=
ting that I shouldn't ask a question about the<br></div><div>implementat=
ion regarding using EG(persistent_list) vs. a module<br></div><div>globa=
l? I'm torn; I agree that it is an implementation detail but I<br></div>=
<div>was hoping to actually get wider input since it generated discussio=
n<br></div><div>in my pull request. Since no one responded here I felt l=
ike it'd be a<br></div><div>lightweight way to get feedback on what peop=
le felt, but the lack of<br></div><div>response probably means that peop=
le don't feel strongly enough about<br></div><div>it.<br></div><div><br>=
</div><div>That said, after reflecting I think I would agree that it is<=
br></div><div>unnecessary to add this as a question, and I'll continue w=
ith the<br></div><div>implementation as-is in the PR. If people would li=
ke to send feedback<br></div><div>on using EG(persistent_list) instead, =
feel free to do so here or in<br></div><div>the PR.<br></div><div><br></=
div><div>&gt; Also, it might be worth saying the =E2=80=9Cnext minor ver=
sion of PHP=E2=80=9D just in case there isn=E2=80=99t an 8.5 and goes to=
 9.0.<br></div><div><br></div><div>Makes sense to me, I'll make this cha=
nge.<br></div><div><br></div></blockquote><div><br></div><div>For what i=
t is worth, I think you should go for the EG(persistent_list) method. Ov=
er on FrankenPHP, we are looking into some improvements to TSRM (so that=
 Go and PHP can share some of the same locks, among other things) and EG=
 uses TSRM while I think a module global would not.<br></div><div><br></=
div><div id=3D"sig121229152">=E2=80=94 Rob<br></div></body></html>
--14bf054463a3436f974fe32e0d6fe130--