Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125837
Precedence: bulk
MIME-Version: 1.0
References: <CA+NMNO2Zizv7mrzmxxiJ8t8yYVLGb-=KgwyvWUffo3ohdaOW-A@mail.gmail.com>
 <CA+NMNO2-P=9WNAGe4+rKiH=9X0CjhN0_t0RkKQxP4QVaZ4ECbg@mail.gmail.com>
In-Reply-To: <CA+NMNO2-P=9WNAGe4+rKiH=9X0CjhN0_t0RkKQxP4QVaZ4ECbg@mail.gmail.com>
Reply-To: erictnorris@gmail.com
Date: Wed, 23 Oct 2024 15:20:51 -0400
Message-ID: <CA+NMNO3w0yNYAwPKef5dzOgABvvOk82LZvsQWmNm1okhX5ChjA@mail.gmail.com>
Subject: [PHP-DEV] Re: [RFC] [Discussion] Persistent CurlShareHandle objects
To: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
From: eric.t.norris@gmail.com (Eric Norris)

Apologies Rob, I don't seem to be receiving individual emails from the
mailing list, so I'll have to respond to my own email here. I've
changed my subscription to receive all emails so hopefully I'll be
able to respond directly to future emails.

> It might be a good idea to get a =E2=80=9Cstrong opinion=E2=80=9D on the =
signature of curl_share_init.

I think you are right. I've chatted with Rasmus and we both agree that
changing the signature of curl_share_init is preferable to adding a
new function - it's more in line with how we do persistence elsewhere.
I'll update the RFC to remove the signature question.

Were you also suggesting that I shouldn't ask a question about the
implementation regarding using EG(persistent_list) vs. a module
global? I'm torn; I agree that it is an implementation detail but I
was hoping to actually get wider input since it generated discussion
in my pull request. Since no one responded here I felt like it'd be a
lightweight way to get feedback on what people felt, but the lack of
response probably means that people don't feel strongly enough about
it.

That said, after reflecting I think I would agree that it is
unnecessary to add this as a question, and I'll continue with the
implementation as-is in the PR. If people would like to send feedback
on using EG(persistent_list) instead, feel free to do so here or in
the PR.

> Also, it might be worth saying the =E2=80=9Cnext minor version of PHP=E2=
=80=9D just in case there isn=E2=80=99t an 8.5 and goes to 9.0.

Makes sense to me, I'll make this change.