Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125830
Message-ID: <ead1c155-af06-49d3-aef7-231812634ad6@varteg.nz>
Date: Tue, 22 Oct 2024 12:43:37 +1300
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] [RFC] Change behaviour of array sort functions to
 return a copy of the sorted array
To: mickmackusa <mickmackusa@gmail.com>
Cc: internals <internals@lists.php.net>
References: <ZydAaayECTRNG8Ackhb0tDgYjmdFKnkW4p0ISWlLFP5My4CsJBR1KKTylrD14Ags2GUyBLoJPf68N6Z6LoVzjG-tru8YAbmi74W5xzSkJ8I=@gpb.moe>
 <19897c07-ebc8-49e8-9825-30a3fcc00a3e@varteg.nz>
 <CAKVXxD-3o=dn1RbUbN7BixJCnkV5q7=fChaJ7Bi4AoXJWbn5_Q@mail.gmail.com>
Content-Language: en-GB
In-Reply-To: <CAKVXxD-3o=dn1RbUbN7BixJCnkV5q7=fChaJ7Bi4AoXJWbn5_Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
From: weedpacket@varteg.nz (Morgan)

On 2024-10-22 00:17, mickmackusa wrote:
> On Mon, 21 Oct 2024, 18:09 Morgan, <weedpacket@varteg.nz 
> <mailto:weedpacket@varteg.nz>> wrote:
> 
>     You can’t use:
>              $sorted_datasets = array_map(sort(...), $datasets);
>     You want
>              $sorted_datasets = $datasets;
>              array_walk($sorted_datasets, sort(...));
> 
> 
> A warning: no one should ever use array_walk($sorted_datasets, 
> sort(...)); as general-use script.
> 
> When sorting a 2d array in this fashion (only non-fatally executed with 
> numeric first level keys https://3v4l.org/HaU42 <https://3v4l.org/ 
> HaU42>), the first level keys will be used as the sorting flag while 
> sorting each row.  This means that different rows may have different 
> sorting flags applied -- effectively corrupting the result. 
> https://3v4l.org/FeIpj <https://3v4l.org/FeIpj> -- notice how rows with 
> keys 2, 5, and 10 are sorted as strings.
> 
> Mick
> 
Right, but the issue was that array_walk() is the only 
callback-parameterised array_* function which is even _compatible_ with 
sort(). As you point out, even then it's problematic.