Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125826
Precedence: bulk
MIME-Version: 1.0
References: <ZydAaayECTRNG8Ackhb0tDgYjmdFKnkW4p0ISWlLFP5My4CsJBR1KKTylrD14Ags2GUyBLoJPf68N6Z6LoVzjG-tru8YAbmi74W5xzSkJ8I=@gpb.moe>
 <y61nFg8JnfpzCsL25kyI35RiCtTm7MHW_Zn3TY81lKHkmdagnyTMk0f73FQV-xuu1aRl4401vOtG5ZbK5j5Xx4_UCkF1TJnoGNm2Aw4GlSw=@gpb.moe>
 <CAPyj-LDbEYXYDROO5_M1WZWUw1pCWhhVREEvqgQuHGXTBLpaHw@mail.gmail.com> <HRchGMNN6j5OCtAss04zESt4UVSCxl5qka3EFDnARx-_0cqXsF7W7IOOI6OXZiuG0e-FLpALPeHGTV0qWw9WbHApmrGdN5y9OBmgpzwTCmw=@gpb.moe>
In-Reply-To: <HRchGMNN6j5OCtAss04zESt4UVSCxl5qka3EFDnARx-_0cqXsF7W7IOOI6OXZiuG0e-FLpALPeHGTV0qWw9WbHApmrGdN5y9OBmgpzwTCmw=@gpb.moe>
Date: Mon, 21 Oct 2024 19:28:56 +0300
Message-ID: <CAPyeZ4NnoJU0FKFGPOg+KFYmQgabCCuG8Owh6V-5DTCDEru8QA@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] Change behaviour of array sort functions to
 return a copy of the sorted array
To: "Gina P. Banyard" <internals@gpb.moe>
Cc: Ilija Tovilo <tovilo.ilija@gmail.com>, PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
From: udaltsov.valentin@gmail.com (Valentin Udaltsov)

On Mon, 21 October 2024=E2=80=AF=D0=B3. at 18:13, Gina P. Banyard <internal=
s@gpb.moe> wrote:
>
> On Monday, 21 October 2024 at 14:29, Ilija Tovilo <tovilo.ilija@gmail.com=
> wrote:
>
> > Hi Gina
> >
> > On Mon, Oct 21, 2024 at 3:21=E2=80=AFPM Gina P. Banyard internals@gpb.m=
oe wrote:
> >
> > > On Sunday, 20 October 2024 at 18:42, Gina P. Banyard internals@gpb.mo=
e wrote:
> > >
> > > > https://wiki.php.net/rfc/array-sort-return-array
> > >
> > > For an example, I'm going to pull out my solution to day 1 of the 202=
2 advents of code:
> > >
> > > https://github.com/Girgias/advent-of-code/blob/19283e1f5ef503c8a4478e=
58aaa57ff2fb7164c7/2022/01/puzzle.php#L25
> > >
> > > However, if the sort functions would return a useful value instead of=
 `true` I could chain it together completely as follows:
> > >
> > > $top3 =3D array_slice(
> > > rsort(
> > > array_map(
> > > 'array_sum',
> > > array_map(
> > > fn($v) =3D> explode("\n", $v),
> > > explode(
> > > "\n\n",
> > > $input
> > > )
> > > )
> > > )
> > > ),
> > > 0,
> > > length: 3
> > > );
> >
> >
> > Note that your example would still warn after this RFC, which is
> > likely enough to deter people from writing code like this.
> >
> > https://3v4l.org/mRuoK
>
> There is a very simple fix, which is to add the /** @prefer-ref $array */=
 doc comment to the stub of the relevant functions.
> Something that array_multisort() already does.
> But thanks for reminding me how crap PHP references are :D
>
> I'll amend the RFC soon to include this change as part of the proposal.
>
> Best regards,
>
> Gina P. Banyard

Hi, Gina!

What if instead of this proposal we reimplement all of the array
functions in a different namespace and fix a lot of other problems and
inconsistencies?

Array\map(iterable $iterable, callable $mapper): array
Array\sort(iterable $iterable, int $flags =3D SORT_REGULAR): array
...

--=20
Valentin