Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125825
Date: Mon, 21 Oct 2024 15:09:45 +0000
To: Ilija Tovilo <tovilo.ilija@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Subject: Re: [PHP-DEV] [RFC] Change behaviour of array sort functions to return a copy of the sorted array
Message-ID: <HRchGMNN6j5OCtAss04zESt4UVSCxl5qka3EFDnARx-_0cqXsF7W7IOOI6OXZiuG0e-FLpALPeHGTV0qWw9WbHApmrGdN5y9OBmgpzwTCmw=@gpb.moe>
In-Reply-To: <CAPyj-LDbEYXYDROO5_M1WZWUw1pCWhhVREEvqgQuHGXTBLpaHw@mail.gmail.com>
References: <ZydAaayECTRNG8Ackhb0tDgYjmdFKnkW4p0ISWlLFP5My4CsJBR1KKTylrD14Ags2GUyBLoJPf68N6Z6LoVzjG-tru8YAbmi74W5xzSkJ8I=@gpb.moe> <y61nFg8JnfpzCsL25kyI35RiCtTm7MHW_Zn3TY81lKHkmdagnyTMk0f73FQV-xuu1aRl4401vOtG5ZbK5j5Xx4_UCkF1TJnoGNm2Aw4GlSw=@gpb.moe> <CAPyj-LDbEYXYDROO5_M1WZWUw1pCWhhVREEvqgQuHGXTBLpaHw@mail.gmail.com>
Feedback-ID: 96993444:user:proton
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: internals@gpb.moe ("Gina P. Banyard")

On Monday, 21 October 2024 at 14:29, Ilija Tovilo <tovilo.ilija@gmail.com> =
wrote:

> Hi Gina
>=20
> On Mon, Oct 21, 2024 at 3:21=E2=80=AFPM Gina P. Banyard internals@gpb.moe=
 wrote:
>=20
> > On Sunday, 20 October 2024 at 18:42, Gina P. Banyard internals@gpb.moe =
wrote:
> >=20
> > > https://wiki.php.net/rfc/array-sort-return-array
> >=20
> > For an example, I'm going to pull out my solution to day 1 of the 2022 =
advents of code:
> >=20
> > https://github.com/Girgias/advent-of-code/blob/19283e1f5ef503c8a4478e58=
aaa57ff2fb7164c7/2022/01/puzzle.php#L25
> >=20
> > However, if the sort functions would return a useful value instead of `=
true` I could chain it together completely as follows:
> >=20
> > $top3 =3D array_slice(
> > rsort(
> > array_map(
> > 'array_sum',
> > array_map(
> > fn($v) =3D> explode("\n", $v),
> > explode(
> > "\n\n",
> > $input
> > )
> > )
> > )
> > ),
> > 0,
> > length: 3
> > );
>=20
>=20
> Note that your example would still warn after this RFC, which is
> likely enough to deter people from writing code like this.
>=20
> https://3v4l.org/mRuoK

There is a very simple fix, which is to add the /** @prefer-ref $array */ d=
oc comment to the stub of the relevant functions.
Something that array_multisort() already does.
But thanks for reminding me how crap PHP references are :D

I'll amend the RFC soon to include this change as part of the proposal.

Best regards,

Gina P. Banyard