Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125822
Precedence: bulk
MIME-Version: 1.0
References: <ZydAaayECTRNG8Ackhb0tDgYjmdFKnkW4p0ISWlLFP5My4CsJBR1KKTylrD14Ags2GUyBLoJPf68N6Z6LoVzjG-tru8YAbmi74W5xzSkJ8I=@gpb.moe>
 <19897c07-ebc8-49e8-9825-30a3fcc00a3e@varteg.nz>
In-Reply-To: <19897c07-ebc8-49e8-9825-30a3fcc00a3e@varteg.nz>
Date: Mon, 21 Oct 2024 21:17:07 +1000
Message-ID: <CAKVXxD-3o=dn1RbUbN7BixJCnkV5q7=fChaJ7Bi4AoXJWbn5_Q@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] Change behaviour of array sort functions to
 return a copy of the sorted array
To: Morgan <weedpacket@varteg.nz>
Cc: internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000bd34860624facb78"
From: mickmackusa@gmail.com (mickmackusa)

--000000000000bd34860624facb78
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 21 Oct 2024, 18:09 Morgan, <weedpacket@varteg.nz> wrote:

> You can=E2=80=99t use:
>         $sorted_datasets =3D array_map(sort(...), $datasets);
> You want
>         $sorted_datasets =3D $datasets;
>         array_walk($sorted_datasets, sort(...));
>

A warning: no one should ever use array_walk($sorted_datasets, sort(...));
as general-use script.

When sorting a 2d array in this fashion (only non-fatally executed with
numeric first level keys https://3v4l.org/HaU42), the first level keys will
be used as the sorting flag while sorting each row.  This means that
different rows may have different sorting flags applied -- effectively
corrupting the result.  https://3v4l.org/FeIpj -- notice how rows with keys
2, 5, and 10 are sorted as strings.

Mick

>

--000000000000bd34860624facb78
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto"><div><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D=
"gmail_attr">On Mon, 21 Oct 2024, 18:09 Morgan, &lt;<a href=3D"mailto:weedp=
acket@varteg.nz" target=3D"_blank" rel=3D"noreferrer">weedpacket@varteg.nz<=
/a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0=
 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">You can=E2=80=99t us=
e:<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 $sorted_datasets =3D array_map(sort(...), $data=
sets);<br>
You want<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 $sorted_datasets =3D $datasets;<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 array_walk($sorted_datasets, sort(...));<br></b=
lockquote></div></div><div dir=3D"auto"><br></div><div dir=3D"auto">A warni=
ng: no one should ever use array_walk($sorted_datasets, sort(...)); as gene=
ral-use script.</div><div dir=3D"auto"><br></div><div dir=3D"auto">When sor=
ting a 2d array in this fashion (only non-fatally executed with numeric fir=
st level keys <a href=3D"https://3v4l.org/HaU42">https://3v4l.org/HaU42</a>=
), the first level keys will be used as the sorting flag while sorting each=
 row.=C2=A0 This means that different rows may have different sorting flags=
 applied -- effectively corrupting the result.=C2=A0 <a href=3D"https://3v4=
l.org/FeIpj">https://3v4l.org/FeIpj</a> -- notice how rows with keys 2, 5, =
and 10 are sorted as strings.</div><div dir=3D"auto"><br></div><div dir=3D"=
auto">Mick</div><div dir=3D"auto"><div class=3D"gmail_quote"><blockquote cl=
ass=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;p=
adding-left:1ex">
</blockquote></div></div></div>

--000000000000bd34860624facb78--