Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125797
Precedence: bulk
MIME-Version: 1.0
References: <CAEPPVa3ZCOLm7tgToDVdZ01U4M91yAPZjgG8CV241=cmTp5m0g@mail.gmail.com>
 <754710ced33bdb2f9840d96ba0c58424@bastelstu.be> <CAEPPVa0hs4W+RBwhWoZ4AX8DOCECGAh9U3a_y1b1JBCd5tgiXQ@mail.gmail.com>
In-Reply-To: <CAEPPVa0hs4W+RBwhWoZ4AX8DOCECGAh9U3a_y1b1JBCd5tgiXQ@mail.gmail.com>
Date: Mon, 14 Oct 2024 16:37:53 +0900
Message-ID: <CAEPPVa200YSgzqnJsQxa8pQ8Wwp_SvKRzNBpy3gU_2XYpS68Yw@mail.gmail.com>
Subject: Re: [PHP-DEV][DISCUSSION] Multibyte for levenshtein function
To: php internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
From: youkidearitai@gmail.com (youkidearitai)

2024=E5=B9=B410=E6=9C=886=E6=97=A5(=E6=97=A5) 14:45 youkidearitai <youkidea=
ritai@gmail.com>:
>
> 2024=E5=B9=B410=E6=9C=885=E6=97=A5(=E5=9C=9F) 1:20 Tim D=C3=BCsterhus <ti=
m@bastelstu.be>:
> >
> > Hi
> >
> > Am 2024-09-25 09:21, schrieb youkidearitai:
> > > I tried implement mb_levenshtein function and create an RFC.
> > > https://wiki.php.net/rfc/mb_levenshtein
> > > https://github.com/php/php-src/pull/16043
> > >
> > > I would like discussion, feel free to comment.
> >
> > Thank you for your RFC. I share the concern raised by cmb in the PR
> > discussion:
> > https://github.com/php/php-src/pull/16043#issuecomment-2374574538
> >
> > Generally working with codepoints is going to be confusing for a user,
> > but sometimes it is necessary when dealing with external systems that
> > themselves work with codepoints (MySQL comes to my mind). However
> > calculating the Levenshtein distance is most certainly something that
> > purely is "user-facing" and not constrained by external systems.
> > Calculating the distance of codepoints is going to be extremely
> > confusing when dealing with things like Emoji. It would probably best t=
o
> > either only offer a `grapheme_*` function here or to leave this fully t=
o
> > userland.
> >
> > Best regards
> > Tim D=C3=BCsterhus
>
> Hi, Tim
>
> Thank you for response.
> I thinking about wants users what is levenshtein distance.
> Surely, I think Levenshtein distance should be measured in terms of
> grapheme clusters.
>
> In most userland codes that based on UTF-8. So seems move to grapheme
> function is make sense.
> I more thinking usecase of levenshtein. Probably I'm going to grapheme fu=
nction.
>
> Thanks
> Yuya
>
> --
> ---------------------------
> Yuya Hamada (tekimen)
> - https://tekitoh-memdhoi.info
> - https://github.com/youkidearitai
> -----------------------------

Hi, internals
I'm thinking more about use case of mb_levenshtein.
I added test case of mb_levenshtein that compare emoji per code point.
https://github.com/php/php-src/pull/16043/files#diff-d6aca000d2b0ac5982f9f9=
a0fe0425246cfd8411fdfb8645cdfe6f786d526597R86

It means make sense to compare Unicode codepoint.
I think need mb_levenshtein, and also needs grapheme_levenshtein.

What do you think?

Regards
Yuya

--=20
---------------------------
Yuya Hamada (tekimen)
- https://tekitoh-memdhoi.info
- https://github.com/youkidearitai
-----------------------------