Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125793
Precedence: bulk
MIME-Version: 1.0
References: <CAPyeZ4N8GMiLNVCDGxdofcy6txBhng_i2UKUGpiS5bnZ-YcYvA@mail.gmail.com>
 <2A7CF24F-3AE3-4125-965F-C65431C42DFB@gmail.com> <CAPyeZ4MSc=Sw9UE0soCdBEnVAJ8wXHHhYqm88OffkvNLrHPxFw@mail.gmail.com>
 <e966cf16-794d-4827-9a5e-b0de780a5b91@app.fastmail.com> <30a41608-a1ea-40a9-8d2a-c53c508cd89f@jnvsor.net>
 <a6cdfe39-2a18-40b1-8da5-f49e9e7a7918@app.fastmail.com> <CAMrTa2FM4o6q8TXdBbuHfnD66vtqFBVL2Hw6_412Bf1r2T1QMg@mail.gmail.com>
 <CAPyeZ4M0LDzPBTjT_Qa-ccB73DNatGWdARg-mKMO1T1XmnTzUg@mail.gmail.com>
In-Reply-To: <CAPyeZ4M0LDzPBTjT_Qa-ccB73DNatGWdARg-mKMO1T1XmnTzUg@mail.gmail.com>
Date: Sun, 13 Oct 2024 19:01:29 -0700
Message-ID: <CAMrTa2HMx0ZQJ8OMAcyjkGjQfdbCZ5h5u7seS9gP0pzFNYUCsg@mail.gmail.com>
Subject: Re: [PHP-DEV] Asymmetric visibility is a BC break
To: Valentin Udaltsov <udaltsov.valentin@gmail.com>
Cc: Rob Landers <rob@bottled.codes>, internals@lists.php.net
Content-Type: multipart/alternative; boundary="000000000000bb661706246637b4"
From: jordan.ledoux@gmail.com (Jordan LeDoux)

--000000000000bb661706246637b4
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, Oct 13, 2024 at 5:03=E2=80=AFPM Valentin Udaltsov <
udaltsov.valentin@gmail.com> wrote:

> On Mon, 14 Oct 2024=E2=80=AFat 01:28, Jordan LeDoux <jordan.ledoux@gmail.=
com>:
> > Backwards compatible has never, in any work I've done through my entire
> career, meant something like "if you take old code and then update it to
> the new version incorrectly, it doesn't work"... that seems... obvious?
> >
> > What exactly is the claim being made here? Because it sounds like the
> claim is very much that second "definition".
> >
> > Jordan
>
> Hi, Jordan!
>
> The problem is that in practice most of the PHP libraries consider
> themselves to be compatible with newer PHP versions.
>
> For instance, Symfony PropertyInfo uses `"php": ">=3D8.2"` constraint in
> its `composer.json`. However, it is not compatible with PHP 8.4, I've
> just created an issue: https://github.com/symfony/symfony/issues/58556
>
> The end user will be the victim, because `composer require
> symfony/property-info` will happily install property-info v7.1.4 for
> PHP 8.4, but it's not gonna work.
>
> --
> Valentin
>

How does a library that uses code that will not even compile (like
`readonly` or `private(set)`), but claims to not require a PHP version that
uses the syntax, suddenly make a BC problem for the language? Composer
allows libraries to set minimum PHP versions for releases. Any time you
update your libraries, you may have to update your code which uses it.
That's just part of how libraries work.

Jordan

--000000000000bb661706246637b4
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Sun, Oct 13, 2024 at 5:03=E2=80=AF=
PM Valentin Udaltsov &lt;<a href=3D"mailto:udaltsov.valentin@gmail.com">uda=
ltsov.valentin@gmail.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail=
_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204=
,204);padding-left:1ex">On Mon, 14 Oct 2024=E2=80=AFat 01:28, Jordan LeDoux=
 &lt;<a href=3D"mailto:jordan.ledoux@gmail.com" target=3D"_blank">jordan.le=
doux@gmail.com</a>&gt;:<br>
&gt; Backwards compatible has never, in any work I&#39;ve done through my e=
ntire career, meant something like &quot;if you take old code and then upda=
te it to the new version incorrectly, it doesn&#39;t work&quot;... that see=
ms... obvious?<br>
&gt;<br>
&gt; What exactly is the claim being made here? Because it sounds like the =
claim is very much that second &quot;definition&quot;.<br>
&gt;<br>
&gt; Jordan<br>
<br>
Hi, Jordan!<br>
<br>
The problem is that in practice most of the PHP libraries consider<br>
themselves to be compatible with newer PHP versions.<br>
<br>
For instance, Symfony PropertyInfo uses `&quot;php&quot;: &quot;&gt;=3D8.2&=
quot;` constraint in<br>
its `composer.json`. However, it is not compatible with PHP 8.4, I&#39;ve<b=
r>
just created an issue: <a href=3D"https://github.com/symfony/symfony/issues=
/58556" rel=3D"noreferrer" target=3D"_blank">https://github.com/symfony/sym=
fony/issues/58556</a><br>
<br>
The end user will be the victim, because `composer require<br>
symfony/property-info` will happily install property-info v7.1.4 for<br>
PHP 8.4, but it&#39;s not gonna work.<br>
<br>
--<br>
Valentin<br></blockquote><div><br></div><div>How does a library that uses c=
ode that will not even compile (like `readonly` or `private(set)`), but cla=
ims to not require a PHP version that uses the syntax, suddenly make a BC p=
roblem for the language? Composer allows libraries to set minimum PHP versi=
ons for releases. Any time you update your libraries, you may have to updat=
e your code which uses it. That&#39;s just part of how libraries work.</div=
><div><br></div><div>Jordan <br></div></div></div>

--000000000000bb661706246637b4--