Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125785
Feedback-ID: ifab94697:Fastmail
Precedence: bulk
MIME-Version: 1.0
Date: Fri, 11 Oct 2024 12:33:20 +0200
To: internals@lists.php.net
Message-ID: <a6cdfe39-2a18-40b1-8da5-f49e9e7a7918@app.fastmail.com>
In-Reply-To: <30a41608-a1ea-40a9-8d2a-c53c508cd89f@jnvsor.net>
References: 
 <CAPyeZ4N8GMiLNVCDGxdofcy6txBhng_i2UKUGpiS5bnZ-YcYvA@mail.gmail.com>
 <2A7CF24F-3AE3-4125-965F-C65431C42DFB@gmail.com>
 <CAPyeZ4MSc=Sw9UE0soCdBEnVAJ8wXHHhYqm88OffkvNLrHPxFw@mail.gmail.com>
 <e966cf16-794d-4827-9a5e-b0de780a5b91@app.fastmail.com>
 <30a41608-a1ea-40a9-8d2a-c53c508cd89f@jnvsor.net>
Subject: Re: [PHP-DEV] Asymmetric visibility is a BC break
Content-Type: multipart/alternative;
 boundary=1a313d580a084553b20d4bba9c86ec56
From: rob@bottled.codes ("Rob Landers")

--1a313d580a084553b20d4bba9c86ec56
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Fri, Oct 11, 2024, at 12:20, Jonathan Vollebregt wrote:
> > A "proper" implementation won't break, but there may be subtle ways =
that "improper" implementations will break and thus it should be conside=
red a BC break.
>=20
> This thread is fallaciously equating breaks in third-party libraries=20
> _when changing consumer code_, with breaks just by updating PHP.
>=20
> If I'm in PHP 8.1+ and I pass an object into a library and all goes=20
> well, then I change a property to readonly and get an error, that's no=
t=20
> PHP making a breaking change by allowing me to use readonly. That's an=20
> outdated library (and me) breaking my code.
>=20
> I've had my reflection code break on backwards compatible changes load=
s=20
> of times, but every time it required the user to make a change to thei=
r=20
> code first.
>=20
> Valentin's list of examples proves this point. They worked fine on 8.1=20
> _until_ people changed code to add readonly. That's not a BC break. Sa=
me=20
> deal for aviz.
>=20

I guess what I am saying is that we probably need a proper definition of=
 "BC break". IMHO, adding a php version check to do something is probabl=
y a BC break. Serializers will need a version check, thus it is a BC bre=
ak.

=E2=80=94 Rob
--1a313d580a084553b20d4bba9c86ec56
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html><html><head><title></title><style type=3D"text/css">p.Mso=
Normal,p.MsoNoSpacing{margin:0}</style></head><body><div>On Fri, Oct 11,=
 2024, at 12:20, Jonathan Vollebregt wrote:<br></div><blockquote type=3D=
"cite" id=3D"qt" style=3D""><div>&gt; A "proper" implementation won't br=
eak, but there may be subtle ways that "improper" implementations will b=
reak and thus it should be considered a BC break.<br></div><div><br></di=
v><div>This thread is fallaciously equating breaks in third-party librar=
ies&nbsp;<br></div><div>_when changing consumer code_, with breaks just =
by updating PHP.<br></div><div><br></div><div>If I'm in PHP 8.1+ and I p=
ass an object into a library and all goes&nbsp;<br></div><div>well, then=
 I change a property to readonly and get an error, that's not&nbsp;<br><=
/div><div>PHP making a breaking change by allowing me to use readonly. T=
hat's an&nbsp;<br></div><div>outdated library (and me) breaking my code.=
<br></div><div><br></div><div>I've had my reflection code break on backw=
ards compatible changes loads&nbsp;<br></div><div>of times, but every ti=
me it required the user to make a change to their&nbsp;<br></div><div>co=
de first.<br></div><div><br></div><div>Valentin's list of examples prove=
s this point. They worked fine on 8.1&nbsp;<br></div><div>_until_ people=
 changed code to add readonly. That's not a BC break. Same&nbsp;<br></di=
v><div>deal for aviz.<br></div><div><br></div></blockquote><div><br></di=
v><div>I guess what I am saying is that we probably need a proper defini=
tion of "BC break". IMHO, adding a php version check to do something is =
probably a BC break. Serializers will need a version check, thus it is a=
 BC break.</div><div><br></div><div id=3D"sig121229152">=E2=80=94 Rob<br=
></div></body></html>
--1a313d580a084553b20d4bba9c86ec56--