Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125779
Precedence: bulk
MIME-Version: 1.0
References: <CAPyeZ4N8GMiLNVCDGxdofcy6txBhng_i2UKUGpiS5bnZ-YcYvA@mail.gmail.com>
 <2A7CF24F-3AE3-4125-965F-C65431C42DFB@gmail.com>
In-Reply-To: <2A7CF24F-3AE3-4125-965F-C65431C42DFB@gmail.com>
Date: Thu, 10 Oct 2024 16:32:38 +0300
Message-ID: <CAPyeZ4MSc=Sw9UE0soCdBEnVAJ8wXHHhYqm88OffkvNLrHPxFw@mail.gmail.com>
Subject: Re: [PHP-DEV] Asymmetric visibility is a BC break
To: Claude Pache <claude.pache@gmail.com>
Cc: php internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
From: udaltsov.valentin@gmail.com (Valentin Udaltsov)

On 09.102024=E2=80=AFat 19:20 Claude Pache <claude.pache@gmail.com> wrote:
> There is no BC break, in the sense that code that worked under PHP 8.3 (a=
nd therefore use PHP 8.3 features only) will not break when run under PHP 8=
.4.
>
> Of course, code that makes assumptions that are true when using PHP 8.3 f=
eatures only, will need to be adapted as soon as PHP 8.4 features are used.=
 This is unsurprising and expected.

Hi, Claude!

Thank you for the explanation. I now get why aviz does not break BC :)
Until now, I was worried that we were missing something important.

> That said, https://github.com/php/php-src/pull/16209 is interesting to ha=
ve, but not mandatory. The current `ReflectionProperty::isPropertySet()` an=
d `ReflectionProperty::isPrivateSet()` might be somewhat confusing at first=
, but they are sufficient in order to obtain the needed information.

Yes, they are sufficient, but very difficult to work with. Just to
check that property is writable from global scope, you have to do
`isPublic() && !isReadonly() && !isPrivateSet() && !isProtectedSet()
&& (!isVirtual() || hasHook(PropertyHookType::Set))`.
See our discussion with Ilija:
https://github.com/php/php-src/issues/16175#issuecomment-2389966021

--
Valentin