Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125758
Feedback-ID: i8414410d:Fastmail
Precedence: bulk
MIME-Version: 1.0
Date: Sun, 06 Oct 2024 08:30:21 -0500
To: "php internals" <internals@lists.php.net>
Message-ID: <4ac3beb3-2322-44ca-862c-18591636a76f@app.fastmail.com>
In-Reply-To: <67023B59.6020301@adviesenzo.nl>
References: <66FC7B9F.5070906@adviesenzo.nl>
 <CAOWwgp=--t8xMEE6Dso9whYKydjHPiXz69PTp=AYOU8en3TjcQ@mail.gmail.com>
 <67023B59.6020301@adviesenzo.nl>
Subject: Re: [PHP-DEV] [RFC] [Discussion] Add get_declared_enums() function
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
From: larry@garfieldtech.com ("Larry Garfield")

On Sun, Oct 6, 2024, at 2:25 AM, Juliette Reinders Folmer wrote:

> I can imagine combining the alternative approach via 
> get_declared_symbols() with a new symbol_exists() function like you 
> suggest above (with a similar slow path to deprecate and remove the old 
> functions).
>
> On the plus side, the alternative approach makes for much more 
> versatile functionality. In a number of the cases I looked at, the 
> results from various get_declared_*() functions are combined before 
> further processing, so having a `get-declared_symbols()` function would 
> allow for simplifying that code. The same can be said for the 
> *_exists() functions.

FWIW, I'd love to have get_declared_symbols() and symbol_exists() functions, regardless of what we do with enums in particular.  That's arguably a topic for another RFC, though.  (And debatable if functions would count as symbols, but again, topic for another time.)

--Larry Garfield