Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125755
Precedence: bulk
MIME-Version: 1.0
References: <CAEPPVa3ZCOLm7tgToDVdZ01U4M91yAPZjgG8CV241=cmTp5m0g@mail.gmail.com>
 <754710ced33bdb2f9840d96ba0c58424@bastelstu.be>
In-Reply-To: <754710ced33bdb2f9840d96ba0c58424@bastelstu.be>
Date: Sun, 6 Oct 2024 14:45:07 +0900
Message-ID: <CAEPPVa0hs4W+RBwhWoZ4AX8DOCECGAh9U3a_y1b1JBCd5tgiXQ@mail.gmail.com>
Subject: Re: [PHP-DEV][DISCUSSION] Multibyte for levenshtein function
To: php internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
From: youkidearitai@gmail.com (youkidearitai)

2024=E5=B9=B410=E6=9C=885=E6=97=A5(=E5=9C=9F) 1:20 Tim D=C3=BCsterhus <tim@=
bastelstu.be>:
>
> Hi
>
> Am 2024-09-25 09:21, schrieb youkidearitai:
> > I tried implement mb_levenshtein function and create an RFC.
> > https://wiki.php.net/rfc/mb_levenshtein
> > https://github.com/php/php-src/pull/16043
> >
> > I would like discussion, feel free to comment.
>
> Thank you for your RFC. I share the concern raised by cmb in the PR
> discussion:
> https://github.com/php/php-src/pull/16043#issuecomment-2374574538
>
> Generally working with codepoints is going to be confusing for a user,
> but sometimes it is necessary when dealing with external systems that
> themselves work with codepoints (MySQL comes to my mind). However
> calculating the Levenshtein distance is most certainly something that
> purely is "user-facing" and not constrained by external systems.
> Calculating the distance of codepoints is going to be extremely
> confusing when dealing with things like Emoji. It would probably best to
> either only offer a `grapheme_*` function here or to leave this fully to
> userland.
>
> Best regards
> Tim D=C3=BCsterhus

Hi, Tim

Thank you for response.
I thinking about wants users what is levenshtein distance.
Surely, I think Levenshtein distance should be measured in terms of
grapheme clusters.

In most userland codes that based on UTF-8. So seems move to grapheme
function is make sense.
I more thinking usecase of levenshtein. Probably I'm going to grapheme func=
tion.

Thanks
Yuya

--=20
---------------------------
Yuya Hamada (tekimen)
- https://tekitoh-memdhoi.info
- https://github.com/youkidearitai
-----------------------------