Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125751
Precedence: bulk
MIME-Version: 1.0
Date: Fri, 04 Oct 2024 18:20:52 +0200
To: youkidearitai <youkidearitai@gmail.com>
Cc: php internals <internals@lists.php.net>
Subject: Re: [PHP-DEV][DISCUSSION] Multibyte for levenshtein function
In-Reply-To: <CAEPPVa3ZCOLm7tgToDVdZ01U4M91yAPZjgG8CV241=cmTp5m0g@mail.gmail.com>
References: <CAEPPVa3ZCOLm7tgToDVdZ01U4M91yAPZjgG8CV241=cmTp5m0g@mail.gmail.com>
Message-ID: <754710ced33bdb2f9840d96ba0c58424@bastelstu.be>
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

Am 2024-09-25 09:21, schrieb youkidearitai:
> I tried implement mb_levenshtein function and create an RFC.
> https://wiki.php.net/rfc/mb_levenshtein
> https://github.com/php/php-src/pull/16043
> 
> I would like discussion, feel free to comment.

Thank you for your RFC. I share the concern raised by cmb in the PR 
discussion: 
https://github.com/php/php-src/pull/16043#issuecomment-2374574538

Generally working with codepoints is going to be confusing for a user, 
but sometimes it is necessary when dealing with external systems that 
themselves work with codepoints (MySQL comes to my mind). However 
calculating the Levenshtein distance is most certainly something that 
purely is "user-facing" and not constrained by external systems. 
Calculating the distance of codepoints is going to be extremely 
confusing when dealing with things like Emoji. It would probably best to 
either only offer a `grapheme_*` function here or to leave this fully to 
userland.

Best regards
Tim Düsterhus