Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125724
Precedence: bulk
MIME-Version: 1.0
References: <66FC7B9F.5070906@adviesenzo.nl>
In-Reply-To: <66FC7B9F.5070906@adviesenzo.nl>
Date: Wed, 2 Oct 2024 10:20:25 +0300
Message-ID: <CAAwdEzC8sGt2+PcJfWTfLDooPTsqBk7YAdK-zXs7QMgDALX+LA@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] [Discussion] Add get_declared_enums() function
To: Juliette Reinders Folmer <php-internals_nospam@adviesenzo.nl>
Cc: PHP internals <internals@lists.php.net>, Ayesh Karunaratne <ayesh@php.watch>
Content-Type: multipart/alternative; boundary="0000000000009212e606237946f6"
From: drealecs@gmail.com (=?UTF-8?Q?Alexandru_P=C4=83tr=C4=83nescu?=)

--0000000000009212e606237946f6
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Oct 2, 2024 at 1:48=E2=80=AFAM Juliette Reinders Folmer <
php-internals_nospam@adviesenzo.nl> wrote:

> L.S.,
>
> After the earlier discussion [1] regarding this topic in August, it is ou=
r
> pleasure to present the RFC to add a `get_declared_enums()` function to P=
HP
> for discussion.
>
> https://wiki.php.net/rfc/get_declared_enums
>
> We look forward to your feedback and hope for a constructive discussion.
>
>
I'm all for `get_declared_enums()`.
However, I don't accept that enums are not classes and going with the
assumption that they are not will bring more problems than it solves.

I noticed how you analyzed things internally, that everything is a class
internally, including an interface or a trait.
But this is an API for the userland, and in userland this is not true.
The 3 structures: classes, interfaces and traits and distinct things that
you can use in different ways in (generated) code.

I believe that in userland, the common understanding is that enums are just
a specific type of class, final ones.
I would find it surprising if `get_declared_classes()` would not return
enums.

Avoiding a BC break would be nice also if there is no reason for it.
One would be able to get only the enums by using something like:
```php
function get_declared_enums_only() {
    return array_diff(get_declared_classes(), get_declared_enums());
}
```

--=20
Alex

--0000000000009212e606237946f6
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><div class=3D"gmail_quote"><div=
 dir=3D"ltr" class=3D"gmail_attr">On Wed, Oct 2, 2024 at 1:48=E2=80=AFAM Ju=
liette Reinders Folmer &lt;<a href=3D"mailto:php-internals_nospam@adviesenz=
o.nl">php-internals_nospam@adviesenzo.nl</a>&gt; wrote:<br></div><blockquot=
e class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px s=
olid rgb(204,204,204);padding-left:1ex">
 =20

   =20
 =20
  <div bgcolor=3D"#FFFFFF">
    <font size=3D"-1"><font face=3D"Verdana">L.S.,<br>
        <br>
        After the earlier discussion [1] regarding this topic in August,
        it is our pleasure to present the RFC to add a
        `get_declared_enums()` function to PHP for discussion.<br>
        <br>
        <a href=3D"https://wiki.php.net/rfc/get_declared_enums" target=3D"_=
blank">https://wiki.php.net/rfc/get_declared_enums</a><br>
        <br>
        We look forward to your feedback and hope for a constructive
        discussion.<br>
        <br></font></font></div></blockquote><div><br></div><div>I&#39;m al=
l for `get_declared_enums()`.</div><div>However, I don&#39;t accept that en=
ums are not classes and going with the assumption that they are not will br=
ing more problems than it solves.</div><div><br></div><div>I noticed how=C2=
=A0you analyzed things internally, that everything is a class internally, i=
ncluding an interface or a trait.</div><div>But this is an API for the user=
land, and in userland this is not true.</div><div>The 3 structures: classes=
, interfaces and traits and distinct things that you can use in different w=
ays in (generated) code.</div><div><br></div><div>I believe that in userlan=
d, the common understanding is that enums are just a specific type of class=
, final ones.</div><div>I would find it surprising if `get_declared_classes=
()` would not return enums.</div><div><br></div><div>Avoiding a BC break wo=
uld be nice also if there is no reason for it.</div><div>One would be able =
to get only the enums by using something like:</div><div>```php<br>function=
 get_declared_enums_only() {<br>=C2=A0 =C2=A0 return array_diff(get_declare=
d_classes(), get_declared_enums());<br>}<br>```</div><div><br></div><div>--=
=C2=A0</div><div>Alex</div><div><br></div></div></div>

--0000000000009212e606237946f6--