Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125672
Feedback-ID: id4f946ef:Fastmail
Precedence: bulk
MIME-Version: 1.0
Date: Tue, 24 Sep 2024 22:00:24 +0200
To: "PHP internals" <internals@lists.php.net>
Message-ID: <c0b40815-f4f0-4231-918b-f906c410a647@app.fastmail.com>
In-Reply-To: <1c37882a-a8b9-4754-bc2c-bee43aa39d6a@gmx.de>
References: 
 <P6xPt0ZYEazlMTs9BVOycmeenVAG0kdiI8zFOT-1rnZOHgT3y8PrYYQkYfHNw-kY-WihZzmT4R5Zp95M95jPtnlzME6qNF9GaFlT9RhMMZA=@gpb.moe>
 <8de40002-1b2c-4baa-bbcf-997780e8a6ac@gmx.de>
 <pX9SbbGv_3QUyw2ROo75__FmcbRs6mRwnOiQP3U4LvVjUFWfxhGMH2LvkFIBiedd8WYbD7nYo9mG1xOK-p8-QZzgHnrZ2YBZdP1ulKWFn-Q=@gpb.moe>
 <1c37882a-a8b9-4754-bc2c-bee43aa39d6a@gmx.de>
Subject: Re: [PHP-DEV] [RFC] Warn on conversions from resource to string
Content-Type: multipart/alternative;
 boundary=601a0f76d6aa40a4aa446bb3c81bd73a
From: langemeijer@php.net ("Casper Langemeijer")

--601a0f76d6aa40a4aa446bb3c81bd73a
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

Hi,

ssh2 maintainer here. Low maintenance is indeed somewhat accurate. I review and merge PR's, have done some minor work on it, and do releases sometimes. Some others on this list have done minor work on it too. 

On Tue, Sep 24, 2024, at 19:53, Christoph M. Becker wrote:
> >>> Let me know what you think about it:
> >>> https://wiki.php.net/rfc/warn-resource-to-string
> >>
> >> The ssh2 wrappers[1] used to use this "feature". I'm not sure whether
> >> there is another way to accomplish the same now. If not, that should
> >> probably be done prior to emitting a warning for the resource to string
> >> conversion.
> >>
> >> [1] https://www.php.net/manual/en/wrappers.ssh2.php

Indeed, the ssh2 extension uses this.

I'm not sure what warnings on conversion to string would bring for PHP developers though.

The places where resource values are still used are all in very technical functions. Most developers will use some wrapper class, or of not very likely know what they are doing. Personally I've never accidentally echo'ed a resource and wished it would have registered in my monitoring systems.

Secondly, I don't think it happens very often. (not nearly as much as array to string conversion has hit me)

As a third argument against this RFC: We're moving away from the resource type. Processes, sockets, curl and possibly others that have escaped my attention have already been changed to objects. I've already concluded that ssh2 should follow and use an object, at least before resource will be removed in core. I've noticed stream also still uses resource. 

Greetings, Casper
--601a0f76d6aa40a4aa446bb3c81bd73a
Content-Type: text/html
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html><html><head><title></title><style type=3D"text/css">p.Mso=
Normal,p.MsoNoSpacing{margin:0}</style></head><body><div>Hi,<br></div><d=
iv><br></div><div>ssh2 maintainer here. Low maintenance is indeed somewh=
at accurate. I review and merge PR's, have done some minor work on it, a=
nd do releases sometimes. Some others on this list have done minor work =
on it too.&nbsp;<br></div><div><br></div><div>On Tue, Sep 24, 2024, at 1=
9:53, Christoph M. Becker wrote:<br></div><blockquote type=3D"cite" id=3D=
"qt" style=3D""><div>&gt;&gt;&gt; Let me know what you think about it:<b=
r></div><div>&gt;&gt;&gt;&nbsp;<a href=3D"https://wiki.php.net/rfc/warn-=
resource-to-string">https://wiki.php.net/rfc/warn-resource-to-string</a>=
<br></div><div>&gt;&gt;<br></div><div>&gt;&gt; The ssh2 wrappers[1] used=
 to use this "feature". I'm not sure whether<br></div><div>&gt;&gt; ther=
e is another way to accomplish the same now. If not, that should<br></di=
v><div>&gt;&gt; probably be done prior to emitting a warning for the res=
ource to string<br></div><div>&gt;&gt; conversion.<br></div><div>&gt;&gt=
;<br></div><div>&gt;&gt; [1]&nbsp;<a href=3D"https://www.php.net/manual/=
en/wrappers.ssh2.php">https://www.php.net/manual/en/wrappers.ssh2.php</a=
><br></div></blockquote><div><br></div><div>Indeed, the ssh2 extension u=
ses this.<br></div><div><br></div><div> I'm not sure what warnings on co=
nversion to string would bring for PHP developers though.<br></div><div>=
<br></div><div>The places where resource values are still used are all i=
n very technical functions. Most developers will use some wrapper class,=
 or of not very likely know what they are doing. Personally I've never a=
ccidentally echo'ed a resource and wished it would have registered in my=
 monitoring systems.<br></div><div><br></div><div>Secondly, I don't thin=
k it happens very often. (not nearly as much as array to string conversi=
on has hit me)<br></div><div><br></div><div><div>As a third argument aga=
inst this RFC: We're moving away from the resource type. Processes, sock=
ets, curl and possibly others that have escaped my attention have alread=
y been changed to objects. I've already concluded that ssh2 should follo=
w and use an object, at least before resource will be removed in core.&n=
bsp;I've noticed stream also still uses resource.&nbsp;<br></div><div><b=
r></div></div><div>Greetings, Casper</div></body></html>
--601a0f76d6aa40a4aa446bb3c81bd73a--