Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125671
Message-ID: <1c37882a-a8b9-4754-bc2c-bee43aa39d6a@gmx.de>
Date: Tue, 24 Sep 2024 19:53:50 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] [RFC] Warn on conversions from resource to string
Content-Language: de-DE
To: "Gina P. Banyard" <internals@gpb.moe>
Cc: PHP internals <internals@lists.php.net>
References: <P6xPt0ZYEazlMTs9BVOycmeenVAG0kdiI8zFOT-1rnZOHgT3y8PrYYQkYfHNw-kY-WihZzmT4R5Zp95M95jPtnlzME6qNF9GaFlT9RhMMZA=@gpb.moe>
 <8de40002-1b2c-4baa-bbcf-997780e8a6ac@gmx.de>
 <pX9SbbGv_3QUyw2ROo75__FmcbRs6mRwnOiQP3U4LvVjUFWfxhGMH2LvkFIBiedd8WYbD7nYo9mG1xOK-p8-QZzgHnrZ2YBZdP1ulKWFn-Q=@gpb.moe>
In-Reply-To: <pX9SbbGv_3QUyw2ROo75__FmcbRs6mRwnOiQP3U4LvVjUFWfxhGMH2LvkFIBiedd8WYbD7nYo9mG1xOK-p8-QZzgHnrZ2YBZdP1ulKWFn-Q=@gpb.moe>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:ASPeo1kPkUY=;wfkl3DL319MtgMv5un9Xn1wB3Vv
 FpWCpzXpE8HPsd5bbmy/X6yffCriHueFtOKSOsvtHCNjv06NkRIN/u3if+yKlZ7XmZsPtEJrx
 uda6o6tA+fLqrPOusZzRA9GbkB6Kk1L9jY2O4HqY+gp5c4qjV6VNPToBi5jCjtrtRSdy9xe4w
 v4ndtQSqb6ClyXNIUNYj+R++oeXQeXs9Dbn0TUxvGwEYLFw490WiKATn3+f7+CQVX5N5mgOKM
 PwmAjnv/Cw05vQulXDyTrStnL0AJIBeEuCn8p4k58ieeqqrzxXkkODV4dxX8VvKn3g1FzTM7/
 9a8NyJl6m+H2ldtFSgypcNDx9KnUkE4hBP5sOOnenC12yUNyHZbEUJTbNTfLw/FOh6OMrl5Xa
 MlZq5vwKrzpw6xnrKh9yhNVtLyPtKNYMUZChbasWT+t8kGhJcUDLaUC90GxBamFPgKSszYbxD
 XaCJKv39VBO5kAoiIVbBCQs3Qdr49JGj85tl88FtfbyCYhGdZlPGX8kE90qHKOceg3FVCroho
 z3vxJuSO7gy6N0vhVROPPEg8W8szbpRjP9z/XRI0cGtADEwbnMD/pobh6RJBcFmpRP9dgwqR7
 kGyUSOONFWkjx+k+1oFFpxTgZgAoV35Mb/uqyfGh8GDBAhzF6m7MBfgDSzJh3/EbyaWz3iDK6
 wM0LQ0bZSH2OG8y6c0RT7yTYuN0IpUog9B6xiEQskJRq82OeH0Qn/qCIDh/8RpN7G5CPH7lGS
 IcpcayzPiHS05xzwjv0vj5raIO9meyYYioaAyQVoYiEFM5TRAV7g7HP2bafiwvxKsMKiYQ+fm
 l0W3s50MilCilxfPTcWTHrA90vv4jvsGjW3tkLI8UP+Mk=
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 24.09.2024 at 19:21, Gina P. Banyard wrote:

> On Tuesday, 24 September 2024 at 14:24, Christoph M. Becker <cmbecker69@=
gmx.de> wrote:
>
>> On 24.09.2024 at 14:18, Gina P. Banyard wrote:
>>
>>> Let me know what you think about it:
>>> https://wiki.php.net/rfc/warn-resource-to-string
>>
>> The ssh2 wrappers[1] used to use this "feature". I'm not sure whether
>> there is another way to accomplish the same now. If not, that should
>> probably be done prior to emitting a warning for the resource to string
>> conversion.
>>
>> [1] https://www.php.net/manual/en/wrappers.ssh2.php
>
> I guess that it could always use the integer representation of the resou=
rce.
> Or, more sensibly, be converted to an opaque object that implements a __=
toString() method.

The former would require to change existing code (I presume that this
"feature" is used quite often); the latter would be something that
wouldn't break such code, and be a good idea generally.

> I have encountered some other issues in the engine exposed by this conve=
rsion,
> the biggest one being array_diff/array_intersect, so I could also spend =
some time working on that extension.

That would be great.  I think that ssh2 is one of the more important
PECL extensions, but unfortunately in low maintenance mode.  However,
I'm not sure about the future of libssh2[1].

[1] <https://github.com/libssh2/libssh2/discussions/1249>

Christoph