Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125631
Precedence: bulk
MIME-Version: 1.0
Date: Thu, 19 Sep 2024 14:31:10 +0200
To: "Christoph M. Becker" <cmbecker69@gmx.de>
Cc: Vincent Langlet <misterdeviling@gmail.com>, PHP Internals List
 <internals@lists.php.net>
Subject: Re: [PHP-DEV] strrchr with needle with multiple characters
In-Reply-To: <e1321b08-2329-4000-95b9-dc3daf1dca9a@gmx.de>
References: <CABEW5qcXrpZCjsbqF9bgDwX4vgCP71aEExwdwRopVL3PW=Tvrg@mail.gmail.com>
 <e1321b08-2329-4000-95b9-dc3daf1dca9a@gmx.de>
Message-ID: <b79e6fea696639af63b1fbe922403615@bastelstu.be>
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

Am 2024-09-02 15:24, schrieb Christoph M. Becker:
> Now, comparing strstr() and strrchr() is of course still possible, but
> different behavior is less astonishing.  Of course, strrchr() could 
> warn
> or even throw if $needle has more than one character, but that may
> unnecessarily break code for a small benefit.

I would expect that passing more than one character to `strrchr()` is 
very likely to be an accident or a misunderstanding of how the function 
behaves and thus already broken. A warning would just visibly point out 
that it is broken, instead of it silently behaving in a manner that 
diverges from the user's expectations (possibly unpredictably if the 
function is working on untrusted / user input).

If the function would be newly introduced, I'd make it an error to pass 
more than one character, but given that the function already exists, I'd 
say that pointing out such mistakes is exactly what the Warning / Notice 
facility is for.

Best regards
Tim Düsterhus