Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125571
Precedence: bulk
MIME-Version: 1.0
Date: Mon, 16 Sep 2024 11:00:25 -0700
Message-ID: <CALaXqqR4CVLV2Lrvqq_9ESG2cYj-ySnOF+MrJYt7pfkrAt+MeQ@mail.gmail.com>
Subject: [PHP-DEV] Adding new `ReflectionConstant::getFileName()`
To: internals@lists.php.net
Content-Type: multipart/alternative; boundary="0000000000001e3bf50622405be6"
From: daniel.e.scherzer@gmail.com (Daniel Scherzer)

--0000000000001e3bf50622405be6
Content-Type: text/plain; charset="UTF-8"

Dear Internals,

Last week I sent a patch[1] to address a feature request[2] for a way to
identify at runtime what file a constant was declared in. Since this adds
the filename (a `zend_string`) to every `zend_constant` instance, it is not
the most trivial of changes.

It was suggested[3] by iluuu1994 that this may qualify as a small change
that can be merged without an RFC, if there are no objections on the
mailing list. So, are there any objections?

I'll note that the `ReflectionConstant` class was added[4] as part of PHP
8.4, so it would be great if this new method could also be included as part
of the 8.4 release.

Thanks,
--Daniel Scherzer (https://github.com/DanielEScherzer)

[1] https://github.com/php/php-src/pull/15847
[2] https://github.com/php/php-src/issues/15723
[3] https://github.com/php/php-src/pull/15847#issuecomment-2345774089
[4] https://github.com/php/php-src/pull/13669

--0000000000001e3bf50622405be6
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Dear Internals,<div><br></div><div>Last week I sent a patc=
h[1] to address a feature request[2] for a way to identify at runtime what =
file a constant was declared in. Since this adds the filename (a `zend_stri=
ng`) to every `zend_constant` instance, it is not the most trivial of chang=
es.</div><div><br></div><div>It was suggested[3] by=C2=A0iluuu1994=C2=A0tha=
t this may qualify as a small change that can be merged without an RFC, if =
there are no objections on the mailing list. So, are there any objections?<=
/div><div><br></div><div>I&#39;ll note that the `ReflectionConstant` class =
was added[4] as part of PHP 8.4, so it would be great if this new method co=
uld also be included as part of the 8.4 release.</div><div><br></div><div>T=
hanks,</div><div>--Daniel Scherzer (<a href=3D"https://github.com/DanielESc=
herzer">https://github.com/DanielEScherzer</a>)</div><div><br></div><div>[1=
]=C2=A0<a href=3D"https://github.com/php/php-src/pull/15847">https://github=
.com/php/php-src/pull/15847</a></div><div>[2]=C2=A0<a href=3D"https://githu=
b.com/php/php-src/issues/15723">https://github.com/php/php-src/issues/15723=
</a></div><div>[3]=C2=A0<a href=3D"https://github.com/php/php-src/pull/1584=
7#issuecomment-2345774089">https://github.com/php/php-src/pull/15847#issuec=
omment-2345774089</a></div><div>[4]=C2=A0<a href=3D"https://github.com/php/=
php-src/pull/13669">https://github.com/php/php-src/pull/13669</a></div></di=
v>

--0000000000001e3bf50622405be6--