Newsgroups: php.internals,php.internals.win
Path: news.php.net
Xref: news.php.net php.internals:125509 php.internals.win:1302
Message-ID: <0f51ed68-7715-406f-b8cf-2287a8c5ac90@gmx.de>
Date: Wed, 11 Sep 2024 18:21:03 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] Maintain Windows PHP dependency builds in a GH repo
Content-Language: de-DE
To: Derick Rethans <derick@php.net>
Cc: PHP internals list <internals@lists.php.net>, contact@shivammathur.com,
 internals-win <internals-win@lists.php.net>
References: <cca18b22-9bf4-41dd-9673-e654a5d76794@gmx.de>
 <91e789ef-fd36-6a44-74ac-9998668b7fde@php.net>
 <1c6ece3c-dc72-4f62-9be6-d15c8e616dfc@gmx.de>
 <f31077ce-7fd3-b006-21d6-b87d1fe839b4@php.net>
In-Reply-To: <f31077ce-7fd3-b006-21d6-b87d1fe839b4@php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:zCdBoYOn1D4=;/QwGUbA4A6h8E2Uw7lVeF4ls45d
 vkTfxhhbuXE1MEweNlgxGdKJdThrFWeIi6n63wwcZykWiPC4ztnG79Bi0vfLfv8IztVrCy7WU
 LFWKC7LxjSaOpBpz1eTWDLxJRE7fs84NqcLnFnK9IES1+KyIMGT9Dm7FZZ73zrhYTXGF/zMVd
 zFHzC9NPQN7Z4OAF0qNEtkUpKPkm3Vrwlhmv8mYgUPaCZGVaONi5z2U2Ybqdqg9dDSptJrz59
 li1Z+Ao8i63GBVSQtX6lh9NNhp9kzxWcWi04GQqb8NyjvGGK/xvVW055sFcYdmdNzzUZiXFn4
 W+xSYK9TgbEbkOqKk5Gu54mlVzBRiEuLsE3b7hkOPl3VniVSA/imHfCnwrsHjdez+qk7AtOF2
 zb2MRBY/6891xulqr/uudiyEFkAY54JWf6gcIv+PgyKRmyoKjGOw1oTvKFoAuMY+b4NdkbQQ+
 WJqBZtBVRfiweJzSaBJzxpC0YqEZqltHQaZ1PnA8/M0BykdJLbVJZU+aeC7RHnd8xvilxOvN7
 XmPd7VDtvNG4F6FfBfQsFzPccvbyTqbpSJhvooBCjfMqa1dcmo9Ql2SChMd0yJr0S8nFbf2aV
 lTn+sgxOe9J8TE1awKAFkMAjUWqqg/cCxjBGA02n0dJivehsfCFRblJy/qpPS9TT+zOVQnBo/
 Y3H/3IYoap4K2rVsyYR+TWH+vTHa67o5BusbhwfugnbOX/4KvzbPQLIUbfA5BvFAFwb7L9LJs
 RTfNGQEzZKjdMvcUvEyygeLJAs3Q8An79KxDOj/heDfl6RjHKhjHm3sjcKhlFFuQCKSrfIwiA
 rRFFZ/lTfUZZmwgRHGHfgiJlNn6BTQXuR0CdkgBP25c0U=
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 11.09.2024 at 15:51, Derick Rethans wrote:
> On Sun, 8 Sep 2024, Christoph M. Becker wrote:
>
>> On 08.09.2024 at 16:58, Derick Rethans wrote:
>>
>
> Ok, but I still don't see why you need an RFC for this? :-)

Oh, I don't need an RFC for this.  Actually, you can read my question as
"does this *really* need an RFC, or can we do without?"

> I know Shivam (https://github.com/php/web-downloads) has also been
> working on doing automatic pulls of PECL builds onto the "downloads"
> server.
>
> The idea was to trigger a GitHub action to call to this API to then
> download file file. Ideally the downloads server *pulls* files, as
> uploading *to* it can't work through GHA as we require 2FA through a
> jump host.

I see.

> We'll have to have multiple Git repositories, and perhaps subdomain
> names to make this all work.
>
> The downloads.php.net site currently doesn't have any code yet, as I am
> waiting for this 404 ErrorHandler to be included in it:
>
> 	<?php
> 	if (preg_match('/Win32-vc/', $_SERVER['REQUEST_URI'])) {
> 	        $fixed =3D str_replace( 'Win32-vc', 'Win32-VC', $_SERVER['REQUE=
ST_URI'] );
> 	        header("Location: $fixed", true, 301);
> 	        exit();
> 	}
>
> 	header('Location: /', true, 404);
>
> Ideally, instead of having downloads.php.net/~windows, we have
> downloads.php.net/windows which is a Git repository for the series
> files, but it is probably better if it's all in that same web-downloads
> repository.

Oh, there might be slight misunderstanding.  By "series files" I only
refer to what is in
<https://downloads.php.net/~windows/php-sdk/deps/series/>; nothing else.

While the upload/download issue might be solved one way or the other,
having a Git repository for the series files might solve a couple of
issues.  I've set up <https://github.com/cmb69/php-windeps-series> as a
demonstration of what I have in mind.  For instance, it is hard to keep
an overview of which packages are in which series; packages.csv helps a
bit (and GH displays this nicely[1]).  And then I made PR #1, which
shows a x64/x86 mismatch[2] (actually multiple, but ignore the trailing
-1 lines mismatches).  Finally, I made PR #2, which uses a locally run
script to push staging to stable.  Many more checks and automations can
be done in the future; but you already get the gist.

[1] <https://github.com/cmb69/php-windeps-series/blob/main/packages.csv>
[2]
<https://github.com/cmb69/php-windeps-series/actions/runs/10815285786/job/=
30003806974?pr=3D1#step:3:17>

Christoph