Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125443
Precedence: bulk
MIME-Version: 1.0
References: <CAGKNXQG32aF58gPnf1ywbmde72F_Wwjib0oXhN_ve6336RnQXg@mail.gmail.com>
In-Reply-To: <CAGKNXQG32aF58gPnf1ywbmde72F_Wwjib0oXhN_ve6336RnQXg@mail.gmail.com>
Date: Thu, 5 Sep 2024 16:15:38 -0400
Message-ID: <CANYPt=Un8Qngwk5Pqz+cFS0h+mO8kywnxsnXLNehrmDeFbTeAA@mail.gmail.com>
Subject: Re: [PHP-DEV] RFC: Deprecate json_encode() on classes marked as non-serializable
To: Philip Hofstetter <phofstetter@sensational.ch>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000d6f60c062164f4b4"
From: vasilii.b.shpilchin@gmail.com (Vasilii Shpilchin)

--000000000000d6f60c062164f4b4
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hello Philip,

Thank you for your RFC, which is a great effort to improve serialization in
PHP. Generators are indeed super useful and working with them should not be
confusing.

I regret that I missed your previous emails, but I would like to suggest
that you consider the following concerns:

1. The original serialization and json_encode are not symmetric nor
interchangeable by definition, because JSON doesn't preserve protected
properties and class names. Hence, I don't see them to be "inconsistent" as
they were not designed to be consistent.
2. The reason why some objects are not serializable is because they
couldn't be fully functioning after deserialization. But this is not a
barrier for JSON encoding, which serializing public properties only.
Current JSON encoding has a simple, straight forward logic, not tied to
serialization in any way.

You have suggested to cast a non-serializable objects to array as a
workaround. Yet, array is the most popular type to JSON in PHP. To me, an
ideal move would be make json_encode to iterate any iterators from the
input structure. Well, this is a different topic.

Best regards,
Vasilii

On Tue, Sep 3, 2024, 7:26=E2=80=AFAM Philip Hofstetter <phofstetter@sensati=
onal.ch>
wrote:

> Hello,
>
> As per my previous email to the list, I have now created the official RFC
> to deprecate calling json_serialize() on instances of classes marked with
> ZEND_ACC_NOT_SERIALIZABLE.
>
> https://wiki.php.net/rfc/deprecate-json_encode-nonserializable
>
> I have also created a PR with the implementation here:
>
> https://github.com/php/php-src/pull/15724
>
> I have considered other options, both constraining the implementation to
> just Generator and/or to add special cases for Generator (and maybe
> Iterator), but they either continue to keep the asymmetry between
> serialize() and json_encode() and/or are making things even more
> inconsistent.
>
> Please tell me what you think, especially, if you agree that
> blanked-deprecating all of ZEND_ACC_NOT_SERIALIZABLE classes is acceptabl=
e
> BC-wise (after a bit of deliberation over the weekend, I think it is and
> most json-serializations of such marked classes are probably unintentiona=
l).
>
> Thanks in advance for all comments
>
> Philip
>
>
>

--000000000000d6f60c062164f4b4
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto">Hello Philip,<br><br>Thank you for your RFC, which is a g=
reat effort to improve serialization in PHP. Generators are indeed super us=
eful and working with them should not be confusing.<br><br>I regret that I =
missed your previous emails, but I would like to suggest that you consider =
the following concerns:<br><br>1. The original serialization and json_encod=
e are not symmetric nor interchangeable by definition, because JSON doesn&#=
39;t preserve protected properties and class names. Hence, I don&#39;t see =
them to be &quot;inconsistent&quot; as they were not designed to be consist=
ent.<br>2. The reason why some objects are not serializable is because they=
 couldn&#39;t be fully functioning after deserialization. But this is not a=
 barrier for JSON encoding, which serializing public properties only. Curre=
nt JSON encoding has a simple, straight forward logic, not tied to serializ=
ation in any way.<br><br>You have suggested to cast a non-serializable obje=
cts to array as a workaround. Yet, array is the most popular type to JSON i=
n PHP. To me, an ideal move would be make json_encode to iterate any iterat=
ors from the input structure. Well, this is a different topic.<br><br>Best =
regards,<br>Vasilii<div><br></div><div class=3D"gmail_quote" dir=3D"auto"><=
div dir=3D"ltr" class=3D"gmail_attr">On Tue, Sep 3, 2024, 7:26=E2=80=AFAM P=
hilip Hofstetter &lt;<a href=3D"mailto:phofstetter@sensational.ch" rel=3D"n=
oreferrer noreferrer noreferrer" target=3D"_blank">phofstetter@sensational.=
ch</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margi=
n:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div dir=3D"=
ltr">Hello,<div><br><div class=3D"gmail_signature" data-smartmail=3D"gmail_=
signature"><div dir=3D"ltr">As per my previous email to the list, I have no=
w created the official RFC to deprecate calling json_serialize() on instanc=
es of classes marked with ZEND_ACC_NOT_SERIALIZABLE.</div><div dir=3D"ltr">=
<br></div><div dir=3D"ltr"><a href=3D"https://wiki.php.net/rfc/deprecate-js=
on_encode-nonserializable" rel=3D"noreferrer noreferrer noreferrer noreferr=
er" target=3D"_blank">https://wiki.php.net/rfc/deprecate-json_encode-nonser=
ializable</a><br></div><div dir=3D"ltr"><br></div><div dir=3D"ltr">I have a=
lso created a PR with the implementation here:</div><div dir=3D"ltr"><br></=
div><div dir=3D"ltr"><a href=3D"https://github.com/php/php-src/pull/15724" =
rel=3D"noreferrer noreferrer noreferrer noreferrer" target=3D"_blank">https=
://github.com/php/php-src/pull/15724</a><br></div><div dir=3D"ltr"><br></di=
v><div dir=3D"ltr">I have considered other options, both constraining the i=
mplementation to just Generator and/or to add special cases for Generator (=
and maybe Iterator), but they either continue to keep the asymmetry between=
 serialize() and json_encode() and/or are making things even more inconsist=
ent.</div><div dir=3D"ltr"><br></div><div dir=3D"ltr">Please tell me what y=
ou think, especially, if you agree that blanked-deprecating all of ZEND_ACC=
_NOT_SERIALIZABLE classes is acceptable BC-wise (after a bit of deliberatio=
n over the weekend, I think it is and most json-serializations of such mark=
ed classes are probably unintentional).</div><div dir=3D"ltr"><br></div><di=
v dir=3D"ltr">Thanks in advance for all comments</div><div dir=3D"ltr"><br>=
</div><div dir=3D"ltr">Philip</div><div dir=3D"ltr"><br></div><div dir=3D"l=
tr"><br></div></div></div></div></div>
</blockquote></div></div>

--000000000000d6f60c062164f4b4--