Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125439
Feedback-ID: id5114917:Fastmail
Precedence: bulk
MIME-Version: 1.0
Date: Thu, 05 Sep 2024 17:30:24 +0100
To: internals@lists.php.net
Message-ID: <1adfd0cd-416e-44e6-8d4b-7061a31199b0@app.fastmail.com>
In-Reply-To: <98553A91-FD3F-4E1B-91D9-D8B00CAD5FC5@getmailspring.com>
References: 
 <CAGKNXQG32aF58gPnf1ywbmde72F_Wwjib0oXhN_ve6336RnQXg@mail.gmail.com>
 <98553A91-FD3F-4E1B-91D9-D8B00CAD5FC5@getmailspring.com>
Subject: Re: [PHP-DEV] RFC: Deprecate json_encode() on classes marked as
 non-serializable
Content-Type: multipart/alternative;
 boundary=4b033b411f5542de9e11783381541924
From: imsop.php@rwec.co.uk ("Rowan Tommins [IMSoP]")

--4b033b411f5542de9e11783381541924
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

On Thu, 5 Sep 2024, at 17:03, John Coggeshall wrote:
> I would suggest we take a step back from this and look at it with a bit more of a wider lens. It seems to me that this would be a good place to have an attribute (e.g. `#[NotSerializable]` )  that could be defined for any class (with `ZEND_ACC_NOT_SERIALIZABLE`  being automatically given this attribute)? It just seems to be a more holistic approach that makes sense, rather than basing it on internal engine stuff and/or limiting it to internal objects.

It's really the opposite: if we had an attribute, it would be used to toggle the existing internal flag.

`ZEND_ACC_NOT_SERIALIZABLE` is just one of a long list of class, property and method flags which the engine uses internally. You can see the full list here: https://heap.space/xref/php-src/Zend/zend_compile.h?r=58aa6fc8#212

You'll notice that includes things like "final" and "private", which refer to straight-forward syntax in the language, as well as completely internal details like "preloaded". It also includes ZEND_ACC_ALLOW_DYNAMIC_PROPERTIES, which is the flag set if you add the #[AllowDynamicProperties] attribute on a class: https://heap.space/xref/php-src/Zend/zend_attributes.c?r=5a18279b#validate_allow_dynamic_properties

So if we had a #[NotSerializable] attribute (which I agree might be a good idea) it would be implemented by setting the `ZEND_ACC_NOT_SERIALIZABLE flag on a class definition, and `if this RFC passes, it would automatically apply to json_encode() as well as serialize().

Regards,
-- 
Rowan Tommins
[IMSoP]
--4b033b411f5542de9e11783381541924
Content-Type: text/html
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html><html><head><title></title><style type=3D"text/css">p.Mso=
Normal,p.MsoNoSpacing{margin:0}</style></head><body><div>On Thu, 5 Sep 2=
024, at 17:03, John Coggeshall wrote:<br></div><blockquote type=3D"cite"=
 id=3D"qt" style=3D""><div>I would suggest we take a step back from this=
 and look at it with a bit more of a wider lens. It seems to me that thi=
s would be a good place to have an attribute (e.g. <code>#[NotSerializab=
le]</code>&nbsp;)&nbsp; that could be defined for any class (with <code>=
ZEND_ACC_NOT_SERIALIZABLE</code>&nbsp; being automatically given this at=
tribute)? It just seems to be a more holistic approach that makes sense,=
 rather than basing it on internal engine stuff and/or limiting it to in=
ternal objects.<br></div></blockquote><div><br></div><div>It's really th=
e opposite: if we had an attribute, it would be used to toggle the exist=
ing internal flag.<br></div><div><br></div><div><code>ZEND_ACC_NOT_SERIA=
LIZABLE</code> is just one of a long list of class, property and method =
flags which the engine uses internally. You can see the full list here: =
<a href=3D"https://heap.space/xref/php-src/Zend/zend_compile.h?r=3D58aa6=
fc8#212">https://heap.space/xref/php-src/Zend/zend_compile.h?r=3D58aa6fc=
8#212</a><br></div><div><br></div><div>You'll notice that includes thing=
s like "final" and "private", which refer to straight-forward syntax in =
the language, as well as completely internal details like "preloaded". I=
t also includes ZEND_ACC_ALLOW_DYNAMIC_PROPERTIES, which is the flag set=
 if you add the #[AllowDynamicProperties] attribute on a class: <a href=3D=
"https://heap.space/xref/php-src/Zend/zend_attributes.c?r=3D5a18279b#val=
idate_allow_dynamic_properties">https://heap.space/xref/php-src/Zend/zen=
d_attributes.c?r=3D5a18279b#validate_allow_dynamic_properties</a><br></d=
iv><div><br></div><div>So if we had a #[NotSerializable] attribute (whic=
h I agree might be a good idea) it would be implemented by setting the <=
code>ZEND_ACC_NOT_SERIALIZABLE flag on a class definition, and </code>if=
 this RFC passes, it would automatically apply to json_encode() as well =
as serialize().<br></div><div><br></div><div>Regards,<br></div><div>-- <=
br></div><div>Rowan Tommins<br></div><div>[IMSoP]<br></div></body></html=
>
--4b033b411f5542de9e11783381541924--