Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:125436 X-Original-To: internals@lists.php.net Delivered-To: internals@lists.php.net Received: from php-smtp4.php.net (php-smtp4.php.net [45.112.84.5]) by qa.php.net (Postfix) with ESMTPS id 51C6D1A00BD for ; Thu, 5 Sep 2024 10:04:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=php.net; s=mail; t=1725530799; bh=YR7DxQrrQ4lDUWHv4psV/nHCrUuVcqwLhUzSNq8vgD0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=XuUc/j2NaBsEIoCrMGzChVEeudbnyv0nWiqpqc89F/uktKrtm0A/7tdt8FZecsNlj L/Ygyh3513Rx4CJXf+FVA3N6d1cHUz6lwY4F/mhhdNmt06MZDcxJPFlQ9R0mkJ3LB0 a6S5zsuhKYwqLK1TlmVdQdaxPSfLBF3t/4reWkQiaByv4Bxvv25C8Vs7hOaTmTdGLM /IEdem4UtRaQCW+BBkCQx1xInKYGdd1XF6UBAMM17uJ/BxRI+hCtraBKBG/3iWkVQN GNpQCNPp8xws7qeqWrbIkV8fUPoasZkd2Ye9whiTLT7dIDyn/OW/fknMJr4IggZRW/ sfBnluXRme63A== Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 44A3318005B for ; Thu, 5 Sep 2024 10:06:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_50,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,DMARC_MISSING,HTML_MESSAGE, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=4.0.0 X-Spam-Virus: No X-Envelope-From: Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Thu, 5 Sep 2024 10:06:37 +0000 (UTC) Received: by mail-ot1-f54.google.com with SMTP id 46e09a7af769-709340f1cb1so236567a34.3 for ; Thu, 05 Sep 2024 03:04:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sensational.ch; s=google; t=1725530679; x=1726135479; darn=lists.php.net; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ZaOpU9SqCF2vG2xder3ssHpVfBU4Nyepdh+CW3U/q4g=; b=qNluEU7QTz4k5hwAqFpLGqsijPj1xTvg+xSKIidIWuPYr3qizbpssICFO0Pw8BRFAf OOnPhVt5qdeyIGbRL2o5RT/RtnYa6w9Bwx+1GBrjpe/S57S63Ypb2fqRAM8xbWjsUG3j XEuA8zrFN6dDTMqaOMG/mge47mcwCpz3A1CetSViFwI/Uph37qE59J6+aPNIy/xzhqVz oC7LGW4Et+TamdErgRZ5mrmaXLMIe07xEfFjxhw9XjiWwZWhqc6yeIZt2pOY5I6AK6oy Un+ptrwvtlCq3wQRCC/8yKidnZhOFeuXKEob8BYLS8XfG/8LyVJuz6IR5L4O3tSWicUG wEYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725530679; x=1726135479; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZaOpU9SqCF2vG2xder3ssHpVfBU4Nyepdh+CW3U/q4g=; b=bT4Ekz82I2aag2zcmNVa1Zu2qJOC+I/r8MNjIHV0X7Gi96OTLJVWbY2ysTtqXfxc2W gAJ56fgUFPbZjHUhQ+vA7f5gPs08CWQu4wgQgbXPuG/CVSpfR1tpHZeOKXqmdy8L/b1X YQejLI5uDx6P/YhmYL374wJXEc3IRw4bstXpeA1/G8uFGQoiIXdBNkF+U5a7s2IW39es 04HXSPd4bVIShaKmEYj2Y0SMtgyXOd0bXsVwdSdqFzZXngTs4vQnvhEYV9hMzfqiG1BZ iDDHkh/uATAKFQLBI0pbAzWUBIOlYj0H2ub5FEc76Oab/gvQsctzYDIn2FV+84hpf3k2 9ZVA== X-Gm-Message-State: AOJu0Yw8wTZ8LDYK6Ni7qJdpTxNVrUhS4AlUvuZ8NEQAnErjUl5NR6XI 05pKtaZsLY7356D7ozTozLOtA8xyAIAY19jzO1YA2gndxzDN2asocIOaKOdXuoLIYjyYFPUUDbj 6zFtDWV+f2isXQJJAWsp1ZJgUNWkY0vdBSatD/w== X-Google-Smtp-Source: AGHT+IE/DNHsarB8rKwhbPTwV6khewR9wrgXnJk33fMHzMHWKpqD2KSjK2qULov4MnTSMrJYqWl7uDCTbqvM5HPjLr4= X-Received: by 2002:a05:6830:442a:b0:710:c120:f242 with SMTP id 46e09a7af769-710c120fbf9mr1967138a34.16.1725530678647; Thu, 05 Sep 2024 03:04:38 -0700 (PDT) Received: from 1064022179695 named unknown by gmailapi.google.com with HTTPREST; Thu, 5 Sep 2024 05:04:37 -0500 Received: from 1064022179695 named unknown by gmailapi.google.com with HTTPREST; Thu, 5 Sep 2024 03:04:34 -0700 Precedence: bulk list-help: list-post: List-Id: internals.lists.php.net x-ms-reactions: disallow MIME-Version: 1.0 (Mimestream 1.3.8) References: <24ee415a-5963-4b3d-a034-eacf4fed29ca@app.fastmail.com> In-Reply-To: <24ee415a-5963-4b3d-a034-eacf4fed29ca@app.fastmail.com> Date: Thu, 5 Sep 2024 05:04:37 -0500 Message-ID: Subject: Re: [PHP-DEV] RFC: Deprecate json_encode() on classes marked as non-serializable To: Rob Landers Cc: PHP internals , =?UTF-8?Q?Alexandru_P=C4=83tr=C4=83nescu?= Content-Type: multipart/alternative; boundary="00000000000026831406215c6bad" From: phofstetter@sensational.ch (Philip Hofstetter) --00000000000026831406215c6bad Content-Type: text/plain; charset="UTF-8" Hello Rob, > To add to this, we apparently use json_encode at work to serialize custom > exceptions, which appears to work. This RFC would break that, I think. > > Exception is not marked as ZEND_ACC_NOT_SERIALIZABLE and would not be affected. Philip --00000000000026831406215c6bad Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello Rob,


To add to this, we apparently use json_enco= de at work to serialize custom exceptions, which appears to work. This RFC = would break that, I think.=C2=A0


Exception is not marked as ZEN= D_ACC_NOT_SERIALIZABLE and would not be affected.

Philip<= /div> --00000000000026831406215c6bad--