Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125433
Precedence: bulk
MIME-Version: 1.0 (Mimestream 1.3.8)
References: <CAGKNXQG32aF58gPnf1ywbmde72F_Wwjib0oXhN_ve6336RnQXg@mail.gmail.com>
 <dd55ede0-f3f9-4fc1-aa8d-0a335d69bfd3@app.fastmail.com>
In-Reply-To: <dd55ede0-f3f9-4fc1-aa8d-0a335d69bfd3@app.fastmail.com>
Date: Thu, 5 Sep 2024 03:23:56 -0500
Message-ID: <CAGKNXQFiYinyDdTyTyY2zUuf+KdwKjqrEhdjMQ5jHEJp+8hZuA@mail.gmail.com>
Subject: Re: [PHP-DEV] RFC: Deprecate json_encode() on classes marked as non-serializable
To: Rob Landers <rob@bottled.codes>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary="000000000000052af506215b037f"
From: phofstetter@sensational.ch (Philip Hofstetter)

--000000000000052af506215b037f
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

 Hello Rob,


I think it would be good to list these non-serializable objects in the RFC.
> It doesn't have to be exhaustive, but the list includes throwables,
> weak-maps, weak-references, closures, fibers, etc. Some people may be
> relying on this behavior (and I'd be curious to know that use case myself=
).
>

Thank you for your note. As I went through to the code-base in order to
compile the list for the RFC, it also occurred to me that all anonymous
classes are marked as ZEND_ACC_NOT_SERIALIZABLE, but json_encode()-ing such
classes is unproblematic and probably very much desired for user land
classes.

I have updated the RFC and attached implementation to allow anonymous
classes to be json_encode()=E2=80=99d, provided their parent class is not m=
arked as
ZEND_ACC_NOT_SERIALIZABLE.

Thank you very much

Philip

--000000000000052af506215b037f
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<html><body><div dir=3D"ltr">
    Hello Rob,</div><div dir=3D"ltr"><br clear=3D"all"></div><div class=3D"=
gmail_quote"><br><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px =
0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" type=3D"=
cite"><div><div><div>I think it would be good to list these non-serializabl=
e objects in the RFC. It doesn&#39;t have to be exhaustive, but the list in=
cludes throwables, weak-maps, weak-references, closures, fibers, etc. Some =
people may be relying on this behavior (and I&#39;d be curious to know that=
 use case myself).<br></div></div></div></blockquote><div class=3D"gmail_qu=
ote"><br></div><div class=3D"gmail_quote" dir=3D"ltr">Thank you for your no=
te. As I went through to the code-base in order to compile the list for the=
 RFC, it also occurred to me that all anonymous classes are marked as ZEND_=
ACC_NOT_SERIALIZABLE, but json_encode()-ing such classes is unproblematic a=
nd probably very much desired for user land classes.</div><div class=3D"gma=
il_quote" dir=3D"ltr"><br></div><div class=3D"gmail_quote" dir=3D"ltr">I ha=
ve updated the RFC and attached implementation to allow anonymous classes t=
o be json_encode()=E2=80=99d, provided their parent class is not marked as =
ZEND_ACC_NOT_SERIALIZABLE.</div><div class=3D"gmail_quote" dir=3D"ltr"><br>=
</div><div class=3D"gmail_quote" dir=3D"ltr">Thank you very much</div><div =
class=3D"gmail_quote" dir=3D"ltr"><br></div><div class=3D"gmail_quote" dir=
=3D"ltr">Philip</div>
</div></body></html>

--000000000000052af506215b037f--