Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125419
Feedback-ID: ifab94697:Fastmail
Precedence: bulk
MIME-Version: 1.0
Date: Wed, 04 Sep 2024 21:18:17 +0200
To: "Jakob Givoni" <jakob@givoni.dk>
Cc: internals@lists.php.net
Message-ID: <4f404d71-6581-44d6-8a87-dc6c605e0a60@app.fastmail.com>
In-Reply-To: 
 <CAJmjfvX4baKOA=MgM8FntPavtnTC+dh+bbfncfP8f1OwiGQDzA@mail.gmail.com>
References: <2716f729-4008-4f75-8412-861d8960b746@app.fastmail.com>
 <df217c26-cb23-46d6-b931-431c8971599c@app.fastmail.com>
 <CAJmjfvX4baKOA=MgM8FntPavtnTC+dh+bbfncfP8f1OwiGQDzA@mail.gmail.com>
Subject: Re: [PHP-DEV] function autoloading v4 RFC
Content-Type: multipart/alternative;
 boundary=cdb8721a31234491856e30d261580825
From: rob@bottled.codes ("Rob Landers")

--cdb8721a31234491856e30d261580825
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Wed, Sep 4, 2024, at 17:16, Jakob Givoni wrote:
>=20
>=20
> On Tue, Sep 3, 2024 at 11:49=E2=80=AFPM Rob Landers <rob@bottled.codes=
> wrote:
>> 1. I've removed the BC break=E2=80=94the 'type' of the autoloadee wil=
l not be passed to the autoloader. This can allow someone to use spl_aut=
oload for function autoloading if they so desire.
>=20
> Unless I'm missing something, the main example in the RFC still shows =
a function which expects the $type as the second parameter. Is that inte=
ntional?

Nope! Thanks for the heads-up; despite reading it four or five times, I =
missed this! I've now fixed it.

> =20
>> 2. I've removed artificial restrictions on the constants in which all=
 functions that take them can accept both at the same time and behave ap=
propriately.
>=20
> I'm not a big fan passing flags and using binary operations to combine=
 options into a single parameter.=20
> It works, but it's opaque and old-school.
> We have both named parameters and enums now, can't we just use those g=
oing forward, making each option a separate parameter or using enums wit=
h 3 cases, FUNCTION, CLASS or BOTH?=20

Thank you for your opinion, but for cases like this, enums is probably o=
ne of the worst choices IMHO. As mentioned towards the end of the RFC, I=
'd like to add further support for other things, such as constants and s=
tream filters. Further, it appears that enums cannot be used in SPL (at =
least, I couldn't get it to link) due to SPL having a recursive dependen=
cy on itself. This is what Gina's RFC seeks to rectify by breaking autol=
oading out of SPL. This RFC focuses purely on function autoloading.

=E2=80=94 Rob
--cdb8721a31234491856e30d261580825
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html><html><head><title></title><style type=3D"text/css">p.Mso=
Normal,p.MsoNoSpacing{margin:0}</style></head><body><div>On Wed, Sep 4, =
2024, at 17:16, Jakob Givoni wrote:<br></div><blockquote type=3D"cite" i=
d=3D"qt" style=3D""><div dir=3D"ltr"><div dir=3D"ltr"><br></div><div><br=
></div><div class=3D"qt-gmail_quote"><div dir=3D"ltr" class=3D"qt-gmail_=
attr">On Tue, Sep 3, 2024 at 11:49=E2=80=AFPM Rob Landers &lt;rob@bottle=
d.codes&gt; wrote:<br></div><blockquote class=3D"qt-gmail_quote" style=3D=
"margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;bor=
der-left-width:1px;border-left-style:solid;border-left-color:rgb(204, 20=
4, 204);padding-left:1ex;">1. I've removed the BC break=E2=80=94the 'typ=
e' of the autoloadee will not be passed to the autoloader. This can allo=
w someone to use spl_autoload for function autoloading if they so desire=
.<br></blockquote><div><br></div><div>Unless I'm missing something, the =
main example in the RFC still shows a function which expects the $type a=
s the second parameter. Is that intentional?<br></div></div></div></bloc=
kquote><div><br></div><div>Nope! Thanks for the heads-up; despite readin=
g it four or five times, I missed this! I've now fixed it.<br></div><div=
><br></div><blockquote type=3D"cite" id=3D"qt" style=3D""><div dir=3D"lt=
r"><div class=3D"qt-gmail_quote"><div>&nbsp;<br></div><blockquote class=3D=
"qt-gmail_quote" style=3D"margin-top:0px;margin-right:0px;margin-bottom:=
0px;margin-left:0.8ex;border-left-width:1px;border-left-style:solid;bord=
er-left-color:rgb(204, 204, 204);padding-left:1ex;">2. I've removed arti=
ficial restrictions on the constants in which all functions that take th=
em can accept both at the same time and behave appropriately.<br></block=
quote><div><br></div><div>I'm not a big fan passing flags and using bina=
ry operations to&nbsp;combine options into a single parameter.&nbsp;<br>=
</div><div>It works, but it's opaque and old-school.<br></div><div>We ha=
ve both named parameters and enums now, can't we just use those going fo=
rward, making each option a separate parameter or using enums with 3 cas=
es,&nbsp;FUNCTION, CLASS or BOTH?&nbsp;<br></div></div></div></blockquot=
e><div><br></div><div>Thank you for your opinion, but for cases like thi=
s, enums is probably one of the worst choices IMHO. As mentioned towards=
 the end of the RFC, I'd like to add further support for other things, s=
uch as constants and stream filters. Further, it appears that enums cann=
ot be used in SPL (at least, I couldn't get it to link) due to SPL havin=
g a recursive dependency on itself. This is what Gina's RFC seeks to rec=
tify by breaking autoloading out of SPL. This RFC focuses purely on func=
tion autoloading.<br></div><div><br></div><div id=3D"sig121229152">=E2=80=
=94 Rob<br></div></body></html>
--cdb8721a31234491856e30d261580825--