Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125416
Precedence: bulk
MIME-Version: 1.0
References: <2716f729-4008-4f75-8412-861d8960b746@app.fastmail.com> <df217c26-cb23-46d6-b931-431c8971599c@app.fastmail.com>
In-Reply-To: <df217c26-cb23-46d6-b931-431c8971599c@app.fastmail.com>
Date: Wed, 4 Sep 2024 17:16:59 +0200
Message-ID: <CAJmjfvX4baKOA=MgM8FntPavtnTC+dh+bbfncfP8f1OwiGQDzA@mail.gmail.com>
Subject: Re: [PHP-DEV] function autoloading v4 RFC
To: Rob Landers <rob@bottled.codes>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary="000000000000feb7cb06214caa88"
From: jakob@givoni.dk (Jakob Givoni)

--000000000000feb7cb06214caa88
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Sep 3, 2024 at 11:49=E2=80=AFPM Rob Landers <rob@bottled.codes> wro=
te:

> 1. I've removed the BC break=E2=80=94the 'type' of the autoloadee will no=
t be
> passed to the autoloader. This can allow someone to use spl_autoload for
> function autoloading if they so desire.


Unless I'm missing something, the main example in the RFC still shows a
function which expects the $type as the second parameter. Is that
intentional?


> 2. I've removed artificial restrictions on the constants in which all
> functions that take them can accept both at the same time and behave
> appropriately.


I'm not a big fan passing flags and using binary operations to combine
options into a single parameter.
It works, but it's opaque and old-school.
We have both named parameters and enums now, can't we just use those going
forward, making each option a separate parameter or using enums with 3
cases, FUNCTION, CLASS or BOTH?

Best,
Jakob

--000000000000feb7cb06214caa88
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Tue, Sep 3, 2024 at 11:49=E2=80=AF=
PM Rob Landers &lt;rob@bottled.codes&gt; wrote:</div><blockquote class=3D"g=
mail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204=
,204,204);padding-left:1ex">1. I&#39;ve removed the BC break=E2=80=94the &#=
39;type&#39; of the autoloadee will not be passed to the autoloader. This c=
an allow someone to use spl_autoload for function autoloading if they so de=
sire.</blockquote><div><br></div><div>Unless I&#39;m missing something, the=
 main example in the RFC still shows a function which expects the $type as =
the second parameter. Is that intentional?</div><div>=C2=A0</div><blockquot=
e class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px s=
olid rgb(204,204,204);padding-left:1ex">2. I&#39;ve removed artificial rest=
rictions on the constants in which all functions that take them can accept =
both at the same time and behave appropriately.</blockquote><div><br></div>=
<div>I&#39;m not a big fan passing flags and using binary operations to=C2=
=A0combine options into a single parameter.=C2=A0</div><div>It works, but i=
t&#39;s opaque and old-school.</div><div>We have both named parameters and =
enums now, can&#39;t we just use those going forward, making each option a =
separate parameter or using enums with 3 cases,=C2=A0FUNCTION, CLASS or BOT=
H?=C2=A0</div><div><br></div><div>Best,</div><div>Jakob</div><div><br></div=
></div></div>

--000000000000feb7cb06214caa88--